From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B63C04EB9 for ; Mon, 3 Dec 2018 12:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62E552087F for ; Mon, 3 Dec 2018 12:12:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62E552087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbeLCMMr (ORCPT ); Mon, 3 Dec 2018 07:12:47 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:42081 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbeLCMMr (ORCPT ); Mon, 3 Dec 2018 07:12:47 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gTn4u-0001dr-AG from Vladimir_Zapolskiy@mentor.com ; Mon, 03 Dec 2018 04:11:56 -0800 Received: from [137.202.108.125] (137.202.0.90) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 3 Dec 2018 12:11:52 +0000 Subject: Re: [PATCH linux-next v2 0/6] clk: renesas: adg: add AVB Clock To: , , , , References: <20181203112200.18220-1-jiada_wang@mentor.com> CC: , From: Vladimir Zapolskiy Message-ID: Date: Mon, 3 Dec 2018 14:11:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <20181203112200.18220-1-jiada_wang@mentor.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiada, On 12/03/2018 01:21 PM, jiada_wang@mentor.com wrote: > From: Jiada Wang > > on R-Car SoCs there are AVB Counter Clocks, each clock has 12bits integral > and 8 bits fractional dividers which operates with S0D1ϕ clock. > > This patch-set adds 'adg' clock to R-Car Soc, and changes adg driver to > register avb clocks when clock-cells of rcar_sound node is 2. > > --- > v2: > - expends adg register size and register avb clocks instead of > add new clk-avb driver > - Add adg clock > > v1: initial version > > Jiada Wang (2): > dt-bindings: clock: add clock id for renesas adg clocks > ASoC: rsnd: add avb clocks > > Takeshi Kihara (4): > clk: renesas: r8a7795: Add ADG clock > clk: renesas: r8a7796: Add ADG clock > clk: renesas: r8a77990: Add ADG clocks > clk: renesas: r8a77995: Add ADG clock > plural 'clocks' for r8a77990 vs. 'clock' in other cases, please unify subjects. You can consider to add the ADG clock description for r8a77965 / M3-N as well. > drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + > drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 + > drivers/clk/renesas/r8a77990-cpg-mssr.c | 1 + > drivers/clk/renesas/r8a77995-cpg-mssr.c | 1 + > include/dt-bindings/clock/renesas-adg.h | 11 + The new header file added above is not needed in my opinion. > sound/soc/sh/rcar/adg.c | 306 +++++++++++++++++++++++- > sound/soc/sh/rcar/gen.c | 9 + > sound/soc/sh/rcar/rsnd.h | 9 + > 8 files changed, 330 insertions(+), 9 deletions(-) > create mode 100644 include/dt-bindings/clock/renesas-adg.h > -- Best wishes, Vladimir