From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E382C3266 for ; Tue, 13 Jan 2026 14:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768315815; cv=none; b=Qn2LUCFGkFiFI73eFqEcrhHnPSWSBZcfzhPtdLk4haib6Gh9AYPgqgzwyh2jqm+0V+tUb39JDRCEnsF1qhVm/QN7BicuChj5oowwFiQaL840CdZf68oKjrd8h3whXJ/s6e6eHydGppYK2TYcbfJPacn7A7Kx5aW5OZtLbO/Pd0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768315815; c=relaxed/simple; bh=xU/v+1+Ag2SE9i72VtMK72lv1azlPIgm9eEwAdK1Gdg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wl5Ea9khhV4nhwIm0LKzzFHEM+8MTjY/ZrVBg7IU7bST0HjDDATliehAKiiFOj9W78+16jeEHDBVUZ5RjzFjrmFm//QgVEXeovmQ5W9zbt90U7Qyy+5Tilh5ZFkwTgOe7DtoKzUNPh+6b9pXjdkKm3mby50xibjEKCfnFvt6LCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vzqcb2dt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aJqPMVCq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vzqcb2dt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aJqPMVCq" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D7nNUn3299965 for ; Tue, 13 Jan 2026 14:50:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QcwxICmrR4gn1iEbkWO2XmXQzG34ygAOuMpV2HL6dSc=; b=Vzqcb2dt4qxwuj3n 3tbwEq+TxmsomftMbdaJKB2dWG02cGZQ0B081IHQSeqUVPmXQjcZDZc6D254Acte II3d9yzPRmlkewFJLrY4w1CTuMTq75jwimIiyunT7t4D3RmQAwjkgh0asG+N1GWU 7ecJ+Jvvmox+4AqJmqFXDUPK8jFO/MEyoZtBA9hnGc+yPcWdmotPRWiaQ3tsDZK9 1ELHWZaOu9wXq2ITxn7pTZwfCDGTin829GIYqwNA1fpV3nzMvqlO5hSTZtpNFoDF qCqWP3P2dNIpfl1Fdg+RnsCfpSWhiWku84zBJ4EL/rnfWgB3uV3mZmU+Zapc+z0L IJorww== Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bn6jmb5mh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 14:50:11 +0000 (GMT) Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-64475bee138so2007829d50.2 for ; Tue, 13 Jan 2026 06:50:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768315811; x=1768920611; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QcwxICmrR4gn1iEbkWO2XmXQzG34ygAOuMpV2HL6dSc=; b=aJqPMVCq24tyJKm3I3aRXyyK3nLt3XYod2bpJ7yKvep4EzCg6zkWlAuqOnUhRYqe62 YWWkmfvtDdNnNVly9UQmGA+wugfpNPEGc+vZEefNbyZYxSso4DKa9r8ft+/MG3w0Ij4w yYOWS6c2LUeV9rgkrhtQknPH4LJispw03vIna1HfbPxRsh9Ttb0rDPVJxhGKwhDGOoUM 05KzYYE195iOWEliQKKFy2RsUgic8pdOKxHLMhVTkJdQ0Nh1ToyaKT1ATDz/XWGceLsd Yk1NY4m63anWCp7nxyTk4l+rrexcdGQPodSWb8rri9escXd2mqs1l2MhhKOrwBw/nj2I jiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768315811; x=1768920611; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QcwxICmrR4gn1iEbkWO2XmXQzG34ygAOuMpV2HL6dSc=; b=N+IEx9+Vgd72kNIfpqY6IMkfqbSRysQj0LO+KllV3KnFbJBO54IzJGYyWICvfF2Fq5 1i9g/jQg1VaFjFpcyXql5CdLKIxBEmUeGoTY3FOr6Tz31QKNGbNJgihY1BI++/D2pPgq DoJlVwJyCIxHa722hpg/sKNVvqP7dNxGiC3C1AVG+qcfPTlq0s65PLArqVCTJRO8x+PU q97Pu4FwcotYFy7C/JFG5h9Pv2suPLUGX7pEQ6pylJFIbW5q9c9Cz/1i+tSoDlmx9cCr +rl5FVzC7MPp4DuByk3eD8XMH6LqU9JOV8GTSLrNpGXKCCUveDbY8Ik6I+CvNIV9dQ/1 GS8A== X-Forwarded-Encrypted: i=1; AJvYcCXf32spZFN//kysgx+rfZf1jfe6Kpe7GlD7nBi5FNy+kB0/GXf0ehvprKoI1A8KNmQye7LIixfF9gsO+cs=@vger.kernel.org X-Gm-Message-State: AOJu0YywbmU/XOeFqM4c9ce4kkTxER4FwrUHpxOczc9H+Of6zc/xBQgV vekVF3CY6mRm52FF3HE6Fb/RArXbPc199h/Dwt+qbD5S9TlViAHgRtU0IdDLwhXhyN9a/gAdKuP xVEa/bXk5KNLnAFwUeZbze/slCKyJgVPsspUDNyvnP/rj2I4ZbsmyFcUEiMZEM6G1deo= X-Gm-Gg: AY/fxX6ddn0zkPv08oi9WvKkHYcXL5JCpPmhJaIsLp0sRnmyHpfiiatJKdElNDTpN8a iTb6vu3xTh7azAy4RPivuoDxcP9cm3hIhTo2yjGRl2PoF/xZZKsAU6THGLgX8LrWmcbXM3Alsux UzZ/ny3f/y343Y+t6s8nAxRljsLXqNARhLd9WeT0Fx1M1HLE6jyiGFfT5d3gQJ8+EL/NotlUNWJ 4AUFqxPYxJg8bms5TOkCYpo5u6g3TVAV46U3Dk3QikoTtQwOxq3ADgLw0Mhyyd2AZKWhVdfeG9c WfUg1h4ijd4SKvV3i9sK9VTJjsfesFZPEysMI3jpioavGHW9NmaL7CUjtarvsZsgjWpO1Wce+dj JlXhdT3rNAngdp0MuLCTEnxh9bpOIJUWGBDaSe3K3DIDM0osWD1q75WxLXZ+SEgkioZY= X-Received: by 2002:a05:690c:91:b0:78f:c0f3:2e10 with SMTP id 00721157ae682-790b5701642mr160364707b3.9.1768315810526; Tue, 13 Jan 2026 06:50:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IHp1gIBS5jEoXkt1plSH+bt7nf2F4KHwCWqllM1mxQRTlOiQ2zlHM62mWIaorCJLX3SUhEhcg== X-Received: by 2002:a05:690c:91:b0:78f:c0f3:2e10 with SMTP id 00721157ae682-790b5701642mr160364427b3.9.1768315810084; Tue, 13 Jan 2026 06:50:10 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b86fc303d7esm1058489866b.2.2026.01.13.06.50.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 06:50:09 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 15:50:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] clk: qcom: dispcc-sdm845: Enable parents for pixel clocks To: Val Packett , petr.hodina@protonmail.com, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Michael Turquette , Stephen Boyd , David Heidelberg , Taniya Das Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, phone-devel@vger.kernel.org References: <20260107-stability-discussion-v2-1-ef7717b435ff@protonmail.com> <702e4696-5ff6-4c72-bce4-1a9a8ee1ba18@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <702e4696-5ff6-4c72-bce4-1a9a8ee1ba18@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kMbkRdk6QBaxeqkYCRWtWCAJOWsx-AKK X-Authority-Analysis: v=2.4 cv=SK1PlevH c=1 sm=1 tr=0 ts=69665ba3 cx=c_pps a=J+5FMm3BkXb42VdG8aMU9w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=sfOm8-O8AAAA:8 a=rC8bUFBNB4MWVkYa7ykA:9 a=QEXdDO2ut3YA:10 a=Epx66wHExT0cjJnnR-oj:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-ORIG-GUID: kMbkRdk6QBaxeqkYCRWtWCAJOWsx-AKK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDEyNCBTYWx0ZWRfXyBYA5+vMEwo+ EHhbj3MXEbcyoeeEWfMLIVcjslqfPDxow+m9h1a1Z/N9AF4nG5WGMdIPSUTHhpsmKzwRh50upXn vhcVcRnWY0iVAnfooegrnFtDOeU8bKgvcn9GV2H3mZBzR3NQKpCN3WSznLgIDDWNjlztJb9Uiv2 gmBLqaU8to62x/XQ62CymqWMsCkiskhH9bLjJVS5WqxsnW3HJmCEUkyZGP3X8oG86PAAbUFAo/r /yzHeVsCON/de+1zya28hPkvU+uldPcy3jfLi1SSFovQdQJ5yLb3E0y/isgS5eiP++hcyRPGtq9 Zs0H1PYG8UDmuhSawI1V48mVj8SInZXlTJis4o1cnahCVO5dlQBGn1P6X5aiwmq+r0/vKgWT4nH 758afw4Qar8iiWAEXIkmomow7pBM1wRdlu9aLw572HI64Vz1QH/4ur7NPLXy4zoJqw1u8/LP0qi hm2WUHsbwzqhd3qw4Aw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130124 On 1/9/26 12:00 AM, Val Packett wrote: > > On 1/7/26 8:44 AM, Petr Hodina via B4 Relay wrote: >> From: Petr Hodina >> >> Add CLK_OPS_PARENT_ENABLE to MDSS pixel clock sources to ensure parent >> clocks are enabled during clock operations, preventing potential >> stability issues during display configuration. >> >> Fixes: 81351776c9fb ("clk: qcom: Add display clock controller driver for SDM845") >> Signed-off-by: Petr Hodina >> --- >> We are currently running the latest linux-next snapshots (next-202511* >> and next-202512*) and have encountered random freezes and crashes on the >> Pixel 3, as well as crash dumps on the OnePlus 6 and 6T. >> >> This commit fixes the stability issue. I've checked other SDM dispcc >> files and they also contain this configuration. > > Hm, we don't have this flag set in dispcc-x1e80100.c either! > > The only random freeze we have on that platform seems related to PCIe ASPM with NVMe drives, but during display configuration.. *extremely* rarely, but the eDP display output can get stuck on a blue screen. Many run with clk_ignore_unused for the early uefi framebuffer though. Your device doesn't have a DSI-attached display The Linux clock controller representation of the DSI PHY implements an actually meaningful set of operations that (un)gate the clock Both DP and eDP PHYs just provide funny fixed clocks to make the clock tree resonable and filter allowed rates Konrad