From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A27C184A4E; Wed, 31 Jan 2024 15:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706714400; cv=none; b=BCRDT8AHR7hFPE2pwNG9CgFNQIT+aOU96HQuRWjjo9+f9pq6kTWyzRmMs7ofO01OLaVAC16i79k6y2/mbfCsj2PXwuRgUCVaw8hZb7tQIBQ3zT5LRE/Of8yugBxD72tNQkMMOhSQMpm50hgM0guOrVANl9t66ZpKzaywOLwMCRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706714400; c=relaxed/simple; bh=zraZ4GAWYd3k1nTN/PDgHLRPmEqVILITkc+KhQpafPM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iSPEoZ8RWfPZikgOOgF0DxtmCgeQJuVuVixuEkmXBshCqXTH9hFiagklHaTF70ZTeRU7FJq96Odb3Zb1w4J3zjxG/IjICuqg/B8hMqUvSBnGQse/tXG8cf3S+6tedW8rJErxIbEfLcuTQXrCNMKklaLl4vDuvQU7veZxNKL5mEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=X9ZQmHcB; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="X9ZQmHcB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=KgQbi6lyjFW5qirmbLoeKbLsIIOOKokmJfR24WR5lg0=; b=X9ZQmHcBVoKAYlIjjw+sYEBzyB 2ACdNbkF9Hd0P/VS6B72nC8Gr5DvavMKEvsGhAVx4M4Gv/ZL/jbiDL/0MbXL2Z1fsj3sp85kADzln VGRkA9SfrfPpRqDGMUCHJJ13AJml/POrk5rGp1p44PdTipetUPmYqBdzK16R52a6+JgA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rVCNS-006ap9-HN; Wed, 31 Jan 2024 16:19:50 +0100 Date: Wed, 31 Jan 2024 16:19:50 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Stefan Eichenberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 net-next 10/13] net: phy: marvell-88q2xxx: make mv88q2xxx_config_aneg generic Message-ID: References: <20240122212848.3645785-1-dima.fedrau@gmail.com> <20240122212848.3645785-11-dima.fedrau@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122212848.3645785-11-dima.fedrau@gmail.com> On Mon, Jan 22, 2024 at 10:28:43PM +0100, Dimitri Fedrau wrote: > Marvell 88Q2xxx devices follow the same scheme, after configuration they > need a soft reset. Soft resets differ between devices, so we use the > .soft_reset callback instead of creating .config_aneg callbacks for each > device. > > Signed-off-by: Dimitri Fedrau Reviewed-by: Andrew Lunn Andrew