From: Juergen Gross <jgross@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Cc: Eduardo Otubo <otubo@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen-netfront: Fix hang on device removal
Date: Wed, 28 Feb 2018 20:21:30 +0100 [thread overview]
Message-ID: <d6411bf3-9edd-15a7-1f4e-a9f51869129d@suse.com> (raw)
In-Reply-To: <20180228122323.3914-1-jandryuk@gmail.com>
On 28/02/18 13:23, Jason Andryuk wrote:
> A toolstack may delete the vif frontend and backend xenstore entries
> while xen-netfront is in the removal code path. In that case, the
> checks for xenbus_read_driver_state would return XenbusStateUnknown, and
> xennet_remove would hang indefinitely. This hang prevents system
> shutdown.
>
> xennet_remove must be able to handle XenbusStateUnknown, and
> netback_changed must also wake up the wake_queue for that state as well.
>
> Fixes: 5b5971df3bc2 ("xen-netfront: remove warning when unloading module")
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> Cc: Eduardo Otubo <otubo@redhat.com>
Committed to xen/tip for-linus-4.16a
Juergen
next prev parent reply other threads:[~2018-02-28 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 12:23 Jason Andryuk
2018-02-28 15:21 ` [Xen-devel] " Boris Ostrovsky
2018-02-28 19:21 ` Juergen Gross [this message]
2018-04-19 18:10 ` Simon Gaiser
2018-04-19 18:14 ` Jason Andryuk
2018-04-19 20:09 ` Simon Gaiser
2018-04-20 12:41 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6411bf3-9edd-15a7-1f4e-a9f51869129d@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jandryuk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®