From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7992C433FE for ; Sat, 22 Oct 2022 10:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiJVKvo (ORCPT ); Sat, 22 Oct 2022 06:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230082AbiJVKvT (ORCPT ); Sat, 22 Oct 2022 06:51:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 341EE1AD682 for ; Sat, 22 Oct 2022 03:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666433238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebXIiW1Yrr/qNgGjH/kQ+HrJ7XBx9IGzWP9027pe0Dc=; b=LtmJtPU/pk7BS2EBMqKNn5zEeDkn5aj33/jN3bbI+nqjBJD3mY1Jf5JE97nwGKG0kqopOE w2Hrbjqjj871J/FEErdH8UaxurgQky8ggUdfIKt7CW2ars9kzgwV/VnGgGJ2Jp3Ih6he+v ufpOkEVFKPoDYBoWG8xU5SYhhljAWTA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-632-IwECbpzKOTuoZ3d1m812qQ-1; Sat, 22 Oct 2022 03:46:07 -0400 X-MC-Unique: IwECbpzKOTuoZ3d1m812qQ-1 Received: by mail-ed1-f70.google.com with SMTP id w20-20020a05640234d400b0045d0d1afe8eso4790949edc.15 for ; Sat, 22 Oct 2022 00:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ebXIiW1Yrr/qNgGjH/kQ+HrJ7XBx9IGzWP9027pe0Dc=; b=FdpK/pIRZy9Iy/CD8YCHL/y1qCm+zGNxQEGjludzU2FFFXA4ZRjRiLCggc3v/zi/jf udJ4u0UAgu6gG0vft+150f5/WWiRNalF6h6h6GzvW2YJEhFRo3X5XKNX8W6JIo8Pz+Gd XrDudcnMGVGPfWh3MN4dTKfxk3ac5S7bBkCPjLDswfeYL6eiDKpagOHePeTTUAz+Seww vkAnxATaz3EYxBdmI/XpRYiOk8MeN+1cbBceO6WSzfQ2C4tM7+WvKqlZ7mzTkisaAdkw c25fbIzS+2khlHQz1eg91NmXvbYM27e5Hjv1xg0gUMzi9XNrazsqzUe/mChCwgGkdg8e jAAA== X-Gm-Message-State: ACrzQf0CcWOHNwjHmNbmCGkigmZf2MXZMEpCoo4+/qjxh7zzI1D9RRb4 fQ05taxpo6LphTLpWGueCNZqWMzhFD1aYJXwJmcojXWvAszFSLeZREyjkhJl4BfGIcWo2WC8njc 8ZmIL2tUoRAOMDYDu0rqOd46d X-Received: by 2002:a17:906:15ca:b0:78d:b7b3:2afa with SMTP id l10-20020a17090615ca00b0078db7b32afamr19053536ejd.69.1666424766893; Sat, 22 Oct 2022 00:46:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6kAr92I5pdKp3ObTKLZnFdDIJSEpTIIYDr+mzB+LsUa9WEBSgGMSSskq7p6IYXK5X2pBwSlQ== X-Received: by 2002:a17:906:15ca:b0:78d:b7b3:2afa with SMTP id l10-20020a17090615ca00b0078db7b32afamr19053521ejd.69.1666424766672; Sat, 22 Oct 2022 00:46:06 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:2f4b:62da:3159:e077? ([2001:b07:6468:f312:2f4b:62da:3159:e077]) by smtp.googlemail.com with ESMTPSA id kz1-20020a17090777c100b0073d753759fasm12882546ejc.172.2022.10.22.00.46.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Oct 2022 00:46:05 -0700 (PDT) Message-ID: Date: Sat, 22 Oct 2022 09:46:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] KVM: SVM: Fix reserved fields of struct sev_es_save_area Content-Language: en-US To: Sean Christopherson , Carlos Bilbao Cc: tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, venu.busireddy@oracle.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Lendacky, Thomas" , bilbao@vt.edu References: <986a5886-4ddc-aa88-db52-e8781ec95aed@amd.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/22 18:29, Sean Christopherson wrote: > If we really want to the number to have any kind of meaning without needing a pile > of churn for every update, the best idea I can think of is to name them reserved_. > That way only the affected reserved field needs to be modified when adding new > legal fields. But that has it's own flavor of maintenance burden as calculating > and verifying the offset is a waste of everyone's time. Finding the right offsets is usually pretty quick because they can be found in the manual (or something close to the offset can be found there) and verifying them can be done with BUILD_BUG_ON. If Carlos prepared a patch using offsets (with BUILD_BUG_ON to ensure no future bitrot) I would apply it gladly. If it's just renumbering as in this one, however, I'd just ignore it. Paolo Paolo