From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED668C7EE23 for ; Tue, 23 May 2023 15:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237498AbjEWPwt (ORCPT ); Tue, 23 May 2023 11:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231615AbjEWPwq (ORCPT ); Tue, 23 May 2023 11:52:46 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1418F8E for ; Tue, 23 May 2023 08:52:46 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 82F165C010A; Tue, 23 May 2023 11:52:45 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 23 May 2023 11:52:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1684857165; x=1684943565; bh=zw CjvXn53rcaO3Y1t4OkLX7eScSqHORtEFyq3yn/8kI=; b=MbLkHCgetIrafdPdgQ 0ZQbl61Tin0qDctxV4gw+14zHIHhiZV3q6uOpN/GZF+AFCk+9BmNZWLkwq6+d1Ub L2gW/ViVfHOGcTIJ4V3g+4M6dfZuLQSgWDOyxhq81lSZkwUjnnWaW2QHFqQGsYuw 7fbIni8sgQAwisIkVZm7vu1WC3f8C5o95hT78//FIKymPVXHtZvigFGFN6F83yCa l7HS/rTLJlC0wKEm+UELgTdk/shK5BvfI2z72JLmfhesqDOvAa1hCdsgLzUgLoZ9 6iqlnzTou7liQGqUtietwzpnzqLcdAjy+UAnW2VismYfg/RPjtUSUMXRXarZs69D wRvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684857165; x=1684943565; bh=zwCjvXn53rcaO 3Y1t4OkLX7eScSqHORtEFyq3yn/8kI=; b=iOVHXOMCdEwIi26GWNXZNX1Xh25AS QDx9AiORNWxqW5X+l+Z8bmpq7GBTsFwUE5qcQgdFT25LBNizeITOwcIxI4282NnO wwbps7EFeDYmWuQVoIadEpbde2ZZhEXowmaPRefEM3u4/2K8fz1wZFt1CoHP2DAJ gwUha4aV5nENl9GfspeRa07vVCY+/e4bNq4FyCF+GwWTllcQB7tFEKg7pzXPmBbD ZdmnPxDKgJEdKOFVB71bndkAKY8LTZqLnxrrdP4yUw5IcSZc2XxEBOj8KvO5ZPt9 QZnELJDWbCsfzb7VMzHhOrCq6Z2cFUVqh4ZV7Vf/LrueioqkdmZJE4L/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejfedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5F4FFB60086; Tue, 23 May 2023 11:52:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd Mime-Version: 1.0 Message-Id: In-Reply-To: <20230523073952.1.I60217a63acc35621e13f10be16c0cd7c363caf8c@changeid> References: <20230523073952.1.I60217a63acc35621e13f10be16c0cd7c363caf8c@changeid> Date: Tue, 23 May 2023 17:52:24 +0200 From: "Arnd Bergmann" To: "Doug Anderson" , "Andrew Morton" Cc: "Catalin Marinas" , "Lecopzer Chen" , "Pingfan Liu" , "Sumit Garg" , "Will Deacon" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: Only HAVE_HARDLOCKUP_DETECTOR_PERF if the PMU config is enabled Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023, at 16:39, Douglas Anderson wrote: > If you try to enable the arm64 perf-based hardlockup detector but you > don't enable CONFIG_ARM_PMU then you'll get an error: > > arch/arm64/kernel/watchdog_hld.c: In function > 'arch_perf_nmi_is_available': > arch/arm64/kernel/watchdog_hld.c:35:16: error: implicit declaration of > function 'arm_pmu_irq_is_nmi' [-Werror=implicit-function-declaration] > 35 | return arm_pmu_irq_is_nmi(); > > It doesn't make sense to enable HAVE_HARDLOCKUP_DETECTOR_PERF if the > PMU isn't enabled. Let's add a dependency. HW_PERF_EVENTS is a synonum > for ARM_PMU and makes the most logical sense here, so add the > dependency on that. > > Reported-by: Arnd Bergmann > Closes: https://lore.kernel.org/r/20230522114922.1052421-1-arnd@kernel.org > Fixes: 02ea35ee19d9 ("arm64: enable perf events based hard lockup detector") > Signed-off-by: Douglas Anderson Acked-by: Arnd Bergmann Still build testing it with randconfigs, but I assume it's fine. Arnd