From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103Ab0ATPG6 (ORCPT ); Wed, 20 Jan 2010 10:06:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751846Ab0ATPG6 (ORCPT ); Wed, 20 Jan 2010 10:06:58 -0500 Received: from mail-fx0-f215.google.com ([209.85.220.215]:58652 "EHLO mail-fx0-f215.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952Ab0ATPG5 convert rfc822-to-8bit (ORCPT ); Wed, 20 Jan 2010 10:06:57 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=d5taPr3yzExy4gq9vKNHZcBJ9vmuTOqeG8DuWpmrVA7sk8I/MGwEevxkMWnnx/rV+E qeykNMCPBLCYj4s6EMSCjAlg0OaOM8t0b7poi259q8+154XcBKQewxgUamOffOVrjKjU 6ckTls4dFJjhNlO1zqoYbEx7jX9/ouJP0VCVc= MIME-Version: 1.0 In-Reply-To: <2375c9f91001191926hc80dc50mb264f757295c1337@mail.gmail.com> References: <2375c9f91001191926hc80dc50mb264f757295c1337@mail.gmail.com> Date: Wed, 20 Jan 2010 16:06:55 +0100 Message-ID: Subject: Re: [PATCH] Use full path to dnsdomainname and domainname in scripts/mkcompile_h From: Glenn Sommer To: =?UTF-8?Q?Am=C3=A9rico_Wang?= Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2010/1/20 Américo Wang : > On Wed, Jan 20, 2010 at 2:29 AM, Glenn Sommer wrote: >> With reference to: http://bugzilla.kernel.org/show_bug.cgi?id=14920 >> I'll post my suggestion here. >> >> Currently scripts/mkcompile_h checks for "/bin/dnsdomainname" and >> "/bin/domainname" when trying to find the DNS name. >> Though, when running the executable - the full path isn't used! >> >> IMO if we check for "/bin/dnsdomainname", we should also use >> "/bin/dnsdomainname" - and not blindly trust /bin is the first directory in >> $PATH  which contains a executable named "dnsdomainname" >> >> >> I propose to use the full path, that we know is valid. Here's my proposed patch: >> >> >> --- scripts/mkcompile_h.orig    2009-12-28 23:02:34.000000000 +0100 >> +++ scripts/mkcompile_h 2009-12-28 23:03:12.000000000 +0100 >> @@ -66,9 +66,9 @@ >>   echo \#define LINUX_COMPILE_HOST \"`hostname | $UTS_TRUNCATE`\" >> >>   if [ -x /bin/dnsdomainname ]; then >> -    echo \#define LINUX_COMPILE_DOMAIN \"`dnsdomainname | $UTS_TRUNCATE`\" >> +    echo \#define LINUX_COMPILE_DOMAIN \"`/bin/dnsdomainname | $UTS_TRUNCATE`\" >>   elif [ -x /bin/domainname ]; then >> -    echo \#define LINUX_COMPILE_DOMAIN \"`domainname | $UTS_TRUNCATE`\" >> +    echo \#define LINUX_COMPILE_DOMAIN \"`/bin/domainname | $UTS_TRUNCATE`\" >>   else >>     echo \#define LINUX_COMPILE_DOMAIN >>   fi >> >> >> Signed-off-by: Glenn Sommer > > Makes sense, but is that possible we have 'domainname' installed in two > different directories? > Usually "domainname" should be installed in /bin. I'm just thinking if one does something like this: * Place shellscript named "domainname" in /home/stupiduser/scripts (This shellscript should output some text... Let's say "my-stupid-shell-script") * Set PATH=/home/stupiduser/scripts:$PATH * Compile Linux kernel Doing the above will result in scripts/mkcompile_h testing for /bin/domainname, but actually using /home/stupiduser/scripts/domainname - which is this case will output something wrong. One could argue it's your own fault then - and I agree! Doing the above is stupid! Anyway, if we test for the executable using a complete path - we should also use that complete path when running the executable! Alternatively, if we want it to be more flexible(and allow the above) - we should do something like: domainname_executable=`which domainname` if [ ! -z "$domainname_executable" ] && [ -x "$domainname_executable" ]; then