From: Edward Cree <ecree.xilinx@gmail.com>
To: Jason Wang <wangborong@cdjrlc.com>, edumazet@google.com
Cc: habetsm.xilinx@gmail.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet/sfc: Fix comment typo
Date: Mon, 18 Jul 2022 15:19:44 +0100 [thread overview]
Message-ID: <d65c8772-ae46-f913-b3fe-f58d4f812b40@gmail.com> (raw)
In-Reply-To: <20220715045914.23629-1-wangborong@cdjrlc.com>
On 15/07/2022 05:59, Jason Wang wrote:
> The double `that' is duplicated in line 2438, remove one.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/net/ethernet/sfc/falcon/falcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/falcon/falcon.c b/drivers/net/ethernet/sfc/falcon/falcon.c
> index 3324a6219a09..9fcd28500939 100644
> --- a/drivers/net/ethernet/sfc/falcon/falcon.c
> +++ b/drivers/net/ethernet/sfc/falcon/falcon.c
> @@ -2435,7 +2435,7 @@ static void falcon_init_rx_cfg(struct ef4_nic *efx)
> * supports scattering for user-mode queues, but will
> * split DMA writes at intervals of RX_USR_BUF_SIZE
> * (32-byte units) even for kernel-mode queues. We
> - * set it to be so large that that never happens.
> + * set it to be so large that never happens.
> */
> EF4_SET_OWORD_FIELD(reg, FRF_AA_RX_DESC_PUSH_EN, 0);
> EF4_SET_OWORD_FIELD(reg, FRF_AA_RX_USR_BUF_SIZE,
>
Nack. The first 'that' is a subordinating conjunction, the second is
a demonstrative pronoun, so this is not a mere duplication.
(Admittedly, some writers would omit the conjunction, but I think the
sentence reads more clearly with it present.)
One possible alternative would be to change the second 'that' to
'this' or 'the above', or even 'such splitting', if you really find
the original confusing.
-ed
prev parent reply other threads:[~2022-07-18 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 4:59 Jason Wang
2022-07-18 14:19 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d65c8772-ae46-f913-b3fe-f58d4f812b40@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®