From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965727AbcJYLgL (ORCPT ); Tue, 25 Oct 2016 07:36:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:41619 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711AbcJYLgF (ORCPT ); Tue, 25 Oct 2016 07:36:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,545,1473145200"; d="scan'208";a="893709800" Subject: Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set. To: Zach Brown References: <1477085715-30213-1-git-send-email-zach.brown@ni.com> <1477085715-30213-3-git-send-email-zach.brown@ni.com> <20161024154820.GA16144@zach-desktop> Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Tue, 25 Oct 2016 14:30:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024154820.GA16144@zach-desktop> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/10/16 18:48, Zach Brown wrote: > On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote: >> On 22/10/16 00:35, Zach Brown wrote: >>> When the sdhci-cap-speed-modes-broken DT property is set, the driver >>> will ignore the bits of the capability registers that correspond to >>> speed modes. >>> >>> Signed-off-by: Zach Brown >>> --- >>> drivers/mmc/host/sdhci.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >>> index 1e25b01..59c62d3 100644 >>> --- a/drivers/mmc/host/sdhci.c >>> +++ b/drivers/mmc/host/sdhci.c >>> @@ -22,6 +22,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include >>> >>> @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1) >>> >>> host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES); >>> >>> + if (of_property_read_bool(mmc_dev(host->mmc)->of_node, >>> + "sdhci-cap-speed-modes-broken")) >> >> It rather begs the question: if you are going to do something sdhci >> specific, why not just read the whole of the caps register from DT? >> > > Throwing out the whole of the caps register seems like overkill. Also What about 2 values: one for the 64-bit caps register and one for a 64-bit mask of bits to override. That way you can select which bits to override and what to override them to. > there are some things set by the caps that are not available in the DT. > For example, SDHCI_CAN_64BIT is set by the cap register and is used in > sdhci_setup_host to set host->flags SDHCI_USE_64_BIT_DMA. Not sure what you mean.