From: Thierry Escande <thierry.escande@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Petr Mladek <pmladek@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"Tobin C . Harding" <me@tobin.cc>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] lib/test_printf.c: call wait_for_random_bytes() before plain %p tests
Date: Wed, 13 Jun 2018 16:59:27 +0200 [thread overview]
Message-ID: <d663916f-ebbf-3177-cd03-8d1175912f53@linaro.org> (raw)
In-Reply-To: <CAHp75VeXGT3KG9HXQstFJVyHFO8o64Dk0LSo43FzyR0SvPUONg@mail.gmail.com>
On 13/06/2018 13:22, Andy Shevchenko wrote:
> On Wed, Jun 13, 2018 at 12:29 PM, Thierry Escande
> <thierry.escande@linaro.org> wrote:
>> If the test_printf module is loaded before the crng is initialized, the
>> plain 'p' tests will fail because the printed address will not be hashed
>> and the buffer will contain "(ptrval)" instead.
>> Since we cannot wait for the crng to be initialized for an undefined
>> time, both plain 'p' tests now accept the string "(ptrval)" as a valid
>> result and print a warning message.
>
> There are two possibilities:
> 1. (ptrval) for 32-bit case
> 2. (____ptrval____) for 64-bit case.
From lib/vsprintf.c, ptr_to_id() puts "(ptrval)" into the buffer, then
it gets left-padded with spaces by widen_string().
Regards,
Thierry
next prev parent reply other threads:[~2018-06-13 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 9:29 Thierry Escande
2018-06-13 11:22 ` Andy Shevchenko
2018-06-13 14:59 ` Thierry Escande [this message]
2018-06-13 16:30 ` Andy Shevchenko
2018-06-13 16:42 ` Thierry Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d663916f-ebbf-3177-cd03-8d1175912f53@linaro.org \
--to=thierry.escande@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=me@tobin.cc \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®