From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhao Qunqin <zhaoqunqin@loongson.cn>, Xi Ruoyao <xry111@xry111.site>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
chenhuacai@kernel.org, linux-edac@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@xen0n.name, bp@alien8.de, tony.luck@intel.com,
james.morse@arm.com, mchehab@kernel.org, rric@kernel.org,
loongarch@lists.linux.dev
Subject: Re: [PATCH v2 2/2] Loongarch: EDAC driver for loongson memory controller
Date: Tue, 3 Sep 2024 13:36:56 +0200 [thread overview]
Message-ID: <d6674376-f404-4b65-899f-4c7cfcf9524b@kernel.org> (raw)
In-Reply-To: <f534cc40-56d5-2ac8-4db6-aaaa32b07e2f@loongson.cn>
On 03/09/2024 13:31, Zhao Qunqin wrote:
>
> 在 2024/9/3 下午7:29, Krzysztof Kozlowski 写道:
>> On 03/09/2024 10:30, Xi Ruoyao wrote:
>>> On Tue, 2024-09-03 at 09:58 +0200, Krzysztof Kozlowski wrote:
>>>>>>> + select EDAC_SUPPORT
>>>>>> I think you got here comment before. How did you address it?
>>>>> I just randomly found a spot, and I will put it at the end(next version
>>>>> patch).
>>>> No, the comment was different. You must not select user-visible symbols.
>>> EDAC_SUPPORT isn't user-visible. EDAC is and it has been removed.
>> Ah, ok, I missed that. Shouldn't this be separate patch with its own
>> rationale? Or before this driver there was no EDAC support for Loongson
>> at all?
>
> Before this driver there was no EDAC support for Loongson
> at all.
Ack, ok.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-03 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 1:53 [PATCH v2 0/2] Add EDAC driver for ls3a5000 " Zhao Qunqin
2024-09-03 1:53 ` [PATCH v2 1/2] dt-bindings: EDAC " Zhao Qunqin
2024-09-03 3:02 ` Huacai Chen
2024-09-03 6:44 ` Krzysztof Kozlowski
2024-09-03 1:53 ` [PATCH v2 2/2] Loongarch: EDAC driver for loongson " Zhao Qunqin
2024-09-03 2:39 ` Huacai Chen
2024-09-03 2:43 ` Huacai Chen
2024-09-03 3:31 ` Mingcong Bai
2024-09-03 6:33 ` Markus Elfring
2024-09-03 7:45 ` Zhao Qunqin
2024-09-03 6:47 ` Krzysztof Kozlowski
2024-09-03 7:24 ` Zhao Qunqin
2024-09-03 7:58 ` Krzysztof Kozlowski
2024-09-03 8:30 ` Xi Ruoyao
2024-09-03 11:29 ` Krzysztof Kozlowski
2024-09-03 11:31 ` Zhao Qunqin
2024-09-03 11:36 ` Krzysztof Kozlowski [this message]
2024-09-03 9:59 ` Zhao Qunqin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6674376-f404-4b65-899f-4c7cfcf9524b@kernel.org \
--to=krzk@kernel.org \
--cc=bp@alien8.de \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=xry111@xry111.site \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®