From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4706022C6E5 for ; Fri, 6 Dec 2024 23:01:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733526094; cv=none; b=L8w4BP2YOxxTAiP2rmz9nPqCrp5rNJwAKG8DGAS0Y8nJ2LgH/GIEymklstMsvScoIjP1yJoG4XVlf8meoxRfpXk0aNVT8i6ojFsglsx16R6VAAi0HaDEGmqY0094xHgFWnKsrBPQSofV31xOguSwH8zOG/cRqzyqhIFdMYphZ3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733526094; c=relaxed/simple; bh=+SQZnlq1J+JZmFNEU9xxEeBa/cmGw9SC2K0z3KN0MPw=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To; b=AhqCMCLWnbCxBpxdb/XThu91zZ9ZS4LJtlNEXuFXwQ5JlevKtuexhLSWSdgO3DjjVPzuvyWu4Y1ms9klgpX95fQmyDSyXGoFLQ0lailbFAJBSp1dTII4s+bcOaUeOGLustcd9Vqq4qytpqHlxayDdIFO3mdKNLzKqMWxnkzl/Sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DK61RMJk; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DK61RMJk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733526093; x=1765062093; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=+SQZnlq1J+JZmFNEU9xxEeBa/cmGw9SC2K0z3KN0MPw=; b=DK61RMJkzke7qGD6wdWyYYi/AxISO2k9log9p43I2FfNP2iC/RG3T7DM vxmyGLFCCHZKvF1ALbqkeWA+aV9ijuzkB52kPXTAeRY8Ma8R66ZG1uuMa enqUf4SBkS7u4e9bQCGwrNn7hBmSQ8hKfp0lfLYW9NRj1WwrAswBhWB4Z L2lghsYv/GsN1U7rWvDNTva9SWWRaqqbIm/W7f1IBa5U5BfeARTabs8Gr GXOZxcyow9X3EbxLeAZt1YJB+BfIiEUVxtinfQPVHefQdtHdWYXdX2tH5 Fovxe1khBi0MXYemrmiY1Wb0SNxzLC8HDB2J2uHJElM4NwE7p/9URVxSK w==; X-CSE-ConnectionGUID: 5SldBxYOSk6BZzFzViap2w== X-CSE-MsgGUID: 3WNaM792S7OWxU220UrO9w== X-IronPort-AV: E=McAfee;i="6700,10204,11278"; a="45291042" X-IronPort-AV: E=Sophos;i="6.12,214,1728975600"; d="scan'208";a="45291042" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2024 15:01:32 -0800 X-CSE-ConnectionGUID: 2sRxy3GgSzWrwQ/PiRo4JQ== X-CSE-MsgGUID: VjEy616nRkW72DKXcoh18Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,214,1728975600"; d="scan'208";a="95016668" Received: from mdroper-mobl2.amr.corp.intel.com (HELO [10.124.220.211]) ([10.124.220.211]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2024 15:01:31 -0800 Content-Type: multipart/mixed; boundary="------------62gcGkjeByxEbYMXEfZjeSte" Message-ID: Date: Fri, 6 Dec 2024 15:01:30 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] x86/cpu: Make all all CPUID leaf names consistent To: Borislav Petkov Cc: Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, rafael@kernel.org, lenb@kernel.org References: <20241030213310.C4861EC0@davehans-spike.ostc.intel.com> <20241030213329.3253F5F3@davehans-spike.ostc.intel.com> <20241031101834.GGZyNZejzr5A9bNL8J@fat_crate.local> <4d606240-a8c8-40e5-80da-57c9b4d48179@intel.com> <20241129182747.GEZ0oHo1eR0l7sREJY@fat_crate.local> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20241129182747.GEZ0oHo1eR0l7sREJY@fat_crate.local> This is a multi-part message in MIME format. --------------62gcGkjeByxEbYMXEfZjeSte Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/29/24 10:27, Borislav Petkov wrote: > Well, enum cpuid_leafs as it is now is the *indices* into the cap flags array: > > struct cpuinfo_x86 { > > ... > > __u32 x86_capability[NCAPINTS + NBUGINTS]; > > And having a "CPUID_" prefixed thing and a "CPUID_LEAF_" prefixed other thing > is going to cause confusion. > > And renaming enum cpuid_leafs is going to cause a massive churn... Wait a sec though: $ git grep 'enum cpuid_leafs' arch/x86/ arch/x86/include/asm/cpufeature.h:enum cpuid_leafs arch/x86/kvm/cpuid.c:static __always_inline void kvm_cpu_cap_mask(enum cpuid_leafs leaf, u32 mask) So there is only one direct reference to the type. I think all it will take to rename the _type_ is something like the attached. Also, I think the new name 'x86_capability_words' and variable 'cap_nr' make the KVM site a lot more readable. Thoughts? --------------62gcGkjeByxEbYMXEfZjeSte Content-Type: text/x-patch; charset=UTF-8; name="rename-cpuid_leafs.patch" Content-Disposition: attachment; filename="rename-cpuid_leafs.patch" Content-Transfer-Encoding: base64 CgotLS0KCiBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmUuaCB8ICAgIDIgKy0K IGIvYXJjaC94ODYva3ZtL2NwdWlkLmMgICAgICAgICAgICAgIHwgICAgOCArKysrLS0tLQog MiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZm IC1wdU4gYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZS5ofnJlbmFtZS1jcHVpZF9s ZWFmcyBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVmZWF0dXJlLmgKLS0tIGEvYXJjaC94ODYv aW5jbHVkZS9hc20vY3B1ZmVhdHVyZS5ofnJlbmFtZS1jcHVpZF9sZWFmcwkyMDI0LTEyLTA2 IDE0OjU3OjUyLjM1MDc5MzY3NSAtMDgwMAorKysgYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9j cHVmZWF0dXJlLmgJMjAyNC0xMi0wNiAxNDo1ODo0My40NjQ3MTk4NDIgLTA4MDAKQEAgLTEw LDcgKzEwLDcgQEAKICNpbmNsdWRlIDxsaW51eC9iaXRvcHMuaD4KICNpbmNsdWRlIDxhc20v YWx0ZXJuYXRpdmUuaD4KIAotZW51bSBjcHVpZF9sZWFmcworZW51bSB4ODZfY2FwYWJpbGl0 eV93b3JkcwogewogCUNQVUlEXzFfRURYCQk9IDAsCiAJQ1BVSURfODAwMF8wMDAxX0VEWCwK ZGlmZiAtcHVOIGFyY2gveDg2L2t2bS9jcHVpZC5jfnJlbmFtZS1jcHVpZF9sZWFmcyBhcmNo L3g4Ni9rdm0vY3B1aWQuYwotLS0gYS9hcmNoL3g4Ni9rdm0vY3B1aWQuY35yZW5hbWUtY3B1 aWRfbGVhZnMJMjAyNC0xMi0wNiAxNDo1ODo0NS4wODQ3ODA5MjQgLTA4MDAKKysrIGIvYXJj aC94ODYva3ZtL2NwdWlkLmMJMjAyNC0xMi0wNiAxNDo1OToyNC44MTgyNzk0MzIgLTA4MDAK QEAgLTU5NCwxNCArNTk0LDE0IEBAIHZvaWQga3ZtX2NwdV9jYXBfaW5pdF9rdm1fZGVmaW5l ZChlbnVtIGsKIAlfX2t2bV9jcHVfY2FwX21hc2sobGVhZik7CiB9CiAKLXN0YXRpYyBfX2Fs d2F5c19pbmxpbmUgdm9pZCBrdm1fY3B1X2NhcF9tYXNrKGVudW0gY3B1aWRfbGVhZnMgbGVh ZiwgdTMyIG1hc2spCitzdGF0aWMgX19hbHdheXNfaW5saW5lIHZvaWQga3ZtX2NwdV9jYXBf bWFzayhlbnVtIHg4Nl9jYXBhYmlsaXR5X3dvcmRzIGNhcF9uciwgdTMyIG1hc2spCiB7CiAJ LyogVXNlIGt2bV9jcHVfY2FwX2luaXRfa3ZtX2RlZmluZWQgZm9yIEtWTS1vbmx5IGxlYWZz LiAqLwotCUJVSUxEX0JVR19PTihsZWFmID49IE5DQVBJTlRTKTsKKwlCVUlMRF9CVUdfT04o Y2FwX25yID49IE5DQVBJTlRTKTsKIAotCWt2bV9jcHVfY2Fwc1tsZWFmXSAmPSBtYXNrOwor CWt2bV9jcHVfY2Fwc1tjYXBfbnJdICY9IG1hc2s7CiAKLQlfX2t2bV9jcHVfY2FwX21hc2so bGVhZik7CisJX19rdm1fY3B1X2NhcF9tYXNrKGNhcF9ucik7CiB9CiAKIHZvaWQga3ZtX3Nl dF9jcHVfY2Fwcyh2b2lkKQpfCg== --------------62gcGkjeByxEbYMXEfZjeSte--