From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935909AbcIHIFb (ORCPT ); Thu, 8 Sep 2016 04:05:31 -0400 Received: from mga05.intel.com ([192.55.52.43]:4201 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932342AbcIHIFG (ORCPT ); Thu, 8 Sep 2016 04:05:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,298,1470726000"; d="scan'208";a="1026753192" Subject: Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support To: Adrian Hunter , Pramod Gurav , ulf.hansson@linaro.org References: <1466080509-24015-1-git-send-email-pramod.gurav@linaro.org> <79066adb-c45b-158f-99af-6d86e6de7513@intel.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Georgi Djakov , Stephen Boyd From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 8 Sep 2016 11:00:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <79066adb-c45b-158f-99af-6d86e6de7513@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/16 10:47, Adrian Hunter wrote: > On 16/06/16 15:35, Pramod Gurav wrote: >> Provides runtime PM callbacks to enable and disable clock resources >> when idle. Also support system PM callbacks to be called during system >> suspend and resume. >> >> Signed-off-by: Pramod Gurav > > Can we get some Tested/Reviewed/Acked-by from people using this driver? Oops wrong version of the patch. Please disregard the comment for this patch, and see instead the later patch. > >> --- >> drivers/mmc/host/sdhci-msm.c | 57 ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index 0653fe7..f4394c8 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -18,6 +18,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> #include "sdhci-pltfm.h" >> @@ -549,6 +550,11 @@ static int sdhci_msm_probe(struct platform_device *pdev) >> if (ret) >> goto clk_disable; >> >> + platform_set_drvdata(pdev, msm_host); >> + >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pdev->dev); >> + >> return 0; >> >> clk_disable: >> @@ -580,12 +586,63 @@ static int sdhci_msm_remove(struct platform_device *pdev) >> return 0; >> } >> >> +static int sdhci_msm_runtime_suspend(struct device *dev) >> +{ >> + struct sdhci_msm_host *msm_host = dev_get_drvdata(dev); >> + >> + clk_disable_unprepare(msm_host->clk); >> + clk_disable_unprepare(msm_host->pclk); >> + >> + return 0; >> +} >> + >> +static int sdhci_msm_runtime_resume(struct device *dev) >> +{ >> + struct sdhci_msm_host *msm_host = dev_get_drvdata(dev); >> + int ret; >> + >> + ret = clk_prepare_enable(msm_host->clk); >> + if (ret) { >> + dev_err(dev, "clk_enable failed: %d\n", ret); >> + return ret; >> + } >> + ret = clk_prepare_enable(msm_host->pclk); >> + if (ret) { >> + dev_err(dev, "clk_enable failed: %d\n", ret); >> + clk_disable_unprepare(msm_host->clk); >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> +static int sdhci_msm_suspend(struct device *dev) >> +{ >> + pm_runtime_force_suspend(dev); >> + >> + return 0; >> +} >> + >> +static int sdhci_msm_resume(struct device *dev) >> +{ >> + pm_runtime_force_resume(dev); >> + >> + return 0; >> +} >> + >> +static const struct dev_pm_ops sdhci_msm_pm_ops = { >> + SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume) >> + SET_RUNTIME_PM_OPS(sdhci_msm_runtime_suspend, sdhci_msm_runtime_resume, >> + NULL) >> +}; >> + >> static struct platform_driver sdhci_msm_driver = { >> .probe = sdhci_msm_probe, >> .remove = sdhci_msm_remove, >> .driver = { >> .name = "sdhci_msm", >> .of_match_table = sdhci_msm_dt_match, >> + .pm = &sdhci_msm_pm_ops, >> }, >> }; >> >> > >