From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B91C43B3890 for ; Tue, 24 Mar 2026 10:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348809; cv=none; b=PV+NsNn3JI4Ii112Iz6gYXNWTXOg/yUxlBqM3jKfTR3jjAsUAySlUMyCGFylLZGD9lN3CaUNZAOnxkMWhMgCeMPvulkSOZDqZj1rHxuC0kzrvNMDny8K9Ser9+at0Lrwf2/OTYy/KNik+1XjcHE3ODR7oXmNBYvQNyJTKZhIAxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348809; c=relaxed/simple; bh=V/t8VE4RIxnv3KlXn6VFkpWMfjuQh3mARrMePng2vJQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SyhIdRk6chdsGoxZniSPxy+FZHVdptLqfPfxWIOY5Yq6gAGBhymL20pXql4b1799GitadNhNnW9sSTxkeAj+aSTkLww8mYsOCG1CbWl/TqqwtyZozKAMqg5AMnS4y+UrVxwjs7MCuZNV/BnVzIt/ND42+3l3NuGZuf2ePueSWm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KXlmTcJi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NBxLC+Ki; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KXlmTcJi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NBxLC+Ki" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9hOdD3634286 for ; Tue, 24 Mar 2026 10:40:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xiLrR32Mkhp9iJsUryaa7C2F1tBnG5NgCMdH592hc+Q=; b=KXlmTcJiWso+drhi 8Po7MCVRt+eNjoXF9ZRYUBmnzme4Q3Qx/Qmkiabldy/4qPJASm0QEHqlOVZw2Ztp zTZuesinNAI3sVHrc0U89UtsDuXwttKnxBGSroZiSRErZdhpU/4pRPgXs3+ElC0l shYwHNj9QYqzpVK6DTp/ji1dNzG88oLH2s9Kl7LAS2KAo1yK1O1eQkyDDj9iyzbB YCEqRXDxkwoarJ0ksavzkqBrVv+x+rPQqB1Nf0cKp/2b+YdzvFIJ9zKIqs6Jck+v pEnrNDf87ri/0qppL4ZbIwDnYkbUBeXw+bwiYmF1225s3Pcv1r8eFVh9MJEmzkEo 9v12Sw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d34k4mmex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:40:05 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a90510a6d1so50970545ad.0 for ; Tue, 24 Mar 2026 03:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774348805; x=1774953605; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xiLrR32Mkhp9iJsUryaa7C2F1tBnG5NgCMdH592hc+Q=; b=NBxLC+KiBgWvo62gpl3FAM50F0JegNDxerA9j9OOZ1uTV2M+Ww2sY0TGOR20y8UTEB ZsaTzi6azmA0PA7uXQQD9HeNXFApaRaI8b8RHk1O+HdFhxpFsLQRJpwktAAVcuQIrCBo dw+iC4xhv/w4vDs0CAN894C97/MVBHcpmMotS4RK+7W34aAmpO2ZxIxbHv3jYRH1soT+ 2Cp/+lZyg/VZX3ZuvdSJKn+WjCYFuZ69DT7buo9PA2ssSYEtVAE1zyr0czT/tDh/OZFa 8h8OC7No2sJ/D1oUZv+q4LEd9kiTOnnULDjrkAU/+ziber4Uj+QCxNunPKelAstoU6TA A8yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774348805; x=1774953605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xiLrR32Mkhp9iJsUryaa7C2F1tBnG5NgCMdH592hc+Q=; b=lZZsV5HOwMxi1boAOowUyUtBZiXxeQXNUxo9YqCUH/0nd8igYqKzEJ2PPR7A+JexNr 9i3jWdSS1TJHeqP7yjZaul6dxVMhJTmKEq1S2i/PnlZNVYbfSvnrdnyTiyveG2lz4M6c C0KjnbaW0kSGFwa+LdWlS+KemBQDNpwSiV9kpYWop71DQ1VHnuuzmIwaYbk1faLqYwug UmcaBwBe5ZAN7haUoqGKyyMHuaRBbsqDuyEbPi3p1ZZdTAJrJGDTOoUGSGD4X8PIjr3A TiY12GTTLi60WxuLKD9VYzigwQzpDe6sok+9MEBEg8Hgp9JkUrv9okRlVUELQCeyFj4Z mpMQ== X-Forwarded-Encrypted: i=1; AJvYcCVOwpXh7HAS27poWMCu41gzMX2L/NZzyisIbGH+R+EGi5Uhl/NCzATUD9AnPC0n7X5VDqPmd9rBu3k9DAc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1i0EBeor7Vj+o/nxg02vRprdPX3XH3DCFYMAxbZtG5su/0qBZ 27dO0plq3OFGf8dhAatcaHqMInc4XZH9eFYSK+qymoE3eTGt4ZhMns5IwJyhRNO9360rJsIPpZb SiBkj/DcUwzlSjO8U5+ZPWHRe6z8Fgd+FicspNDRbLUQJgtKH1zIraeZRybtd5q1BQqc= X-Gm-Gg: ATEYQzzUp9jaikfWopq0y4o45SkdPwnBIr5AFyOqOuVcEz3vfgI4fPAHkW7qxZFfBC/ MOMpaJjglgKs2thJzXfhvJ3/RhDnKBkqszr4bSAvGk47zOsFQmmxkbQsiOb+jE73f0STTPFdozc Pdw3wLIdDyvgKAmV+usOqwOhJg33zINsPMXZOrStGfDP5F6pxX35oYiy2aAuJrDsH4YDfpCe/zB 6Oe5OO+7u/iY1nJRahkTng5KQrsYl5gvmRtwFdfML7gJONEC7p2V7/XMFruQ0sm/9Q/cH0FZsLj Kg2mMvBIWCzBs0vO+ISWoBilGORgU+dVs7t9+x7K+OjNppDqTgkqD/T6J9sP8xJih4zbmAXhcus BPwDZqLY/i1isPcmkpO6QAHTu0apFtPmnD+5v2v5Fi0u5T1XebtDB X-Received: by 2002:a17:902:d209:b0:2b0:ac1e:9730 with SMTP id d9443c01a7336-2b0ac1e9a37mr4064485ad.14.1774348804439; Tue, 24 Mar 2026 03:40:04 -0700 (PDT) X-Received: by 2002:a17:902:d209:b0:2b0:ac1e:9730 with SMTP id d9443c01a7336-2b0ac1e9a37mr4064185ad.14.1774348803929; Tue, 24 Mar 2026 03:40:03 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c766255606fsm1101544a12.21.2026.03.24.03.39.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:40:03 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 16:09:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/11] arm64: dts: qcom: sm8650: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-10-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-10-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: x3ebN4ygW_SR-Qh_XXZpekF96kfJwBeZ X-Proofpoint-ORIG-GUID: x3ebN4ygW_SR-Qh_XXZpekF96kfJwBeZ X-Authority-Analysis: v=2.4 cv=c+imgB9l c=1 sm=1 tr=0 ts=69c26a05 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4NCBTYWx0ZWRfX8yoeyCAx7IUw JvHauZWPeZ4OmqFko14GRyGJW+5RjPimWFPmsvrALuzqMix16/VoBmuvP6WR/VMMbcopGVmfMij R3h1tokjl+Tp4U+o+MO9pt2YSSn6Ta9FN2b+WM+2GyFTnhisoNZMtlkIy2zMSJRc8SRu+m+VaSB p2qhKwnqnjqXS0DctDWtVKihfiWnG7YzSyGybtf5lO6LWLFF+5JU4NnZ0W/6y9ee+8A+SJinb9i T30+KT88jw0UDPeph+bURD2LUQhZpGO/zS/HgisQBFIg2JqvV9K7YzcTW0bJrXXiu331K8OYs6O u99tqNJ+SNhNgEuwnGo2L4TMUkxQVFhDaM3Oy0RZvuQ9GXznp1htt2stdwrp09p9arAQ54FF+BI /QTzZmODgkSJ5mbxOFUpr+MSXE0ETiuISyOEM8nkLpMo90Bpg/1wKouVYrhM0HbBz9fGKze2Rgi p45OYeg1TmgZPxP7PVA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240084 On 3/23/2026 2:48 PM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8650. > > Fixes: 10e0246712951 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") > Reviewed-by: Konrad Dybcio > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep