From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 029311E8348; Tue, 8 Apr 2025 18:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744138214; cv=none; b=Mhziq+/qAWea3Ui2fMDMVP7L4PxoQaPqoMw+LjMxs9huuf8xlWNS/3vCpQsZ/0I473ZvtPuPi1o88e/cyluejRaUWPCwWpDrg5xNOq8EaVfTZNtq23E72d3x79Phqqg2ILmWucEK0cD6Ccuqn/dxaj/wneDefjP0OkCK1lV82K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744138214; c=relaxed/simple; bh=TkyUTyQaH+ruJO4XEeuuO0vbJiIkePtnvRipx0hrx+E=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=SDc7ZuQ/sg817XFTOzaaVlNbVLC/x8hg8zQRcgZolq4DzR8/usUEcAU0ViMvdE4TNou6FUHgZtsWQj7WIpJjQKARimm4CRl0+BnKu9ZawuNonnynXPhF3+WRvMNcMenLwBihLaiHKOAEaK3dJm99DJl2F4dhhvREZgY7ZjMdces= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=ANmBVDSi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="ANmBVDSi" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 538Aj2Ge029517; Tue, 8 Apr 2025 18:50:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0xKW77pHsNVjmQD9NKN5YZmVw8/W/eiz6MnSObafraw=; b=ANmBVDSimGvkdLrH I3iScDex7Bfkz7hdPBkZNh64xZWnzzEG5f4AgkdNryt9Hk+5Ni5lQYKNIQcHUKSL zjQJAJ5KnpjvyF5UetxUhGMf5lIjWjpIGVUsWxTnYCt1NpeRj2gRJkw2/EyvPbRc 1CsqeMA3ZYqPU6rXyZOW0pYVitEWr8EwMQiM7Nlk3h3QauGK+gb/cG4qkDYDzaXN aLIdUIPHW60dvtSf/Q21ySMadvYcAJH+3PKnxqWlKlaRWkNmGILD8ltMNYAI3H0/ F05ZujNn0+MiRXsK8ZzMp/oEFKFSheDXX8P4iVH8q5EI0MVge6MYBOaq+YghDXFa IxFkAA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twcrgxej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Apr 2025 18:50:03 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 538Io2nQ017307 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Apr 2025 18:50:02 GMT Received: from [10.134.71.247] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 8 Apr 2025 11:50:01 -0700 Message-ID: Date: Tue, 8 Apr 2025 11:50:01 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/15] drm/msm/dpu: check every pipe per capability To: Jun Nie , Rob Clark , "Dmitry Baryshkov" , Sean Paul , "Marijn Suijten" , David Airlie , Simona Vetter , Jessica Zhang CC: , , , References: <20250303-sm8650-v6-14-hmd-deckard-mdss-quad-upstream-oldbootwrapper-36-prep-v8-0-eb5df105c807@linaro.org> <20250303-sm8650-v6-14-hmd-deckard-mdss-quad-upstream-oldbootwrapper-36-prep-v8-1-eb5df105c807@linaro.org> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <20250303-sm8650-v6-14-hmd-deckard-mdss-quad-upstream-oldbootwrapper-36-prep-v8-1-eb5df105c807@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: U3FIKMp27eUnG1BF_0q02kLU0_27n1bF X-Authority-Analysis: v=2.4 cv=QuVe3Uyd c=1 sm=1 tr=0 ts=67f56fdb cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=KKAkSRfTAAAA:8 a=COk6AnOGAAAA:8 a=ceskOXBvEOXfFmsVgpkA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: U3FIKMp27eUnG1BF_0q02kLU0_27n1bF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-08_08,2025-04-08_04,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=970 bulkscore=0 priorityscore=1501 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504080129 On 3/3/2025 7:14 AM, Jun Nie wrote: > The capability stored in sblk and pipe_hw_caps is checked only for > SSPP of the first pipe in the pair with current implementation. That > of the 2nd pipe, r_pipe, is not checked and may violate hardware > capability. Move requirement check to dpu_plane_atomic_check_pipe() > for the check of every pipe. > > Fixes: ("dbbf57dfd04e6 drm/msm/dpu: split dpu_plane_atomic_check()") > Signed-off-by: Jun Nie > Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 71 ++++++++++++++++--------------- > 1 file changed, 36 insertions(+), 35 deletions(-) > Reviewed-by: Abhinav Kumar