From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 438E3400974 for ; Thu, 20 Aug 2026 09:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787219006; cv=none; b=iBQ2xwFyogmMCcQSeMhQ/3WMG9iHhv7fowSFwK2LcitvWTg7u9jE8oHvF647YliY632mao/AJyI0ThENax0ygEcqR9khijRfWU5wlcCpXWWEDG27wBhuyTH0h05RcDCXPEQBrlbhoAGZnJrMXwufjM2r69tzpZD24FTwD+PlHyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787219006; c=relaxed/simple; bh=2Se/R1PDY8b8PnlIAoeqQwyOTNnaR8VcPQQ+lAxAWxI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zqi6UwZIRE9s2ODMgOnKmRzHgaqVXIXjoN43F7Gbu5uYlaDibuNOHBAZcqgfJr9kmVtfhIBPoihCjqsVN/gv6kTAPkJ5vaq4EmNO6rrrz1Uvg5Yu0eAk2x6k+uy/BXKMKiAxlYlxKDOtOaEgY7/2LDZ4kYlpBlX0ucxU5ysGRGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AVhoz4zt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=U5hH7Hnf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AVhoz4zt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="U5hH7Hnf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787218995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8u2zk+UMLCr8IYSxUT7KHSPV+PCcsMNjHBcMIg9fE3Q=; b=AVhoz4zt3L+Q0IOLqMpTqdr6PfBPfMsQCwI5H73Gs4xP5FRcdbmR6/uJHjCnm9ujAZUHgo r6HqKCT83bQXeq3iTYIMeIADAM4ZADGHmmHssuEQsqxFCZPM9mrRt1NKDwoRJcIP9gj4qq Ni9AjpPUR2LjPQA+ffEodp200RAvPiE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-jsRVegHYPgWQS9qJsB47zQ-1; Thu, 20 Aug 2026 05:43:14 -0400 X-MC-Unique: jsRVegHYPgWQS9qJsB47zQ-1 X-Mimecast-MFC-AGG-ID: jsRVegHYPgWQS9qJsB47zQ_1787218993 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4954b1c6310so19159565e9.0 for ; Thu, 20 Aug 2026 02:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787218993; x=1787823793; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8u2zk+UMLCr8IYSxUT7KHSPV+PCcsMNjHBcMIg9fE3Q=; b=U5hH7Hnfj1hY15z409ptf2jnR8OiSUC8zwUCFRtJFIxWfOyJTvaBFdhPBXWh8X1VaZ jXsR+O7dmO3vAkb9KlzCisthSxIQawG/PBUpoFGyEs83v8MAcfLcETkO6L+RDFeQNAJB cK8VzL+ZGRFZ5UabyaG7kiz+UYrfi54hke+XiNGmtTC4hC+h6DmZkw37GdAb4PcyLgjF rSUmSnGfrcRDnd0NrS6hrECSYmX27e3+v6PNPVLXpZTVuAiWRKi9QqNTjHJOfMrtUfs0 WDzLdvZOS1dJBvdcN0t63u+5wgWqdqIkPa+MMMYbDip4a3YZSr35N9uAY45ZxSLPIRkq 2cqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787218993; x=1787823793; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8u2zk+UMLCr8IYSxUT7KHSPV+PCcsMNjHBcMIg9fE3Q=; b=aWsy/57Iu9CwdSwYz76Gjw95+6MZzo35brIBysZdZ8e802Ktqf3s6nqt0OAEjnj9AP ICLae2539FRDUkJnWfuATaeDMLXAVMlS6bZozRmtsZ/vWj5R7jHwgJGgXSx4k5fvda41 /hLLiOsRzzIIxMVuj+5EqRSYf6qz9NI9smWA9rrMgECD1aKgy50cqxmAWKimV7CLjRog eAe0C+4XNzzFXW39EKjpmopEguWT7e2/VSDRzq4J4foruHDiphAe+aMaF1VHy7NH+8lV fPlrV5wTj8c+fXaDvZ5sRQTUtukeTOXqHueC6ABJiw1xTnrW752kYuG9jLDaM6f1hKhT OOCQ== X-Forwarded-Encrypted: i=1; AHgh+RrO/ltKBzBWYHUhufgwQZVUM8gwBS6SRDeb91dmLuwR1ZPxCsZMk0DRp9I5SnRDYP/FdEpq3QzY6Er9CdY=@vger.kernel.org X-Gm-Message-State: AOJu0YytgOFNU/h0+8NK1ZUoUFCiNqGO4QONVuRk1Qq6M8frKqmt72AY Y3xBXNV2ee2cm8oKKR4/vHNTRPEEusIlOV4AlzD6nC0sRuu+jCPOGO4tHbIGaU7+qQ5Xc5giTpD oKsOdQlrWv8ZMPxJJcYJCf9BzKjprZgG8ZOkgi6UDpjdUy8t7rqXNUGgXexyHTLx4Zg== X-Gm-Gg: AR+sD10wp4+BSkgPWdIRzJa53k7FE8Kbr/wRFXQZXXlzQd1m3egZw2n71SSpq2c6wXK xG0UoQXxVOIhHzoVePcvD91OLRz0KZNTBoDJfmujSl9NfU93sOm0wZ4EA2nQGq/+b0NFLkQzVKV lPTjrylGxhlAK/WbHcb4YTj9UGDCizdrQRUfpon4qhdOiiUBvJWSKOqv1oIeFk16f1CZRcWgk9n PrLdksIHVIxs9BqqLD5Xx7T+ULF+h3Yj3p+YmTygU8M8dv+e3Dz0RhvuUXDI1BQ1+8PWZcPI5n8 ucp+QPzpOM/Xuwu/yJ95NAtMcXqqjqZ0CvPKjnH23HvqqnD1343gcea/ATUN+RytmBr0qUxarnn dsjY1aAX68dqXbOsOb+CHjJAkSS+/wtnI8DDR8sM2W9RYJzw8rO9LVyjebRHGCO1YBConwSUBN2 M= X-Received: by 2002:a05:600c:3150:b0:499:900c:9c68 with SMTP id 5b1f17b1804b1-499aa1a471bmr185690995e9.6.1787218992095; Thu, 20 Aug 2026 02:43:12 -0700 (PDT) X-Received: by 2002:a05:600c:3150:b0:499:900c:9c68 with SMTP id 5b1f17b1804b1-499aa1a471bmr185688495e9.6.1787218990527; Thu, 20 Aug 2026 02:43:10 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b2af1973sm15366435e9.3.2026.08.20.02.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 02:43:09 -0700 (PDT) Message-ID: Date: Thu, 20 Aug 2026 11:42:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly To: "Pandey, Radhey Shyam" , phucduc.bui@gmail.com, Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260817105241.63345-1-phucduc.bui@gmail.com> <20260817105241.63345-2-phucduc.bui@gmail.com> <38099370-269b-4d3e-a686-5b29d806e6a3@amd.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <38099370-269b-4d3e-a686-5b29d806e6a3@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/18/26 8:39 AM, Pandey, Radhey Shyam wrote: > On 8/17/2026 4:22 PM, phucduc.bui@gmail.com wrote: >> From: bui duc phuc >> >> lp->eth_irq is assigned from platform_get_irq_optional(), which returns >> a non-zero interrupt number on success or a negative error number on >> failure. Errors other than -ENXIO are handled before this check, >> so -ENXIO is the only error value that can reach this point. >> >> Check for a negative value instead of treating 0 as an undefined IRQ. >> >> Signed-off-by: bui duc phuc > > Reviewed-by: Radhey Shyam Pandey > Thanks! IMHO even this one is 'net' material deserving a fixes tag. @bui: please re-submit the whole series targeting the proper tree and including the needed tags. Be sure to read and understand the relevant documentation including: Documentation/process/maintainer-netdev.rst before submitting the next revision. /P