From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D508BC433ED for ; Tue, 11 May 2021 17:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A4BE61378 for ; Tue, 11 May 2021 17:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231789AbhEKRpu (ORCPT ); Tue, 11 May 2021 13:45:50 -0400 Received: from terminus.zytor.com ([198.137.202.136]:43719 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231454AbhEKRpt (ORCPT ); Tue, 11 May 2021 13:45:49 -0400 Received: from tazenda.hos.anvin.org ([IPv6:2601:646:8602:8be0:7285:c2ff:fefb:fd4]) (authenticated bits=0) by mail.zytor.com (8.16.1/8.15.2) with ESMTPSA id 14BHiROf2638597 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Tue, 11 May 2021 10:44:27 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 14BHiROf2638597 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2021042801; t=1620755068; bh=I4Nrpc4juIjYCBgtvXLG7yW+fRLX4yY6QBjep1Kuktg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QEGipmfIgGW2WKZWBN/rKm1HxRv59ELISh87mPr5dY/r7cl6GWCeJBtQGsJQAmqwf 8rjqVVEPHimsnjoVKTNR7jCcmOoDSqWAS9PrQwfd73vRV8Yxl/KJa9itlbZl6nWALt kLEvyWNgNIl9nYdzssGkA78bN6M91VEC7BxxyvcFUN0dCCCep3F8K088LFukRe5/nH Ppmn4yMFTIoRWXPRW/ieFWw9//WDi23hL42Smqv6SwMyh7izSZEBYKeFyVvJFzw9W7 cbp1cCsSuRSgPmDmp530of+QrTvLOQ3SJBzpaemq1O6wDvCVOrqRF16XUCdqqKMqJy ZNTtqOIsiKDTw== Subject: Re: [PATCH 4/6] x86/irq: merge common code in DEFINE_IDTENTRY_SYSVEC[_SIMPLE] To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski Cc: Steve Wahl , Mike Travis , Dimitri Sivanich , Russ Anderson , Linux Kernel Mailing List References: <20210511005531.1065536-1-hpa@zytor.com> <20210511005531.1065536-5-hpa@zytor.com> <87lf8lfizj.ffs@nanos.tec.linutronix.de> From: "H. Peter Anvin" Message-ID: Date: Tue, 11 May 2021 10:44:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87lf8lfizj.ffs@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/21 7:22 AM, Thomas Gleixner wrote: > > That's not really making the code more readable. Something like the > below perhaps? > > #define IDTENTRY_INVOKE_SYSVEC(func, regs, raw) \ > do { \ > irqentry_state_t state = irqentry_enter(regs); \ > \ > instrumentation_begin(); \ > kvm_set_cpu_l1tf_flush_l1d(); \ > if (raw) { \ > __irq_enter_raw(); \ > func(regs); \ > __irq_exit_raw(); \ > } else { \ > run_sysvec_on_irqstack_cond(func, regs); \ > } \ > instrumentation_end(); \ > irqentry_exit(regs, state); \ > } while (0) \ > Digging more into it, it looks like a *lot* of the macros in and can be replaced with inlines without any change in functionality or generated code. -hpa