From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7471E2206AC for ; Mon, 22 Dec 2025 10:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398020; cv=none; b=JrwK1T6hczBxcnA26CIJ2HHOch0xFRrfptGQlooObmpwU1QkbG1nKU9rLW1yoXyNAm3yXLtVxd2nETXlhV9aillKnON9BTh6iFSEFm133BiusmacBI/SKzBSYW8QlnQS/mO1Wm0ujNkHogz7Cr3b/4Fu8xmp410knXyKwdMraN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766398020; c=relaxed/simple; bh=EzElnwwlQS7F2c/aWf2Rrdw+O1vMlFn4Ie35PoFgcPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u3IQ2H2JiSoK0u734hRd5RTwGQRGYnxT2J51BCYsVYuWwm6Axej0Fet2aJokBZeh1Jn3CN/vg19KjJeiweuwGGan/4Vri31JkCBqWlZnnlq/nda6p+WFXv9TPS0efyKvVeyh6uO1NyVXPyGsGdqCf39B9trLIc+PupqaMRh8S68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nDAeELZt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B69l7zwk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nDAeELZt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B69l7zwk" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BM8PH5x3808462 for ; Mon, 22 Dec 2025 10:06:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eLH0Cwx0fLQzNEAsVMMYq1in/gcvYRl8pE9l3eEnT3k=; b=nDAeELZt/Xho53gA oIpCz+T9h+MsDfXtR2O7C2UwnwBKegBOQRhvJ4aFlI3eAt4Q1cp5WjhVkAa4V1DB QFRETDtzI+hT2RHRMgQdzHvv4G+lV4qP3isBmC66w6xHjiKIZW+DA5YzdibERNdr 18DPzHxLnZPWGHqw/KW7Sm8y12sY7Qqu+WZEbjJIwmz/hRPAgTV1zRky9dYHNjVn fs8ZW79ESAxWRzVxi9/ePjm/cBUQh3P7ZbML5KykucXwaWtcFLWk8GISlVc8BVvr nqHvitFh0XCS051cfEQpxH1JYqiV1PfzxC6bK2tqBbtBwwb1IAAAIDEak1i7THgJ VPnNxw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b5mru4krq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 10:06:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee05927208so16164521cf.1 for ; Mon, 22 Dec 2025 02:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766398017; x=1767002817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eLH0Cwx0fLQzNEAsVMMYq1in/gcvYRl8pE9l3eEnT3k=; b=B69l7zwkSctyjf8Hu3ed9ik+sKFn7y1XA5Vb74rZMk9TbzeEivfRlU+Q7c8XtMLEGF SK/iEjcIvjk4MAQVk7QBAZ3FI4BDRKTkb/D5APdX+tAfJAcpU4cjj0G2Mpg+2CX194nm sYxyiXiCr2W1kEbjtoOe8P3rTI+RKEDAkiRUCX7ygCbDO6ZZ4/8bjQxCfGf3DdfACGDq mdpl9wZCg9mOpJ720jVnOJ6KRNUYQo8paZsljkadnkF6RfiRaInIKDHiZB4ThUhOhTPk NH1O3l0HSH3AJCHxkobG7c3r/Ajs9SbDv1xFBzJ+OJif442wz+G5cPRLAtAD+CR9zFDh NFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766398017; x=1767002817; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eLH0Cwx0fLQzNEAsVMMYq1in/gcvYRl8pE9l3eEnT3k=; b=C6QC0kWKxeUugyNJtzFresJDuj5bar8lqVfwn7tWFz9TFM4Ywhm1rciGDiirSMGjYu s9OPZ4RXaGajgLVUmOT01wfaIIRKqQXPSbfyRyUFlNFW2vJJSppieio1nQ0qbOZKyHtK FV3lc8Dq77afhWySxNCWxhDMN69yfBeJS3Hjv18yrzwkJrBEzbX2tWNFtbmAcerOhhr8 GrDPeAfjq9aXpF3yWds+l9PZxYxUYh0TpzsnDRq6jKonxXirFShmlslVhzHAX3ofaTrI ugN1bShFBFz2GxMvhkT68Pzo8GY+XVmuXBkbArKbgRj8DnIfOFVAGfh7dY5OHRgbup/F g/Mw== X-Forwarded-Encrypted: i=1; AJvYcCWR24IBLq0y/rcsNV2UvIN1oKKcfdT2kLPnw0LL2ayMdIZAa76GMKkxe8Vws/fxcW6y+FutkLrnm5L9zqw=@vger.kernel.org X-Gm-Message-State: AOJu0YxlyGoNT8UQc4K6vI350UsWTqiM9cdu21rijJLx1/k8G2hiShQY LkFo9OIlGdhtg0SFQG5V9zP8uKlcW09XVgLz07wGfOJdXBZlycgxBTXFfc7uun0wjQusZpCRZ29 VB4JPtDPrMLTJQMCWTL1v+ahKlXwv/n6sXeCLY9hC7QpYKXawdwHWocYUL4RxMsZU8Iw= X-Gm-Gg: AY/fxX5sIbY2VaQOtAVh/b5uqiFc4j570AB3KPF1YgNjVbm6LyxJK8LrcOKC+qHMj8u yBrV9tZw3Z9oYYrDxrP4Ts3Fbr8P+6gczoOugC+x5YqHBx7b9NfoYkiRBMSRdO6OomHRr/63kIq YL96T/h2StgHM3v/eLge2l3BnBUwjWfugrulAZ5FQAyxZAyYTMcFfqwO025auktVKTkVh9ADr2v 6c16WcwPqv5ZYSIHeX5mtdXCdcxV5BFIMJrIlHPgWjoOkSvR0m6wHTWzcH3eW75pomVTnwtJBat 9I6A+2/P9itCn9mCrZgbyY65AaWcx+DnZMsAL34Mpf71oymTqrW5MNie7MlAaSt0dhJ2MpY6o0L AJl/sOL0OdglY5Phm+aW3NalULYxgpkx99kGLgSAZnoPr9BNdg05CZdP9iRZn5wI4tA== X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr116063611cf.10.1766398017329; Mon, 22 Dec 2025 02:06:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxyQvKYEBEol+TNPmvXLeYZ8IGLq/Sg/PaYqaFgenlhw+GvGDmoHr1J4MKdbJ/Lxw9/oImXw== X-Received: by 2002:ac8:7c49:0:b0:4ed:b409:ca27 with SMTP id d75a77b69052e-4f4abde36bemr116063321cf.10.1766398016797; Mon, 22 Dec 2025 02:06:56 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f7bsm1037902666b.18.2025.12.22.02.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 02:06:56 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2025 11:06:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/7] dt-bindings: wireless: ieee80211: Add disable-rfkill property To: Dmitry Baryshkov , Krzysztof Kozlowski , Maximilian Luz Cc: Bryan O'Donoghue , jerome.debretagne@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johannes Berg , Lorenzo Bianconi , Maximilian Luz , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Jeff Johnson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, ath12k@lists.infradead.org, Jeff Johnson , Dale Whinham References: <20251220-surface-sp11-for-next-v5-0-16065bef8ef3@gmail.com> <20251220-surface-sp11-for-next-v5-2-16065bef8ef3@gmail.com> <20251220-fervent-mamba-of-sunshine-f680a8@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDA5MSBTYWx0ZWRfX5xhGRrYuPM7N 8PM23l9wKh9mUD7zzPzNsA3d3csJjvdUqHzUbaP40V9+7jJvIkyLUGm5UL0kdk8LIaRYNwfKIP8 IEuNZqOodlAo7oYntUz1abuTyZ6wNfjtNkTdzBlIN7Asy3mlRwzLtn7E53ZHkL76bQ17e6iVw2X XtTOzMkRTI1T4Fc5HDosbIic2b+qG1G1BBu62Of+OqkKj6TpNjvDpwSPx3vYy6oIRDQckvzH42I ssBBkgHzyYUapVBBMIy67hK2X4nJx5Bg4YEmdtVO3fM5BImka/GjYjYAN80TO2pPpA7EcpUJKk3 dYVYLOBKwA4feKhhpz6CeQilPrMB3XpoU5p1uLFjA5mSXTsZcSKh+3/fb77DS3B0YByrvHvQiGb tjO193A2vJ2kSioFZjiNd3urdByfdVvtvmyJ9f/xBS5auOISTETaa+o2GESP88o6Lci2PxJ+F4T eEO7xaesBMD/krXnObg== X-Authority-Analysis: v=2.4 cv=VMnQXtPX c=1 sm=1 tr=0 ts=69491842 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=UdmcajEFbZfdtKJosXMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: AJSguMDc_YabrUWOq1wNSRkBRcwYHR97 X-Proofpoint-GUID: AJSguMDc_YabrUWOq1wNSRkBRcwYHR97 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220091 On 12/20/25 5:05 PM, Dmitry Baryshkov wrote: > On Sat, Dec 20, 2025 at 10:12:14AM +0100, Krzysztof Kozlowski wrote: >> On Sat, Dec 20, 2025 at 06:04:00AM +0000, Bryan O'Donoghue wrote: >>> On 20/12/2025 00:21, Jérôme de Bretagne via B4 Relay wrote: >>>> From: Jérôme de Bretagne >>>> >>>> For some devices, Wi-Fi is entirely hard blocked by default making >>>> the Wi-Fi radio unusable, except if rfkill is disabled as expected >>>> on those models. >>>> >>>> Commit c6a7c0b09d5f ("wifi: ath12k: Add Support for enabling or >>>> disabling specific features based on ACPI bitflag") added a way to >>>> support features set via ACPI, including the DISABLE_RFKILL bit. >>>> >>>> Add a disable-rfkill property to expose the DISABLE_RFKILL bit >>>> equivalent for devices described by a Devicetree instead of ACPI. >>>> >>>> Signed-off-by: Jérôme de Bretagne >>>> --- >>>> Documentation/devicetree/bindings/net/wireless/ieee80211.yaml | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml >>>> index d89f7a3f88a71d45d6f4ab2ae909eae09cbcaf9a..c10a4675640be947cd0b5eaec2c7ff367fd93945 100644 >>>> --- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml >>>> +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml >>>> @@ -29,6 +29,12 @@ properties: >>>> different 5 GHz subbands. Using them incorrectly could not work or >>>> decrease performance noticeably >>>> >>>> + disable-rfkill: >>>> + type: boolean >>>> + description: >>>> + Disable rfkill for some devices on which Wi-Fi would be entirely hard >>>> + blocked by default otherwise >>>> + >>>> additionalProperties: true >>>> >>>> examples: >>>> >>>> -- >>>> 2.47.3 >>>> >>>> >>>> >>> >>> Is this really a hardware description though ? >>> >>> Its really more of a logical/functional description. It tells the runtime >>> what todo, not what the hardware is. >>> >>> You could also have a list of quirks in ath12k for this or have a user-space >>> utility look for the appropriate platform device string name and disable >>> rfkill. >>> >>> I think this logic belongs in drivers/net/wireless/ath/ath12k/ triggering on >>> a compat string. >> >> This is good point. Either this could be deducible from the compatible >> or this should actually describe the hardware and whatever is there >> wired/configured, not what OS should do. > > One of the examples _might_ be broken-rfkill, e.g. if the chip expects > to have the actual rfkill control from the EC, but the board doesn't > provide one. Hm, I haven't thought about the EC being involved previously. Maybe +Maximilian would have an idea whether this could be a factor that we simply haven't implemented yet in the SAM driver.. Konrad