From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752528AbdEEPEY (ORCPT <rfc822;w@1wt.eu>);
        Fri, 5 May 2017 11:04:24 -0400
Received: from foss.arm.com ([217.140.101.70]:52588 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751248AbdEEPEW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 May 2017 11:04:22 -0400
Subject: Re: [PATCH v8 5/7] coresight: add support for CPU debug module
To: Mathieu Poirier <mathieu.poirier@linaro.org>
References: <1493719717-27698-1-git-send-email-leo.yan@linaro.org>
 <1493719717-27698-6-git-send-email-leo.yan@linaro.org>
 <4cd0e395-c177-0b72-9cab-7a95aac9cca4@arm.com>
 <20170505144832.GA4507@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>, Leo Yan <leo.yan@linaro.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Wei Xu <xuwei5@hisilicon.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Mike Leach <mike.leach@linaro.org>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <d683a786-b6f2-2d95-2a42-c82b38200bfa@arm.com>
Date: Fri, 5 May 2017 16:04:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170505144832.GA4507@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 05/05/17 15:48, Mathieu Poirier wrote:
> On Fri, May 05, 2017 at 02:55:17PM +0100, Sudeep Holla wrote:

[...]

>>
>> Just curious as why this is not registered under coresight bus using
>> coresight_register ? It would be good to group all the coresight devices
>> under that bus if possible.
> 
> The only thing this driver has in common with the coresight framework is the
> name, everything else is completely different.  Coupling them together (because
> of the name) would introduce a lot of hacks and make the code unintelligible. 
> 

I guessed so from the quick glance at it as it needs descriptors with
notion of source, sink and links to register. However I felt odd to not
group under the same "coresight" bus. As someone with least knowledge
on coresight, I would check under "sys/bus/coresight" to check available
devices on the system.

Anyways that's just my thoughts though I agree with you. It may need
more refactoring to support that and it will look hackish if we try to
do that with the code as it stands.

-- 
Regards,
Sudeep