Re: [PATCH 01/11] perf/amd/ibs: Throttle interrupts with filtered ldlat samples

[Ravi Bangoria <ravi.bangoria@amd.com>]

Hi Dapeng,

>> diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
>> index aca89f23d2e0..96bb0974057f 100644
>> --- a/arch/x86/events/amd/ibs.c
>> +++ b/arch/x86/events/amd/ibs.c
>> @@ -1293,8 +1293,10 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_ibs, struct pt_regs *iregs)
>>  		 * within [128, 2048] range.
>>  		 */
>>  		if (!op_data3.ld_op || !op_data3.dc_miss ||
>> -		    op_data3.dc_miss_lat <= (event->attr.config1 & 0xFFF))
>> +		    op_data3.dc_miss_lat <= (event->attr.config1 & 0xFFF)) {
>> +			throttle = perf_event_account_interrupt(event);
>>  			goto out;
>> +		}
>>  	}
> 
> Not quite familiar with IBS code, but should the below code call the
> throttle as well?
> 
>         /* Workaround for erratum #1197 */
>         if (perf_ibs->fetch_ignore_if_zero_rip && !(ibs_data.regs[1]))
>             goto out;
> 

Yes, it should. I'll add a patch in next version.

Thanks,
Ravi