From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774AbdARUi4 (ORCPT ); Wed, 18 Jan 2017 15:38:56 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34606 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753362AbdARUiY (ORCPT ); Wed, 18 Jan 2017 15:38:24 -0500 Subject: Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] To: Andrew Lunn , Vivien Didelot References: <20170118014139.31417-1-vivien.didelot@savoirfairelinux.com> <20170118014139.31417-2-vivien.didelot@savoirfairelinux.com> <20170118125057.GB7690@lunn.ch> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" From: Florian Fainelli Message-ID: Date: Wed, 18 Jan 2017 12:38:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170118125057.GB7690@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2017 04:50 AM, Andrew Lunn wrote: > On Tue, Jan 17, 2017 at 08:41:39PM -0500, Vivien Didelot wrote: >> Now that the DSA Ethernet switches are true Linux devices, the CPU >> switch is not necessarily the first one. If its address is higher than >> the second switch on the same MDIO bus, its index will be 1, not 0. >> >> Avoid any confusion by using dst->cpu_switch instead of dst->ds[0]. >> >> Signed-off-by: Vivien Didelot > > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian