From: Johannes Holland <johannes.holland@infineon.com>
To: Rob Herring <robh@kernel.org>
Cc: <devicetree@vger.kernel.org>, <peterhuewe@gmx.de>,
<jarkko@kernel.org>, <jgg@ziepe.ca>, <amirmizi6@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-integrity@vger.kernel.org>
Subject: Re: [PATCH 4/4] tpm: Add YAML schema for the TPM TIS I2C options
Date: Mon, 11 Apr 2022 13:33:17 +0200 [thread overview]
Message-ID: <d6878e6c-e949-3c38-f370-0aa0ac8ca226@infineon.com> (raw)
In-Reply-To: <1649088538.021063.1436944.nullmailer@robh.at.kernel.org>
On 04.04.2022 18:08, Rob Herring wrote:> On Mon, 04 Apr 2022 10:18:35 +0200, Johannes Holland wrote:
>> Add a YAML schema to support device tree bindings for the generic I2C
>> physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP)
>> Specification for TPM 2.0 v1.04 Revision 14.
>>
>> Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
>> ---
>> .../bindings/security/tpm/tpm-tis-i2c.yaml | 48 +++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.example.dt.yaml: tpm@2e: compatible:1: 'tcg,tpm-tis-i2c' was expected
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.example.dt.yaml: tpm@2e: compatible: ['infineon,slb9673', 'nuvoton,npct75x', 'tcg,tpm-tis-i2c'] is too long
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Sorry for the inconvenience. This will be fixed in the next patch.
Thanks,
Johannes
next prev parent reply other threads:[~2022-04-11 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 8:18 [PATCH 1/4] tpm: Add tpm_tis_i2c backend for tpm_tis_core Johannes Holland
2022-04-04 8:18 ` [PATCH 2/4] tpm: Add tpm_tis_verify_crc to the tpm_tis_phy_ops protocol layer Johannes Holland
2022-04-04 8:18 ` [PATCH 3/4] tpm: Implement command and response retry in tpm_tis_core Johannes Holland
2022-04-04 8:18 ` [PATCH 4/4] tpm: Add YAML schema for the TPM TIS I2C options Johannes Holland
2022-04-04 16:08 ` Rob Herring
2022-04-11 11:33 ` Johannes Holland [this message]
2022-04-04 16:18 ` Rob Herring
2022-04-11 11:30 ` Johannes Holland
2022-04-07 10:07 ` [PATCH 1/4] tpm: Add tpm_tis_i2c backend for tpm_tis_core Jarkko Sakkinen
2022-04-11 12:30 ` Johannes Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6878e6c-e949-3c38-f370-0aa0ac8ca226@infineon.com \
--to=johannes.holland@infineon.com \
--cc=amirmizi6@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®