From: Daniel Bristot de Oliveira <daolivei@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Julien Desfossez <jdesfossez@efficios.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint
Date: Tue, 7 Jun 2016 21:18:41 -0300 [thread overview]
Message-ID: <d6a0e02e-99ea-4f54-d0aa-78e1db8a1c50@redhat.com> (raw)
In-Reply-To: <20160606210353.GF30154@twins.programming.kicks-ass.net>
On 06/06/2016 06:03 PM, Peter Zijlstra wrote:
>>>> > >> +/*
>>>> > >> + * Tracepoint for priority changes of a task.
>>>> > >> + */
>>>> > >> +DEFINE_EVENT(sched_prio_template, sched_set_prio,
>>>> > >> + TP_PROTO(struct task_struct *tsk, int newprio),
>>>> > >> + TP_ARGS(tsk, newprio));
>>>> > >> +
> Nak on anything that cannot fundamentally deal with SCHED_DEADLINE.
My 2 cents: I liked the idea... But, I agree with peterz. This cannot
fundamentally deal with deadline scheduler.
In the deadline scheduler, the priority is set at every new sporadic
activation of the task (it is a fixed job priority scheduler - not a
fixed priority scheduler). The priority is the deadline of the new job.
The deadline is an u64, that does not fit in the int prio - so it cannot
be reused.
-- Daniel
next prev parent reply other threads:[~2016-06-08 0:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 15:16 [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function Julien Desfossez
2016-05-27 15:16 ` [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint Julien Desfossez
2016-05-30 13:18 ` Mathieu Desnoyers
2016-06-06 19:52 ` Mathieu Desnoyers
2016-06-06 21:03 ` Peter Zijlstra
2016-06-08 0:18 ` Daniel Bristot de Oliveira [this message]
2016-05-30 13:18 ` [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function Mathieu Desnoyers
2016-06-06 21:47 ` Mathieu Desnoyers
2016-06-07 7:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a0e02e-99ea-4f54-d0aa-78e1db8a1c50@redhat.com \
--to=daolivei@redhat.com \
--cc=jdesfossez@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome