From: shaozhengchao <shaozhengchao@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()
Date: Thu, 1 Sep 2022 09:04:26 +0800 [thread overview]
Message-ID: <d6a29d21-5c90-ca6d-8060-56088882a776@huawei.com> (raw)
In-Reply-To: <20220831123014.18456fa9@kernel.org>
On 2022/9/1 3:30, Jakub Kicinski wrote:
> On Mon, 29 Aug 2022 15:17:20 +0800 Zhengchao Shao wrote:
>> tcf_qevent_parse_block_index() has been checked the value of block_index.
>
> Please rephrase this:
>
> tcf_qevent_parse_block_index() never returns a zero block_index.
>
> Took me a while to figure out what you mean.
>
>> Therefore, it is unnecessary to check the value of block_index in
>> tcf_qevent_init().
Hi Jakub:
Thank you for your reply. I will send v2.
Zhengchao Shao
prev parent reply other threads:[~2022-09-01 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 7:17 Zhengchao Shao
2022-08-31 19:30 ` Jakub Kicinski
2022-09-01 1:04 ` shaozhengchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a29d21-5c90-ca6d-8060-56088882a776@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®