From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EE838C415 for ; Thu, 2 Jul 2026 19:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783020577; cv=none; b=RjplPqEcOYK+gkyHV1lnfd0qkQfuu9eDSSvnI/YVOhlTQxtnqhXii++mnAgFATKW/UC+URg5h0XY5gkh8HoiTUoI5j+1pEn8YR7J8PxSBwTegsNpptQ3jabYu6n3+nTGmJQ3Ei7O1zxNHnUyh/8nHYlxRKzFQV8xI0epJ4bYej4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783020577; c=relaxed/simple; bh=UdMJM06ebK67YQ2Mnbs0Jp1/l3ZNaXIh/MKaQ3oYKr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S3H5dW+lSZL1AabO8bht5D8mulOyz7x37FTIFY8Gt6ghkGLS6ZQnHVCm+W2DafE6vLv5bWPTdFZf6/91jJbpEiBS+yK0boodJognbpMy8GDzbibGW6iVx6iO5pzvoDocswzNXsOAeEt7lzaHhyBNrXISJrU7YVopzMXIfh83zoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MOnhQbf1; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MOnhQbf1" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493c52cde9eso13949465e9.3 for ; Thu, 02 Jul 2026 12:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783020575; x=1783625375; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=zAwDyBfy9pmItaLqNOcnGFdZ3qhtmyuBm6fxfzFEds4=; b=MOnhQbf1/CqJFRSRzJybl3CWwBroY7cPKOcHx4jCNrtLqHUMyB6ujxtqzQhD4Q4xDh sudlR5oq3V72pp9i+NAt6O2GCCUkUdhSrA3AGe12ObYoXHPiguj9xOgRJ7m17BoLLkVO /F+TD0qhA47QA4NF3Ziw/3TsbzePPCk6tDNX0VYltyakCRYMVig7jUAwZIE67tCxWvvJ 3VcdZMQyB793F7+xbGrSL3cMFnO/qVVWUDYuSYjeUTb6CdXMPPSFVHr1Xy1gJXBG1/fM 4/MGvCAXEPHeGMgK84h+38rMddq9Ozuv6Y2ITiznjFl7luuxkSUkr9A9HGWRPzREg024 In1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783020575; x=1783625375; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zAwDyBfy9pmItaLqNOcnGFdZ3qhtmyuBm6fxfzFEds4=; b=SMwcpBLgV9bUz8afEFcw3yOapQW/7xiXB3WfVpuqjleORhzFbvOnZT/mSXFvqMSvRC S0zmq4FeuPOtefd7eCjKcaXrt5p6Ss1sFZ7cdev+TFdTU9LQkKWzct6riIqVE9uL9hvC /d7myexdXSnMZfOtyGDPiNcfmi2cfNyx+dMwy1JkgA8ncQkCCIHnQHdTLAVZ/p0d4yKg v2eM47cR7GljT3a9PKLiFuMZjZriRnodBEvTPEkUELNUKjCC7Jv9g1WflClG1YRO/OQD Cgjq/t158EERbOsQr9QdE0s/AdN1vfPjfV1F2sflnQV7O7w9WXSktSbcKA15tA8HkEr/ E9IA== X-Forwarded-Encrypted: i=1; AHgh+RovlZnr7FIwMY0fY3G13Iwjb2dQ96V32PxZ/Eabs46eF3I7dBf34WWYwt4D2EXTGl+W7LLSLojACNWzYo8=@vger.kernel.org X-Gm-Message-State: AOJu0YwRIZFKIcjdzpkwzMzJJMYtyEr4NTGSXAHuOS1kTcb5EbHOn4LS pcNfWL2tAp5NSpNrSxmen8BqZXsyd0Rb+uOxrCjLLbLctHJqN7Z5Rgc+ X-Gm-Gg: AfdE7cl1apzhgEulak6OQv5X1fEv8z5FJ/5lTLpPMZ7NUKKF3jCJHG23QvZk4GNGKbS 06+WQDki2eFqJo/19pRF83RSagbLkRw3hxMxa+g2Zc3FNw4VZC+DsEp9qHIXPxxD5QezrO2faNK HMqkiFoqqpxVcFswOfQRJWZw0AwzrAch7jLStnBnQ2KkrIEG2h4SNIbJLog8gb8V/lQeSOFo8bz l4SM0yLgUBTYD3UCzIPMydmOX+J9WOfRh5II8jE0Bm31KtV71QTxNXfgHP5nKsXw5RwGjOB3Lpc c2rTh4gaE/6Xdav7blE2E8tY1hPBT/ulnL2YvTykH9U10xaLaE6Y8StrE28EGUG+FSLWC9+alUl eFZq13lR9yy05lVUMy9vDKKj7283BWNqFhTnCH8gi7cuUgKxx4bWrvaLSEFtITA9m3qvWTcV63G YPKUiYx3Ohi8JAP0QTwJ0PyxzFx+J9eSaMrYBy+tLktbOWMYukYUNr2gi/soTMA+tpNaVjjDimD xogO1XT X-Received: by 2002:adf:ea82:0:b0:475:a4ae:e630 with SMTP id ffacd0b85a97d-4775be03177mr9148509f8f.37.1783020574993; Thu, 02 Jul 2026 12:29:34 -0700 (PDT) Received: from [10.128.11.240] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3db964sm11113317f8f.8.2026.07.02.12.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 12:29:33 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Thu, 2 Jul 2026 20:29:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 12/15] onsemi: s2500: Add driver support for TS2500 MAC-PHY To: Selvamani.Rajagopal@onsemi.com, Andrew Lunn , Piergiorgio Beruto , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Parthiban Veerasooran , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Jerry Ray References: <20260629-s2500-mac-phy-support-v6-0-18ce79500371@onsemi.com> <20260629-s2500-mac-phy-support-v6-12-18ce79500371@onsemi.com> Content-Language: en-US From: Julian Braha In-Reply-To: <20260629-s2500-mac-phy-support-v6-12-18ce79500371@onsemi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Selvamani, On 6/29/26 18:23, Selvamani Rajagopal via B4 Relay wrote: > +if NET_VENDOR_ONSEMI > + > +source "drivers/net/ethernet/onsemi/s2500/Kconfig" > + > +endif # NET_VENDOR_ONSEMI > + > diff --git a/drivers/net/ethernet/onsemi/Makefile b/drivers/net/ethernet/onsemi/Makefile > new file mode 100644 > index 000000000000..f3d4eb154313 > --- /dev/null > +++ b/drivers/net/ethernet/onsemi/Makefile > @@ -0,0 +1,7 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Makefile for the onsemi network device drivers. > +# > + > +obj-$(CONFIG_S2500_MACPHY) += s2500/ > + > diff --git a/drivers/net/ethernet/onsemi/s2500/Kconfig b/drivers/net/ethernet/onsemi/s2500/Kconfig > new file mode 100644 > index 000000000000..f2e8d5d1429d > --- /dev/null > +++ b/drivers/net/ethernet/onsemi/s2500/Kconfig > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# onsemi S2500 Driver Support > +# > + > +if NET_VENDOR_ONSEMI > + > +config S2500_MACPHY > + tristate "S2500 support" > + depends on SPI > + select NCN26000_PHY > + select OA_TC6 > + help > + Support for the onsemi TS2500 MACPHY Ethernet chip. > + It works under the framework that conform to OPEN Alliance > + 10BASE-T1x Serial Interface specification. > + > + To compile this driver as a module, choose M here. The module will be > + called s2500. > + > +endif # NET_VENDOR_ONSEMI S2500_MACPHY still has that duplicate dependency from being inside two of these: 'if NET_VENDOR_ONSEMI..endif' And I already pointed it out on v5: https://lore.kernel.org/all/90f84945-e83f-40a8-8d9e-a477c45579e9@gmail.com/ :( - Julian Braha