From: HyeongJun An <sammiee5311@gmail.com>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, ckeepax@opensource.cirrus.com,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 05/13] ASoC: codecs: wm8983: Fix definition of ADC 128x Oversampling control
Date: Wed, 14 Oct 2026 15:32:32 +0900 [thread overview]
Message-ID: <d6a5bbab35e1fd2bec5b13d30951546080d493a8.1791959026.git.sammiee5311@gmail.com> (raw)
In-Reply-To: <cover.1791959026.git.sammiee5311@gmail.com>
ADC 128x oversampling (ADCOSR128) is at bit 3 of ADC Control, not at
bit 8, which is the high pass filter enable (HPFEN).
Fixes: 6b3860b0a20a ("ASoC: WM8983: Initial driver")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
---
sound/soc/codecs/wm8983.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8983.c b/sound/soc/codecs/wm8983.c
index fab25f35fd14..5639dad90405 100644
--- a/sound/soc/codecs/wm8983.c
+++ b/sound/soc/codecs/wm8983.c
@@ -234,7 +234,7 @@ static const struct snd_kcontrol_new wm8983_snd_controls[] = {
8, 1, 0, pga_boost_tlv),
SOC_DOUBLE("ADC Inversion Switch", WM8983_ADC_CONTROL, 0, 1, 1, 0),
- SOC_SINGLE("ADC 128x Oversampling Switch", WM8983_ADC_CONTROL, 8, 1, 0),
+ SOC_SINGLE("ADC 128x Oversampling Switch", WM8983_ADC_CONTROL, 3, 1, 0),
SOC_DOUBLE_R_TLV("Playback Volume", WM8983_LEFT_DAC_DIGITAL_VOL,
WM8983_RIGHT_DAC_DIGITAL_VOL, 0, 255, 0, dac_tlv),
--
2.43.0
next prev parent reply other threads:[~2026-10-14 6:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:32 [PATCH 00/13] ASoC: codecs: Fix Wolfson control definitions that write another control's bits HyeongJun An
2026-10-14 6:32 ` [PATCH 01/13] ASoC: codecs: wm8990: Fix definition of right input PGA controls HyeongJun An
2026-10-14 9:32 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 02/13] ASoC: codecs: wm8990: Fix definition of LOMIX AINLMUX Bypass Volume control HyeongJun An
2026-10-14 9:32 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 03/13] ASoC: codecs: wm8991: Fix definition of right input PGA controls HyeongJun An
2026-10-14 9:35 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 04/13] ASoC: codecs: wm8991: Fix definition of LOMIX AINLMUX Bypass Volume control HyeongJun An
2026-10-14 9:35 ` Charles Keepax
2026-10-14 6:32 ` HyeongJun An [this message]
2026-10-14 9:39 ` [PATCH 05/13] ASoC: codecs: wm8983: Fix definition of ADC 128x Oversampling control Charles Keepax
2026-10-14 6:32 ` [PATCH 06/13] ASoC: codecs: wm8985: " HyeongJun An
2026-10-14 9:41 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 07/13] ASoC: codecs: wm8994: Fix definition of WM8958 noise gate hold time controls HyeongJun An
2026-10-14 9:46 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 08/13] ASoC: codecs: wm8955: Fix definition of Treble Cutoff control HyeongJun An
2026-10-14 9:51 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 09/13] ASoC: codecs: wm_hubs: Fix definition of MIXINR to MIXOUTR volume control HyeongJun An
2026-10-14 9:56 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 10/13] ASoC: codecs: wm8737: Fix definition of zero cross switches HyeongJun An
2026-10-14 9:58 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 11/13] ASoC: codecs: wm5100: Fix definition of EQ3 Band 1 Volume control HyeongJun An
2026-10-14 9:59 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 12/13] ASoC: codecs: wm8750: Fix definition of ALC Capture NG Type control HyeongJun An
2026-10-14 10:01 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 13/13] ASoC: codecs: wm8510: Fix definition of ADC Inversion Switch control HyeongJun An
2026-10-14 10:04 ` Charles Keepax
2026-10-14 13:27 ` [PATCH 00/13] ASoC: codecs: Fix Wolfson control definitions that write another control's bits Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a5bbab35e1fd2bec5b13d30951546080d493a8.1791959026.git.sammiee5311@gmail.com \
--to=sammiee5311@gmail.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®