From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966236AbcJ1SXG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 14:23:06 -0400
Received: from smtprelay4.synopsys.com ([198.182.47.9]:60169 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965777AbcJ1SWw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 14:22:52 -0400
Subject: Re: [PATCH] Revert "usb: dwc2: gadget: fix TX FIFO size and address
 initialization"
To: Leo Yan <leo.yan@linaro.org>, John Youn <John.Youn@synopsys.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        "Guodong Xu" <guodong.xu@linaro.org>,
        "zhangfei.gao@linaro.org" <zhangfei.gao@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steve Muckle <steve.muckle@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Robert Baldyga <r.baldyga@samsung.com>
References: <1477669902-24032-1-git-send-email-leo.yan@linaro.org>
From: John Youn <John.Youn@synopsys.com>
Message-ID: <d6b4322d-1c2b-2036-79cf-cf5aaa14f2e1@synopsys.com>
Date: Fri, 28 Oct 2016 11:22:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1477669902-24032-1-git-send-email-leo.yan@linaro.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.12.67.173]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/28/2016 8:52 AM, Leo Yan wrote:
> This reverts commit aa381a7259c3f53727bcaa8c5f9359e940a0e3fd.
> 
> Reverting this patch, as it incorrectly assumes TX FIFO size is fixed
> and cannot change FIFO size; it removes all related dt binding code
> and have no chance to set FIFO size at init phase.
> 
> As result, Hi6220 cannot set correct FIFO size for gadget driver and
> ethernet on USB function driver is easily to hang. And in the kernel
> there also have other platforms set FIFO size for usb controller,
> e.g. arch/arm64/boot/dts/rockchip/rk3368.dtsi.
> 
> This patch re-enables dt binding to set FIFO size.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>


This is already queued for 4.9-rc in Felipe's tree.

Hi Felipe,

It seems like your fixes branch for 4.9-rc2 didn't get merged
upstream. Can we get them pulled for the next -rc? There are platforms
that are broken on 4.9 without them.

Thanks,
John