From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saalim Quadri <danascape@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, daniel.baluta@nxp.com
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: wm8510: Convert to dtschema
Date: Mon, 3 Apr 2023 14:51:18 +0200 [thread overview]
Message-ID: <d6b4df41-02cb-b900-5e8b-8ad08d3d36f1@linaro.org> (raw)
In-Reply-To: <20230403105237.3854-1-danascape@gmail.com>
On 03/04/2023 12:52, Saalim Quadri wrote:
> Convert the WM8510 audio CODEC bindings to DT schema
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
> Changes:
> V1 - V2: Fixup issues mentioned by Krzysztof
So what changed?
> Add SPI and I2C examples
Why?
>
> .../devicetree/bindings/sound/wlf,wm8510.yaml | 52 +++++++++++++++++++
> .../devicetree/bindings/sound/wm8510.txt | 18 -------
> 2 files changed, 52 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
> new file mode 100644
> index 000000000000..418a82f65531
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WM8510 audio CODEC
> +
> +maintainers:
> + - patches@opensource.cirrus.com
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: wlf,wm8510
> +
> + reg:
> + maxItems: 1
> +
> + "#sound-dai-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + codec@0 {
> + compatible = "wlf,wm8510";
> + reg = <0>;
> + };
> + };
> +
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + codec@1a {
Drop second example. It is the same.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-03 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 10:52 Saalim Quadri
2023-04-03 12:51 ` Krzysztof Kozlowski [this message]
2023-04-03 15:53 ` Saalim Quadri
2023-04-05 13:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b4df41-02cb-b900-5e8b-8ad08d3d36f1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=danascape@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®