From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F33135F8D1 for ; Fri, 27 Mar 2026 16:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774628124; cv=none; b=gENCQ9F2HZeeijC5O04ayoKCrDgpCaE7fMYeTa2r2b5ps31ghDyi2iflP+oQPuTikQFRsQ5l6dgNIcUt+J7ZaRM0HxOmdzfadpTu+L6cSJPtZIKBOMflqjb5gdibLftwcyezTylKAKLLF9QgqSvDE9eHtZc/wrpHeD/kr7AOcaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774628124; c=relaxed/simple; bh=lyT28lq6QXv8M6gRhZ/0W160rc3E3KQnFvhIMZS5M+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d9cTy/KuRcPtg4ORYapToaevgNCD6giNTrCSvwoLvUEb/B+153/bmhcatc7ab8FHozmETQco+rovcfWtO7ACBvwCdvUebF6iLbAU39G6OtG1MCswNjDVtzd+rlCDV72+eUv9QfdU7MkVvVty197oR4YQ1A4gcMSRvB1qT+NeBZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gWWJGHfg; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gWWJGHfg" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2c0c955a481so1950173eec.1 for ; Fri, 27 Mar 2026 09:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774628121; x=1775232921; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=nXI6a37pJZiwRmO/eIOD3fbLH9X8gu1hpIrfkIMZNvc=; b=gWWJGHfgZrPOIVmVq8Q2G6ijeSoViIhawRlvqunfOMHY2lLHqdH3x742K7ffIQxB++ b/7ZG09DE0YdYgnZqD2UDN+D/OWUzv6V2rOKqxM0d8jObkxSF1Yfb722gqIMKHlFSn3n Kb3D4qf6MfDke+0ix0TplTuMNqvFq/kYTvUEMpnfEoeY2zMmRIuGKsxwmFQ2TsnsN8cj bKyzdaHW70e/thXImw25Q0ANnHlj8jtwuaMKxe+SKo7EP64JOrCbnGCs8fqdk4l1NRBm wjEz875WZGgIGGRWIHEifIQkaK0q6II77Ss45wl+PiwNFE1OrL85/FY9a2o2HImKOq8d CZgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774628121; x=1775232921; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nXI6a37pJZiwRmO/eIOD3fbLH9X8gu1hpIrfkIMZNvc=; b=OQ2tYYkx8p3JKAYbe8u8btRh6Wm8vdWkcCMGaafmgbpps2cncJnehPZNYCbCbIeGZJ +j7s7O1l1SruSp4nfJQmaYxwd+MMuy/8x80faqE2V/Cd8p2uKxoiG+1brq0cH4+qmgii jLHYD6Ch3hmJ5uEIF0AqnY/Mp8RgGB4jRxqJhLiLYlKckHOSo+NnIfacG1+596Ln9Us7 Z5CxHAj1P1Z2exEik/ebbLFEUwD1yR5n1A7L4DDMHLukORMA5TRa+Z6tw0jOYl9cEgqT 0pMCQlRyka2rzWzO7pMkgH0zi4lyynoWLPbWSaPAB7/bgxWBeHqWdjXvfXzXVpYmn8Vd u11Q== X-Forwarded-Encrypted: i=1; AJvYcCVijkLSuv39vMMzE/CDkndTL2xt8vp9pU7mrPDRpUl0A3W1dSyXTcaVMqfVDifw83kr6HmP6dyjnbw2xYg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyry+P24iyP9kwnzaDEq9pfoeuJzHXzs/VBv62R/bvlpF2m0l4v RShbUVUGvaIgdCWcqxH1am85ue7UToKN4AWiG/tXWTTkmS9/Gv2ruxxf X-Gm-Gg: ATEYQzy3vKABJEbunHgJ6ZelAAMoBRmdZy8vd6ZNiqV0nMtqUx/3H+VIMyF8FoPcZ0p pCNnzav3zjH45gguK4+8rIpuNaqkCYbzU1x178sm8RcoQ9mlNyFuCx/3MRFUDEqH5LHmHx3xSsU /AJr1dZQwfj1uFNGY4Paw3yGxkr3uXfiWaUmdBaHhYYAb9T5yKLUjrYnePBy8zQ9Rjm9YSir6El gFU7xzypUrCvLTIzYaYdwkRMtglix1BN2v3mIdZ7FizA6Nu5BtPG+2Q32MCBDJ1OBM9qImwH3aS qdJtTv/GlBTM6zYcVHfVdxTsS4RepeBe7mI31vnJ6SMD4Iu8Ff7VBAsW1rQSdCXkpFUBDl9JDQZ xtJSblWVUORcsob6BLwuQGS6l3mJG2c3fDfSIaq6ZPXyxmRT6j3CTcWa/EkFznwkRCY/nSXgWh9 ORXSy6q0CofJc0g6QCdKaExg2x7cZBduj3qb3NwdTK1ibniVKTw8atSr81EgjZTySisS8fIf82 X-Received: by 2002:a05:7022:221b:b0:128:d752:e076 with SMTP id a92af1059eb24-12ab2857e9emr1988954c88.3.1774628120782; Fri, 27 Mar 2026 09:15:20 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa762430bsm8398186c88.10.2026.03.27.09.15.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 09:15:19 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 27 Mar 2026 09:15:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10] hwmon: (yogafan) Add support for Lenovo Yoga/Legion fan monitoring To: Sergio Melas Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <7ac0d696-327d-4dfe-8ee3-73242255ad32@roeck-us.net> <20260327012925.266336-1-sergiomelas@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260327012925.266336-1-sergiomelas@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sergio, On 3/26/26 18:29, Sergio Melas wrote: > To address low-resolution sampling in the Lenovo EC firmware, the > driver implements a Rate-Limited Lag (RLLag) filter using a passive > discrete-time first-order model. This ensures physical consistency > of the RPM signal regardless of userspace polling rates. > > Concerning youd doubt: > Sorry, you lost me a bit. Isn't that already implemented in v8 ? > > V8 had the logic, but V9 adds the extensive database and documentation > (see yogafan.rst) to guarantee all ACPI paths and 8/16-bit multipliers > are correctly mapped. > > Please disregard the previous v9 submission. It was incorrectly formatted > as an incremental diff; this version (v9/v10) is a complete standalone > patch for clean application. > Apologies for the noise. > > Signed-off-by: Sergio Melas Sashiko still has a concern associated with rapid polling: https://sashiko.dev/#/patchset/20260327012925.266336-1-sergiomelas%40gmail.com ... and it turns out that you did not run checkpatch, much less checkpatch --strict, on your patch. total: 2 errors, 6 warnings, 3 checks, 453 lines checked For the filter, it might make sense to only run it after some period of time. Couple of additional comments (first actual human review) inline, mostly about formatting. Thanks, Guenter > > --- > v9: > - Implement ACPI handle resolution during probe for better performance (O(1) read). > - Add MODULE_DEVICE_TABLE(dmi, ...) to enable module autoloading. > - Refine RLLag filter documentation and suspend/resume logic. > - Include comprehensive EC architecture research database (8-bit vs 16-bit). > - Validated efficiency on kernels 6.18, 6.19, and 7.0-rc5: 'perf top' > confirms negligible CPU overhead (<0.01%) during active polling. > v8: > - Replaced heuristic multiplier with deterministic DMI Quirk Table. > - Added 'depends on DMI' to Kconfig. > - Verified FOPTD model (1000ms TAU / 1500 RPM/s slew) against hardware traces. > - Increased filter precision to 12-bit fixed-point. > v7: > - Fixed Kconfig: Removed non-existent 'select MATH64'. > - Fixed unused macro: Utilized RPM_FLOOR_LIMIT to implement an > immediate 0-RPM bypass in the filter. > - Clarification: Previous "unified structure" comment meant that all > 6 files (driver, docs, metadata) are now in this single atomic patch. > v6: > - Unified patch structure (6 files changed). > - Verified FOPTD (First-Order Plus Time Delay) model against hardware > traces (Yoga 14c) to ensure physical accuracy of the 1000ms time constant. > - Fixed a rounding stall: added a +/- 1 RPM floor to the step calculation > to ensure convergence even at high polling frequencies. > - Set MAX_SLEW_RPM_S to 1500 to match physical motor inertia. > - Documentation: Updated to clarify 100-RPM hardware step resolution. > - 32-bit safety: Implemented div64_s64 for coefficient precision. > v5: > - Fixed 32-bit build failures by using div64_s64 for 64-bit division. > - Extracted magic numbers into constants (RPM_UNIT_THRESHOLD, etc.). > - Fixed filter stall by ensuring a minimum slew limit (limit = 1). > - Refined RPM floor logic to trigger only when hardware reports 0 RPM. > - Resolved 255/256 unit-jump bug by adjusting heuristic thresholds. > v4: > - Rebased on groeck/hwmon-next branch for clean application. > - Corrected alphabetical sorting in Kconfig and Makefile. > - Technical Validation & FOPTD Verification: > - Implemented RLLag (Rate-Limited Lag) first-order modeling. > - Used 10-bit fixed-point math for alpha calculation to avoid > floating point overhead in the kernel. > - Added 5000ms filter reset for resume/long-polling sanitation. > v3: > - Added MAINTAINERS entry and full Documentation/hwmon/yogafan.rst. > - Fixed integer overflow in filter math. > - Added support for secondary fan paths (FA2S) for Legion laptops. > v2: > - Migrated from background worker to passive multirate filtering. > - Implemented dt-based scaling to maximize CPU sleep states. > - Restricted driver to Lenovo hardware via DMI matching. > v1: > - Initial submission with basic ACPI fan path support. > --- > --- > Documentation/hwmon/index.rst | 1 + > Documentation/hwmon/yogafan.rst | 129 +++++++++++++++ > MAINTAINERS | 8 + > drivers/hwmon/Kconfig | 8 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/yogafan.c | 284 ++++++++++++++++++++++++++++++++ > 6 files changed, 431 insertions(+) > create mode 100644 Documentation/hwmon/yogafan.rst > create mode 100644 drivers/hwmon/yogafan.c > > diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst > index 559c32344cd3..199f35a75282 100644 > --- a/Documentation/hwmon/index.rst > +++ b/Documentation/hwmon/index.rst > @@ -282,4 +282,5 @@ Hardware Monitoring Kernel Drivers > xdp710 > xdpe12284 > xdpe152c4 > + yogafan > zl6100 > diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst > new file mode 100644 > index 000000000000..03cc329f6fca > --- /dev/null > +++ b/Documentation/hwmon/yogafan.rst > @@ -0,0 +1,129 @@ > +=============================================================================================== > +Kernel driver yogafan > +=============================================================================================== > + > +Supported chips: > + > + * Lenovo Yoga, Legion, IdeaPad, Slim, Flex, and LOQ Embedded Controllers > + Prefix: 'yogafan' > + Addresses: ACPI handle (See Database Below) > + > +Author: Sergio Melas > + > +Description > +----------- > + > +This driver provides fan speed monitoring for modern Lenovo consumer laptops. > +Most Lenovo laptops do not provide fan tachometer data through standard > +ISA/LPC hardware monitoring chips. Instead, the data is stored in the > +Embedded Controller (EC) and exposed via ACPI. > + > +The driver implements a **Rate-Limited Lag (RLLag)** filter to handle > +the low-resolution and jittery sampling found in Lenovo EC firmware. > + > +Hardware Identification and Multiplier Logic > +-------------------------------------------- > + > +The driver supports two distinct EC architectures. Differentiation is handled > +deterministically via a DMI Product Family quirk table during the probe phase, > +eliminating the need for runtime heuristics. > + > +1. 8-bit EC Architecture (Multiplier: 100) > + - **Families:** Yoga, IdeaPad, Slim, Flex. > + - **Technical Detail:** These models allocate a single 8-bit register for > + tachometer data. Since 8-bit fields are limited to a value of 255, the > + BIOS stores fan speed in units of 100 RPM (e.g., 42 = 4200 RPM). > + > +2. 16-bit EC Architecture (Multiplier: 1) > + - **Families:** Legion, LOQ. > + - **Technical Detail:** High-performance gaming models require greater > + precision for fans exceeding 6000 RPM. These use a 16-bit word (2 bytes) > + storing the raw RPM value directly. > + > +Filter Details: > +--------------- > + > +The RLLag filter is a passive discrete-time first-order lag model that ensures: > + - **Smoothing:** Low-resolution step increments are smoothed into 1-RPM increments. > + - **Slew-Rate Limiting:** Prevents unrealistic readings by capping the change > + to 1500 RPM/s, matching physical fan inertia. > + - **Polling Independence:** The filter math scales based on the time delta > + between userspace reads, ensuring a consistent physical curve regardless > + of polling frequency. > + > +Suspend and Resume > +------------------ > + > +The driver utilizes the boottime clock (ktime_get_boottime()) to calculate the > +sampling delta. This ensures that time spent in system suspend is accounted > +for. If the delta exceeds 5 seconds (e.g., after waking the laptop), the > +filter automatically resets to the current hardware value to prevent > +reporting "ghost" RPM data from before the sleep state. > + > +Usage > +----- > + > +The driver exposes standard hwmon sysfs attributes: > +Attribute Description > +fanX_input Filtered fan speed in RPM. > + > + > +Note: If the hardware reports 0 RPM, the filter is bypassed and 0 is reported > +immediately to ensure the user knows the fan has stopped. > + > + > +=============================================================================================== > +LENOVO FAN CONTROLLER: MASTER REFERENCE DATABASE (2026) > +=============================================================================================== > + > +MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier > +----------------------------------------------------------------------------------------------- > +82N7 | Yoga 14cACN | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100 > +80V2 / 81C3 | Yoga 710/720 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100 > +83E2 / 83DN | Yoga Pro 7/9 | 0xFE | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100 > +82A2 / 82A3 | Yoga Slim 7 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100 > +81YM / 82FG | IdeaPad 5 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100 > +82JW / 82JU | Legion 5 (AMD) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS (Fan1) | 16-bit | 1 > +82JW / 82JU | Legion 5 (AMD) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FA2S (Fan2) | 16-bit | 1 > +82WQ | Legion 7i (Int) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS (Fan1) | 16-bit | 1 > +82WQ | Legion 7i (Int) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FA2S (Fan2) | 16-bit | 1 > +82XV / 83DV | LOQ 15/16 | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS /FA2S | 16-bit | 1 > +83AK | ThinkBook G6 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100 > +81X1 | Flex 5 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100 > +*Legacy* | Pre-2020 Models | 0x06 | \_SB.PCI0.LPC.EC.FAN0 | 8-bit | 100 > +----------------------------------------------------------------------------------------------- > + > +METHODOLOGY & IDENTIFICATION: > + > +1. DSDT ANALYSIS (THE PATH): > + BIOS ACPI tables were analyzed using 'iasl' and cross-referenced with > + public dumps. Internal labels (FANS, FAN0, FA2S) are mapped to > + EmbeddedControl OperationRegion offsets. > + > +2. EC MEMORY MAPPING (THE OFFSET): > + Validated by matching NBFC (NoteBook FanControl) XML logic with DSDT Field > + definitions found in BIOS firmware. > + > +3. DATA-WIDTH ANALYSIS (THE MULTIPLIER): > + - 8-bit (Multiplier 100): Standard for Yoga/IdeaPad. Raw values (0-255). > + - 16-bit (Multiplier 1): Standard for Legion/LOQ. Two registers (0xFE/0xFF). > + > + > +References > +---------- > + > +1. **ACPI Specification (Field Objects):** Documentation on how 8-bit vs 16-bit > + fields are accessed in OperationRegions. > + https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#field-objects > + > +2. **NBFC Projects:** Community-driven reverse engineering > + of Lenovo Legion/LOQ EC memory maps (16-bit raw registers). > + https://github.com/hirschmann/nbfc/tree/master/Configs > + > +3. **Linux Kernel Timekeeping API:** Documentation for ktime_get_boottime() and > + handling deltas across suspend states. > + https://www.kernel.org/doc/html/latest/core-api/timekeeping.html > + > +4. **Lenovo IdeaPad Laptop Driver:** Reference for DMI-based hardware > + feature gating in Lenovo laptops. > + https://github.com/torvalds/linux/blob/master/drivers/platform/x86/ideapad-laptop.c > diff --git a/MAINTAINERS b/MAINTAINERS > index 830c6f076b00..94416af57b28 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14873,6 +14873,14 @@ W: https://linuxtv.org > Q: http://patchwork.linuxtv.org/project/linux-media/list/ > F: drivers/media/usb/dvb-usb-v2/lmedm04* > > +LENOVO YOGA FAN DRIVER > +M: Sergio Melas > +L: linux-hwmon@vger.kernel.org > +W: https://github.com/sergiomelas > +S: Maintained > +F: Documentation/hwmon/yogafan.rst > +F: drivers/hwmon/yogafan.c > + > LOADPIN SECURITY MODULE > M: Kees Cook > S: Supported > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 7dd8381ba0d0..ca1ed3e63d4a 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -2653,6 +2653,14 @@ config SENSORS_XGENE > If you say yes here you get support for the temperature > and power sensors for APM X-Gene SoC. > > +config SENSORS_YOGAFAN > + tristate "Lenovo Yoga Fan Hardware Monitoring" > + depends on ACPI && HWMON && DMI > + help > + Say Y here if you want to monitor fan speeds on Lenovo Yoga > + and Legion laptops. > + > + > config SENSORS_INTEL_M10_BMC_HWMON > tristate "Intel MAX10 BMC Hardware Monitoring" > depends on MFD_INTEL_M10_BMC_CORE > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 556e86d277b1..0fce31b43eb1 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -245,6 +245,7 @@ obj-$(CONFIG_SENSORS_W83L786NG) += w83l786ng.o > obj-$(CONFIG_SENSORS_WM831X) += wm831x-hwmon.o > obj-$(CONFIG_SENSORS_WM8350) += wm8350-hwmon.o > obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o > +obj-$(CONFIG_SENSORS_YOGAFAN) += yogafan.o > > obj-$(CONFIG_SENSORS_OCC) += occ/ > obj-$(CONFIG_SENSORS_PECI) += peci/ > diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c > new file mode 100644 > index 000000000000..7840492bec72 > --- /dev/null > +++ b/drivers/hwmon/yogafan.c > @@ -0,0 +1,284 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/** > + * yoga_fan.c - Lenovo Yoga/Legion Fan Hardware Monitoring Driver > + * > + * Provides fan speed monitoring for Lenovo Yoga, Legion, and IdeaPad > + * laptops by interfacing with the Embedded Controller (EC) via ACPI. > + * > + * The driver implements a passive discrete-time first-order lag filter > + * with slew-rate limiting (RLLag). This addresses low-resolution > + * tachometer sampling in the EC by smoothing RPM readings based on > + * the time delta (dt) between userspace requests, ensuring physical > + * consistency without background task overhead or race conditions. > + * The filter implements multirate filtering with autoreset in case > + * of large sampling time. > + * > + * Copyright (C) 2021-2026 Sergio Melas > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Add a few empty lines as separators (checkpatch complains about several of those) > +/* Driver Configuration Constants */ > +#define DRVNAME "yogafan" > +#define MAX_FANS 8 > +/* Filter Configuration Constants */ > +#define TAU_MS 1000 /* Time constant for the first-order lag (ms) */ > +#define MAX_SLEW_RPM_S 1500 /* Maximum allowed change in RPM per second */ > +#define MAX_SAMPLING 5000 /* Maximum allowed Ts for reset (ms) */ > +/* RPM Sanitation Constants */ > +#define RPM_FLOOR_LIMIT 50 /* Snap filtered value to 0 if raw is 0 */ Use #defineNAMEvalue > +struct yogafan_config { > + int multiplier; > +}; > +struct yoga_fan_data { > + acpi_handle active_handles[MAX_FANS]; /* Changed from active_paths to handle */ Irrelevant comment. > + long filtered_val[MAX_FANS]; > + ktime_t last_sample[MAX_FANS]; > + int multiplier; > + int fan_count; > +}; > +/* Known hardware configurations based on EC register bit-width */ > +static const struct yogafan_config yoga_8bit_cfg = { .multiplier = 100 }; > +static const struct yogafan_config legion_16bit_cfg = { .multiplier = 1 }; > + > +/** No need to publish this as API. > + * apply_rllag_filter - Discrete-time filter update (Passive Multirate) > + * @data: pointer to driver data > + * @idx: fan index > + * @raw_rpm: new raw value from ACPI > + */ > +static void apply_rllag_filter(struct yoga_fan_data *data, int idx, long raw_rpm) > +{ > + ktime_t now = ktime_get_boottime(); /* Fixed for Suspend/Resume safety */ Irrelevant comment. Essentiall all comments about code changes made throughout the review process are meaningless. You could say here "Use ktime_get_boottime() instead of ktime_get() for for Suspend/Resume safety", which would make it a valuable comment. > + s64 dt_ms = ktime_to_ms(ktime_sub(now, data->last_sample[idx])); > + long delta, step, limit, alpha; > + s64 temp_num; > + if (raw_rpm < RPM_FLOOR_LIMIT) { > + data->filtered_val[idx] = 0; > + data->last_sample[idx] = now; > + return; > + } > + /* Initialize on first run or after long sleep/stall */ > + if (data->last_sample[idx] == 0 || dt_ms > MAX_SAMPLING) { > + data->filtered_val[idx] = raw_rpm; > + data->last_sample[idx] = now; > + return; > + } > + if (dt_ms <= 0) return; Maybe also return if dt_ms is too low to address Saskiko's concern if (dt_ms < ) return; > + delta = raw_rpm - data->filtered_val[idx]; > + if (delta == 0) { > + data->last_sample[idx] = now; > + return; > + } > + /* Alpha with 12-bit precision to prevent alpha=0 on fast polls */ > + temp_num = dt_ms << 12; > + alpha = (long)div64_s64(temp_num, (s64)(TAU_MS + dt_ms)); > + step = (delta * alpha) >> 12; > + /* FIX THE STALL: Force a move of 1 RPM if alpha*delta rounds to zero */ > + if (step == 0 && delta != 0) > + step = (delta > 0) ? 1 : -1; > + /* SLEW RATE LIMITING: Scaled by time delta */ > + limit = (MAX_SLEW_RPM_S * (long)dt_ms) / 1000; > + if (limit < 1) limit = 1; > + /* Clamp step to physical slew rate */ > + if (step > limit) > + step = limit; > + else if (step < -limit) > + step = -limit; > + data->filtered_val[idx] += step; > + data->last_sample[idx] = now; > +} > + > +static int yoga_fan_read(struct device *dev, enum hwmon_sensor_types type, > + u32 attr, int channel, long *val) > +{ > + struct yoga_fan_data *data = dev_get_drvdata(dev); > + unsigned long long raw_acpi; > + acpi_status status; > + if (type != hwmon_fan || attr != hwmon_fan_input) > + return -EOPNOTSUPP; > + /* We use the resolved handle, faster and efficient */ Irrelevant comment. > + status = acpi_evaluate_integer(data->active_handles[channel], NULL, > + NULL, &raw_acpi); > + if (ACPI_FAILURE(status)) > + return -EIO; > + > + apply_rllag_filter(data, channel, (long)raw_acpi * data->multiplier); > + *val = data->filtered_val[channel]; > + return 0; > +} > + > +static umode_t yoga_fan_is_visible(const void *data, enum hwmon_sensor_types type, > + u32 attr, int channel) > +{ > + const struct yoga_fan_data *fan_data = data; > + if (type == hwmon_fan && channel < fan_data->fan_count) > + return 0444; > + return 0; > +} > + > +static const struct hwmon_ops yoga_fan_hwmon_ops = { > + .is_visible = yoga_fan_is_visible, > + .read = yoga_fan_read, > +}; > + > +static const struct hwmon_channel_info *yoga_fan_info[] = { > + HWMON_CHANNEL_INFO(fan, > + HWMON_F_INPUT, HWMON_F_INPUT, HWMON_F_INPUT, HWMON_F_INPUT, > + HWMON_F_INPUT, HWMON_F_INPUT, HWMON_F_INPUT, HWMON_F_INPUT), > + NULL > +}; > + > +static const struct hwmon_chip_info yoga_fan_chip_info = { > + .ops = &yoga_fan_hwmon_ops, > + .info = yoga_fan_info, > +}; > + > +/* Quirk table to map families to multipliers deterministically */ > +static const struct dmi_system_id yogafan_quirks[] = { > + { > + .ident = "Lenovo Yoga", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga"), > + }, > + .driver_data = (void *)&yoga_8bit_cfg, > + }, > + { > + .ident = "Lenovo IdeaPad", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "IdeaPad"), > + }, > + .driver_data = (void *)&yoga_8bit_cfg, > + }, > + { > + .ident = "Lenovo Slim", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "Slim"), > + }, > + .driver_data = (void *)&yoga_8bit_cfg, > + }, > + { > + .ident = "Lenovo Flex", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "Flex"), > + }, > + .driver_data = (void *)&yoga_8bit_cfg, > + }, > + { > + .ident = "Lenovo Legion", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "Legion"), > + }, > + .driver_data = (void *)&legion_16bit_cfg, > + }, > + { > + .ident = "Lenovo LOQ", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_FAMILY, "LOQ"), > + }, > + .driver_data = (void *)&legion_16bit_cfg, > + }, > + { } > +}; > + > +/* > + * MODULE_DEVICE_TABLE registers the DMI quirk table with the kernel's > + * build system. This enables the generation of modaliases, allowing > + * the driver to be automatically loaded (autoloading) by the OS > + * when it detects matching Lenovo hardware. > + */ Unecessary comment. That is implied for each MODULE_DEVICE_TABLE in the system. > +MODULE_DEVICE_TABLE(dmi, yogafan_quirks); > + > +static int yoga_fan_probe(struct platform_device *pdev) > +{ > + const struct dmi_system_id *dmi_id; > + const struct yogafan_config *cfg; > + struct yoga_fan_data *data; > + struct device *hwmon_dev; > + acpi_handle handle; > + int i; > + static const char * const fan_paths[] = { > + "\\_SB.PCI0.LPC0.EC0.FANS", /* Primary Fan (Yoga) */ > + "\\_SB.PCI0.LPC0.EC0.FA2S", /* Secondary Fan (Legion / LOQ) */ > + "\\_SB.PCI0.LPC0.EC0.FAN0", /* IdeaPad / Slim / Flex */ > + "\\_SB.PCI0.LPC.EC.FAN0", /* Legacy (pre-2020 models) */ > + "\\_SB.PCI0.LPC0.EC.FAN0", /* Alternate (Certain Slim/Flex) */ > + }; > + dmi_id = dmi_first_match(yogafan_quirks); > + if (!dmi_id) > + return -ENODEV; > + cfg = dmi_id->driver_data; > + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + data->multiplier = cfg->multiplier; > + data->fan_count = 0; > + for (i = 0; i < ARRAY_SIZE(fan_paths); i++) { > + /* Resolve handles once during probe for better performance */ > + if (ACPI_SUCCESS(acpi_get_handle(NULL, (char *)fan_paths[i], &handle))) { > + data->active_handles[data->fan_count] = handle; > + data->fan_count++; > + if (data->fan_count >= MAX_FANS) > + break; > + } > + } > + > + if (data->fan_count == 0) > + return -ENODEV; > + platform_set_drvdata(pdev, data); I don't think this is needed / used anywhere. > + hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, DRVNAME, > + data, &yoga_fan_chip_info, NULL); > + return PTR_ERR_OR_ZERO(hwmon_dev); > +} > + > +static struct platform_driver yoga_fan_driver = { > + .driver = { > + .name = DRVNAME, > + }, > + .probe = yoga_fan_probe, > +}; > + > +static struct platform_device *yoga_fan_device; > + > +static int __init yoga_fan_init(void) > +{ > + int ret; > + > + if (!dmi_check_system(yogafan_quirks)) > + return -ENODEV; > + ret = platform_driver_register(&yoga_fan_driver); > + if (ret) > + return ret; > + yoga_fan_device = platform_device_register_simple(DRVNAME, 0, NULL, 0); > + if (IS_ERR(yoga_fan_device)) { > + platform_driver_unregister(&yoga_fan_driver); > + return PTR_ERR(yoga_fan_device); > + } > + return 0; > +} > + > +static void __exit yoga_fan_exit(void) > +{ > + platform_device_unregister(yoga_fan_device); > + platform_driver_unregister(&yoga_fan_driver); > +} > + > +module_init(yoga_fan_init); > +module_exit(yoga_fan_exit); > + > +MODULE_AUTHOR("Sergio Melas "); > +MODULE_DESCRIPTION("Lenovo Yoga/Legion Fan Monitor Driver"); > +MODULE_LICENSE("GPL");