From: "Moger, Babu" <babu.moger@amd.com>
To: "Yu, Fenghua" <fenghua.yu@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Eranian, Stephane" <eranian@google.com>,
"peternewman@google.com" <peternewman@google.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: Re: [RFC PATCH 3/3] x86/resctrl: Display the RMID and COSID for resctrl groups
Date: Thu, 5 Jan 2023 09:48:03 -0600 [thread overview]
Message-ID: <d6bab266-c87a-0fec-443a-f608714d7e0b@amd.com> (raw)
In-Reply-To: <IA1PR11MB6097E141C8C207EA527B992D9BF59@IA1PR11MB6097.namprd11.prod.outlook.com>
Hi Fenghua,
On 1/4/23 17:54, Yu, Fenghua wrote:
> Hi, Babu,
>
>>>> When a user creates a control or monitor group, the CLOSID or RMID
>>>> are not visible to the user. These are architecturally defined entities.
>>>> There is no harm in displaying these in resctrl groups. Sometimes it
>>>> can help to debug the issues.
>>> Although "no harm" to show them, it's not useful for generic user
>>> either and may cause confusion sometimes. CLOSID and RMID are supposed
>>> to be invisible to generic users.
>>>
>>> Maybe introduce a new resctrl mount option called "debug" and show the
>>> files and maybe other future debug info only in debug mode?
>> Actually, test team feels very strongly about this. Whenever there is some issue,
>> first question is what is the rmid or closid are you running on? We normally don't
>> have an answer for that.
>>
>> In my opinion, adding debug mode just for these two fields seems way overkill.
> Yes, they are useful for "test team" (quoted from your statement) and developers.
> Not for end users.
>
> A debug mode is useful not just for these two files. I'm working on another resctrl
> project where much more complex hardware info needs to be dumped for debug purpose
> only. It's obvious not to show it in generic use. It's more obvious to just show the info file in
> debug mode in my case.
>
> I think these CLOSID and RMID files and future debug files belong to a new debug mode.
> It would be better to introduce the debug mode now rather than later so that it can be extended
> easily in the future.
>
> Maybe we can enable debug mode in a separate debug mode patch:
> 1. Add RFTYPE_DEBUG as a new file type. Files with this flag are for debug purpose and only be visible in\
> debug mode.
> 2. Add RFTYPE_INVISIBLE as a new file type. Files with this flag will be invisible/not be added in resctrl fs.
> 3. Add mount parameter "debug" so that ctx->debug=true if mount -o debug is given.
> 4. If ctx->debug is true, in rdt_enable_ctx(), go through RFTYPE_DEBUG files in res_common_files[] and mark
> fflags with RFTYPE_INVISIBLE.
> 5. In rdtgroup_add_file(), if (rft->fflags & RFTYPE_INVISIBLE) return. So the debug files will be visible only
> in debug mode.
>
> With the debug mode patch in place, it's simple to extend to any debug files:
> In your case, update this patch by just adding RFTYPE_DEBUG in fflags. Then the debug mode will work
> for this patch automatically.
> In my case or any future debug files, we just simply add RFTYPE_DEBUG in fflags and the debug mode will
> work automatically.
>
> Does it make sense?
Yes. Sure. The debug mode needs to be resctrl mount option. I will take a
look at this further to see what can be done.
Thanks
Babu
prev parent reply other threads:[~2023-01-05 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 22:06 [RFC PATCH 0/3] x86/resctrl: Miscellaneous resctrl features Babu Moger
2023-01-03 22:06 ` [RFC PATCH 1/3] x86/resctrl: Add multiple tasks to the resctrl group at once Babu Moger
2023-01-04 5:46 ` Yu, Fenghua
2023-01-04 17:20 ` Moger, Babu
2023-01-03 22:06 ` [RFC PATCH 2/3] x86/resctrl: Move the task's threads to the group automatically Babu Moger
2023-01-04 5:55 ` Yu, Fenghua
2023-01-04 17:49 ` Moger, Babu
2023-01-04 16:43 ` Reinette Chatre
2023-01-04 18:06 ` Moger, Babu
2023-01-03 22:06 ` [RFC PATCH 3/3] x86/resctrl: Display the RMID and COSID for resctrl groups Babu Moger
2023-01-04 6:06 ` Yu, Fenghua
2023-01-04 6:45 ` Stephane Eranian
2023-01-04 18:01 ` Moger, Babu
2023-01-04 17:58 ` Moger, Babu
2023-01-04 23:54 ` Yu, Fenghua
2023-01-05 15:48 ` Moger, Babu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6bab266-c87a-0fec-443a-f608714d7e0b@amd.com \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®