From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD98AC433F5 for ; Tue, 17 May 2022 04:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236571AbiEQE4u (ORCPT ); Tue, 17 May 2022 00:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233459AbiEQE4q (ORCPT ); Tue, 17 May 2022 00:56:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 00EC4344ED for ; Mon, 16 May 2022 21:56:44 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FC0BED1; Mon, 16 May 2022 21:56:44 -0700 (PDT) Received: from [10.162.43.9] (unknown [10.162.43.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 45C033F718; Mon, 16 May 2022 21:56:40 -0700 (PDT) Message-ID: Date: Tue, 17 May 2022 10:26:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] x86: removed P*D_PAGE_MASK and P*D_PAGE_SIZE Content-Language: en-US To: Pasha Tatashin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, peterz@infradead.org, logang@deltatee.com References: <20220516185202.604654-1-tatashin@google.com> From: Anshuman Khandual In-Reply-To: <20220516185202.604654-1-tatashin@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/22 00:22, Pasha Tatashin wrote: > From: Pasha Tatashin > > Other architectures and the common mm/ use P*D_MASK, and P*D_SIZE. > Remove the duplicated P*D_PAGE_MASK and P*D_PAGE_SIZE which are only > used in x86/*. > > Signed-off-by: Pasha Tatashin > --- > > Applies against next-20220516 that contains: > mm: page_table_check: using PxD_SIZE instead of PxD_PAGE_SIZ Right, had discussed about this earlier during the page table check series. Does make sense to use standard PMD_SIZE/PUD_SIZE like other platforms and also the generic MM. FWIW Reviewed-by: Anshuman Khandual