From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Danila Tikhonov <danila@mainlining.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kate Hsuan <hpa@redhat.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Eugene Lepshy <fekz115@gmail.com>,
Vasiliy Doylov <neko@altlinux.org>,
Achill Gilgenast <achill@achill.org>,
Luca Weiss <luca.weiss@fairphone.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm7325-nothing-spacewar: Add front camera support
Date: Tue, 18 Aug 2026 14:38:49 +0200 [thread overview]
Message-ID: <d6c0ac1a-11d0-4179-be33-7a6a4da7ef22@oss.qualcomm.com> (raw)
In-Reply-To: <20260805-imx471-v1-4-7be79f539ed8@mainlining.org>
On 8/5/26 9:54 PM, Danila Tikhonov wrote:
> Add and configure the necessary nodes to enable the front camera
> (Sony IMX471), connected to CSIPHY 0.
>
> Signed-off-by: Danila Tikhonov <danila@mainlining.org>
> ---
[...]
> &cci0_i2c0 {
> - /* D-PHY sony,imx471 (Front) @ 0x1a */
> + camf_imx471: camera@1a {
> + compatible = "sony,imx471";
> + reg = <0x1a>;
> +
> + vana-supply = <&vreg_camf_vana_2p8>;
> + vdig-supply = <&vreg_camf_vdig_1p1>;
> + vif-supply = <&vreg_cam_vio_1p8>;
> +
> + clocks = <&camcc CAM_CC_MCLK0_CLK>;
> + assigned-clocks = <&camcc CAM_CC_MCLK0_CLK>;
> + assigned-clock-rates = <19200000>;
> +
> + reset-gpios = <&tlmm 20 GPIO_ACTIVE_LOW>;
> + pinctrl-0 = <&cam_mclk0_default>;
> + pinctrl-names = "default";
Don't you want to also configure the reset pinmux/cfg?
> +
> + orientation = <0>; /* Front facing */
Please incorporate
https://lore.kernel.org/lkml/20260804-kbingham-orientation-v4-0-336998dd63b4@ideasonboard.com/
Konrad
prev parent reply other threads:[~2026-08-18 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 19:54 [PATCH 0/4] Add front-facing camera support for Nothing Phone (1) Danila Tikhonov
2026-08-05 19:54 ` [PATCH 1/4] dt-bindings: media: i2c: Add Sony IMX471 CMOS Image Sensor Danila Tikhonov
2026-08-06 10:33 ` Sakari Ailus
2026-08-12 2:10 ` Rob Herring
2026-08-05 19:54 ` [PATCH 2/4] drivers: media: i2c: imx471: Add vdig and vif power supplies Danila Tikhonov
2026-08-05 19:54 ` [PATCH 3/4] drivers: media: i2c: imx471: Add Device Tree matching support Danila Tikhonov
2026-08-05 19:54 ` [PATCH 4/4] arm64: dts: qcom: sm7325-nothing-spacewar: Add front camera support Danila Tikhonov
2026-08-18 12:38 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c0ac1a-11d0-4179-be33-7a6a4da7ef22@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=achill@achill.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danila@mainlining.org \
--cc=devicetree@vger.kernel.org \
--cc=fekz115@gmail.com \
--cc=hpa@redhat.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=neko@altlinux.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®