From: Florian Fainelli <f.fainelli@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
davem@davemloft.net, kuba@kernel.org
Cc: alexander.duyck@gmail.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Aaron Brown <aaron.f.brown@intel.com>,
Michal Kubecek <mkubecek@suse.cz>, Andrew Lunn <andrew@lunn.ch>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ethtool: Report speed and duplex as unknown when device is runtime suspended
Date: Thu, 26 Mar 2020 19:56:29 -0700 [thread overview]
Message-ID: <d6c5a1c4-e41f-d239-e0b0-15eba3e78274@gmail.com> (raw)
In-Reply-To: <20200327024552.22170-1-kai.heng.feng@canonical.com>
On 3/26/2020 7:45 PM, Kai-Heng Feng wrote:
> Device like igb gets runtime suspended when there's no link partner. We
> can't get correct speed under that state:
> $ cat /sys/class/net/enp3s0/speed
> 1000
>
> In addition to that, an error can also be spotted in dmesg:
> [ 385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost
>
> Since device can only be runtime suspended when there's no link partner,
> we can directly report the speed and duplex as unknown.
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Aaron Brown <aaron.f.brown@intel.com>
> Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
I would push this to the responsibility of the various drivers instead
of making this part of the standard ethtool implementation.
--
Florian
next prev parent reply other threads:[~2020-03-27 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 2:45 Kai-Heng Feng
2020-03-27 2:56 ` Florian Fainelli [this message]
2020-03-27 3:11 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c5a1c4-e41f-d239-e0b0-15eba3e78274@gmail.com \
--to=f.fainelli@gmail.com \
--cc=aaron.f.brown@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome