mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shijie001@208suo.com
To: andrii@kernel.org, shuah@kernel.org, daniel@iogearbox.net
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] selftests/bpf: Fix errors in btf_write.c
Date: Mon, 17 Jul 2023 15:44:48 +0800	[thread overview]
Message-ID: <d6c64a42ab574440465b0f593e9f8606@208suo.com> (raw)
In-Reply-To: <tencent_295B25ACBCCB13A3F7B08D2739F90CFFC307@qq.com>

The following checkpatch errors are removed:
ERROR: Bad function definition - void test_btf_add() should probably be 
void test_btf_add(void)
ERROR: Bad function definition - void test_btf_add_btf() should probably 
be void test_btf_add_btf(void)
ERROR: Bad function definition - void test_btf_write() should probably 
be void test_btf_write(void)

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  tools/testing/selftests/bpf/prog_tests/btf_write.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/btf_write.c 
b/tools/testing/selftests/bpf/prog_tests/btf_write.c
index 6e36de1302fc..209a230ffeec 100644
--- a/tools/testing/selftests/bpf/prog_tests/btf_write.c
+++ b/tools/testing/selftests/bpf/prog_tests/btf_write.c
@@ -352,7 +352,7 @@ static void gen_btf(struct btf *btf)
               "\t'v1' val=18446744073709551615", "raw_dump");
  }

-static void test_btf_add()
+static void test_btf_add(void)
  {
      struct btf *btf;

@@ -401,7 +401,7 @@ static void test_btf_add()
      btf__free(btf);
  }

-static void test_btf_add_btf()
+static void test_btf_add_btf(void)
  {
      struct btf *btf1 = NULL, *btf2 = NULL;
      int id;
@@ -497,7 +497,7 @@ static void test_btf_add_btf()
      btf__free(btf2);
  }

-void test_btf_write()
+void test_btf_write(void)
  {
      if (test__start_subtest("btf_add"))
          test_btf_add();

           reply	other threads:[~2023-07-17  7:45 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tencent_295B25ACBCCB13A3F7B08D2739F90CFFC307@qq.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6c64a42ab574440465b0f593e9f8606@208suo.com \
    --to=shijie001@208suo.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®