From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AEEAC433E0 for ; Tue, 11 Aug 2020 14:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 533022076B for ; Tue, 11 Aug 2020 14:24:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="Lfx08Qt+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728874AbgHKOYR (ORCPT ); Tue, 11 Aug 2020 10:24:17 -0400 Received: from vern.gendns.com ([98.142.107.122]:52068 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728516AbgHKOYP (ORCPT ); Tue, 11 Aug 2020 10:24:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oIA0SyQnQE6LeBoO3UYT2PDngqxzggBNJbCObD6n2q8=; b=Lfx08Qt+MeBHxgRUy0m2UggxMN 9ugPaumHTtk3FXe5JTqa0XX+QMdfwf2icygQD2vwJtlqPhWN/UofXH57nh9SSOru1upy7TcBJP0cm 6BP8X3TQxfgDxwSXNBlrlCYv7nx4u82Qgq7g6zuPVzhyc1GJ8J/Bqnbtxeid0jbip8mLmYvIQ1FDj XpuYD3yzrbqWM6FBKfU4ziAPh5c9XyGF/BjMTbtrPVKFynWUB3cnrtBfJh9vfA13Y7Pcr4Z9BYzHG ipeJxbPQPBhLXc1WY17lA1bpnTyApGg/JzWzMw/6AkeMyUeuXwsQCaPdm82d9a/Yaw1wjCmAXphNr LS+qXS4g==; Received: from [2600:1700:4830:165f::19e] (port=38386) by vern.gendns.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k5VCG-0003uQ-O8; Tue, 11 Aug 2020 10:24:12 -0400 Subject: Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options To: Alex Dewar , Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200809185444.54247-1-alex.dewar90@gmail.com> Cc: Sekhar Nori , =?UTF-8?Q?Bartosz_Go=c5=82aszewski?= From: David Lechner Message-ID: Date: Tue, 11 Aug 2020 09:24:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200809185444.54247-1-alex.dewar90@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/9/20 1:54 PM, Alex Dewar wrote: > This battery appears only to be used by a single board (DA850), so it > makes sense to add this to the Kconfig file so that users don't build > the module unnecessarily. It currently seems to be built for the x86 > Arch Linux kernel where it's probably not doing much good. It would probably also make sense to add "default n" since it only applies to one board in the entire arch. BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate defconfig file, so I don't think it would break anything. > > Signed-off-by: Alex Dewar > --- > drivers/power/supply/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index faf2830aa1527..9f76e2f47ac6d 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -164,7 +164,7 @@ config BATTERY_DS2782 > > config BATTERY_LEGO_EV3 > tristate "LEGO MINDSTORMS EV3 battery" > - depends on OF && IIO && GPIOLIB > + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST) > help > Say Y here to enable support for the LEGO MINDSTORMS EV3 battery. > >