From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbdKWUFb (ORCPT ); Thu, 23 Nov 2017 15:05:31 -0500 Received: from mout.web.de ([212.227.15.3]:50468 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbdKWUFa (ORCPT ); Thu, 23 Nov 2017 15:05:30 -0500 Subject: [PATCH 1/3] ASoC: da7218: Delete two error messages for a failed memory allocation in da7218_of_to_pdata() From: SF Markus Elfring To: alsa-devel@alsa-project.org, support.opensource@diasemi.com, Adam Thomson , Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: <07c631e4-e2df-7ae2-ea31-9430c89dc8e3@users.sourceforge.net> Message-ID: Date: Thu, 23 Nov 2017 21:04:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <07c631e4-e2df-7ae2-ea31-9430c89dc8e3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:xl9wjEqE9zcsY80EMgeL+H/I5w6XGZolvcUGHrz6hn/y665X3VT fTD3Um7J7Xs22p21gkvC3WeMp645H9R+IyNa7jY+zd+APdUJ7mPe4tYrqoE05Pd6DkqY3PG M7iKFAauIbF0Isweb1ybccxctT1FgBojvLctGVOHFZPYV4t1+WmObvmG4W1S37u3yhdgnik ZkaG+1MLQBtrdrJn7EdQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:8k12kKZc+lg=:w0zFS9VQUTF/U43rvSsej+ R/ZFnc/lt/SyslgmDnEOVcn3dZzn8UmMn1D2rNTbntzIjtKnP7b9+KhV7PCZGKUMkf8xWLBAu XGFoSzRmPkCOel1bAK1XftZ+kU6MchdszauDfj9llANRp9/KPAkubof87ShfuMCIXt3Gw3Kiv CRgQBufFg7nKRBUnP1YaxqcvLRjMNE+UbN3FB1sOl7C5lRgRCBlCZ8b3gDX1f04dLns6xyycM XA7sLat/cbZO5aRK5xhdgLGnCfZEyYGChCQUjG+pSOt+8CXsKMltYZvG7sBKFSn5y8pIkJLTH tHJ/H1AR6l/SvXwcxpZJ80hh6X5o2Bdbp2ifYJKNq4bWpKdn+ytaUgadLpW2Hh4Ljo+sNssdH 1pZYKb9jcZkWw7amVKor9b2nbmzpIUnWSKejDJ3mAs7o8uOoLZQyPc+wZEXYUVxIdbbTTsjjB WTb4a4WQCOWs2RiDuTKCniuWlAM9mTGACDurpzs09dVd/yTh5jh3lrIT61QAetiT8NgC+s4zx adjqmKZ2gAqrzM3Vs/hu052UBOwQMkRJfgguohTaQLhfHndQ79iSyE4unDRZ38mswzXj/F/Sb Son6DTAe0VgPyp02jkBbP+ZMfhC45uaR9Az0QvO1J8jNMnQmVxtU9O+i8/maHYX8V4jIOKcs8 ZEz3kH7fRK9XGm1NsRSDT4voXHjDwbV+51W1PdFJf8zHOz6loy+Z9lMvPRR9d58Mc6eRJGbXb bfuI3/iDd1l2kkfpqRGM63l5Vd68F8WNQwjZxgf+rH0tbPB7e/vdg3Vc7u04Sz0a8DOdmov4X +M9Ee9qu/BFrmA1t7mQzj4T2hwvweGb2mlsOp/z5rag3PX7xJg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 23 Nov 2017 20:42:20 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/da7218.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index 56564ce90cb6..25ab7443d803 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -2455,10 +2455,8 @@ static struct da7218_pdata *da7218_of_to_pdata(struct snd_soc_codec *codec) u32 of_val32; pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL); - if (!pdata) { - dev_warn(codec->dev, "Failed to allocate memory for pdata\n"); + if (!pdata) return NULL; - } if (of_property_read_u32(np, "dlg,micbias1-lvl-millivolt", &of_val32) >= 0) pdata->micbias1_lvl = da7218_of_micbias_lvl(codec, of_val32); @@ -2527,8 +2525,6 @@ static struct da7218_pdata *da7218_of_to_pdata(struct snd_soc_codec *codec) hpldet_pdata = devm_kzalloc(codec->dev, sizeof(*hpldet_pdata), GFP_KERNEL); if (!hpldet_pdata) { - dev_warn(codec->dev, - "Failed to allocate memory for hpldet pdata\n"); of_node_put(hpldet_np); return pdata; } -- 2.15.0