From: Tom Lendacky <thomas.lendacky@amd.com>
To: <linux-kernel@vger.kernel.org>, <x86@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"H. Peter Anvin" <hpa@zytor.com>,
Michael Roth <michael.roth@amd.com>,
Joerg Roedel <jroedel@suse.de>,
Dionna Glaze <dionnaglaze@google.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v9 3/6] x86/sev: Allow for use of the early boot GHCB for PSC requests
Date: Tue, 6 Jun 2023 09:51:24 -0500 [thread overview]
Message-ID: <d6cbb21f87f81eb8282dd3bf6c34d9698c8a4bbc.1686063086.git.thomas.lendacky@amd.com> (raw)
In-Reply-To: <cover.1686063086.git.thomas.lendacky@amd.com>
Using a GHCB for a page stage change (as opposed to the MSR protocol)
allows for multiple pages to be processed in a single request. In prep
for early PSC requests in support of unaccepted memory, update the
invocation of vmgexit_psc() to be able to use the early boot GHCB and not
just the per-CPU GHCB structure.
In order to use the proper GHCB (early boot vs per-CPU), set a flag that
indicates when the per-CPU GHCBs are available and registered. For APs,
the per-CPU GHCBs are created before they are started and registered upon
startup, so this flag can be used globally for the BSP and APs instead of
creating a per-CPU flag. This will allow for a significant reduction in
the number of MSR protocol page state change requests when accepting
memory.
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
arch/x86/kernel/sev.c | 61 +++++++++++++++++++++++++++----------------
1 file changed, 38 insertions(+), 23 deletions(-)
diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index 7b0144acd7bf..973756c89dac 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -119,7 +119,19 @@ static DEFINE_PER_CPU(struct sev_es_save_area *, sev_vmsa);
struct sev_config {
__u64 debug : 1,
- __reserved : 63;
+
+ /*
+ * A flag used by __set_pages_state() that indicates when the
+ * per-CPU GHCB has been created and registered and thus can be
+ * used by the BSP instead of the early boot GHCB.
+ *
+ * For APs, the per-CPU GHCB is created before they are started
+ * and registered upon startup, so this flag can be used globally
+ * for the BSP and APs.
+ */
+ ghcbs_initialized : 1,
+
+ __reserved : 62;
};
static struct sev_config sev_cfg __read_mostly;
@@ -662,7 +674,7 @@ static void pvalidate_pages(unsigned long vaddr, unsigned long npages, bool vali
}
}
-static void __init early_set_pages_state(unsigned long paddr, unsigned long npages, enum psc_op op)
+static void early_set_pages_state(unsigned long paddr, unsigned long npages, enum psc_op op)
{
unsigned long paddr_end;
u64 val;
@@ -756,26 +768,13 @@ void __init snp_prep_memory(unsigned long paddr, unsigned int sz, enum psc_op op
WARN(1, "invalid memory op %d\n", op);
}
-static int vmgexit_psc(struct snp_psc_desc *desc)
+static int vmgexit_psc(struct ghcb *ghcb, struct snp_psc_desc *desc)
{
int cur_entry, end_entry, ret = 0;
struct snp_psc_desc *data;
- struct ghcb_state state;
struct es_em_ctxt ctxt;
- unsigned long flags;
- struct ghcb *ghcb;
- /*
- * __sev_get_ghcb() needs to run with IRQs disabled because it is using
- * a per-CPU GHCB.
- */
- local_irq_save(flags);
-
- ghcb = __sev_get_ghcb(&state);
- if (!ghcb) {
- ret = 1;
- goto out_unlock;
- }
+ vc_ghcb_invalidate(ghcb);
/* Copy the input desc into GHCB shared buffer */
data = (struct snp_psc_desc *)ghcb->shared_buffer;
@@ -832,20 +831,18 @@ static int vmgexit_psc(struct snp_psc_desc *desc)
}
out:
- __sev_put_ghcb(&state);
-
-out_unlock:
- local_irq_restore(flags);
-
return ret;
}
static void __set_pages_state(struct snp_psc_desc *data, unsigned long vaddr,
unsigned long vaddr_end, int op)
{
+ struct ghcb_state state;
struct psc_hdr *hdr;
struct psc_entry *e;
+ unsigned long flags;
unsigned long pfn;
+ struct ghcb *ghcb;
int i;
hdr = &data->hdr;
@@ -875,8 +872,20 @@ static void __set_pages_state(struct snp_psc_desc *data, unsigned long vaddr,
i++;
}
- if (vmgexit_psc(data))
+ local_irq_save(flags);
+
+ if (sev_cfg.ghcbs_initialized)
+ ghcb = __sev_get_ghcb(&state);
+ else
+ ghcb = boot_ghcb;
+
+ if (!ghcb || vmgexit_psc(ghcb, data))
sev_es_terminate(SEV_TERM_SET_LINUX, GHCB_TERM_PSC);
+
+ if (sev_cfg.ghcbs_initialized)
+ __sev_put_ghcb(&state);
+
+ local_irq_restore(flags);
}
static void set_pages_state(unsigned long vaddr, unsigned long npages, int op)
@@ -884,6 +893,10 @@ static void set_pages_state(unsigned long vaddr, unsigned long npages, int op)
unsigned long vaddr_end, next_vaddr;
struct snp_psc_desc desc;
+ /* Use the MSR protocol when a GHCB is not available. */
+ if (!boot_ghcb)
+ return early_set_pages_state(__pa(vaddr), npages, op);
+
vaddr = vaddr & PAGE_MASK;
vaddr_end = vaddr + (npages << PAGE_SHIFT);
@@ -1261,6 +1274,8 @@ void setup_ghcb(void)
if (cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
snp_register_per_cpu_ghcb();
+ sev_cfg.ghcbs_initialized = true;
+
return;
}
--
2.40.1
next prev parent reply other threads:[~2023-06-06 14:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:26 [PATCHv14 0/9] mm, x86/cc, efi: Implement support for unaccepted memory Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 1/9] mm: Add " Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 2/9] efi/x86: Get full memory map in allocate_e820() Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 3/9] efi/libstub: Implement support for unaccepted memory Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 4/9] x86/boot/compressed: Handle " Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 5/9] efi: Add unaccepted memory support Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-07-03 13:25 ` [PATCHv14 5/9] " Mel Gorman
2023-07-04 14:37 ` Kirill A. Shutemov
2023-07-12 9:18 ` Mel Gorman
2023-10-10 21:05 ` Michael Roth
2023-10-13 12:33 ` Kirill A. Shutemov
2023-10-13 16:22 ` Kirill A. Shutemov
2023-10-13 16:44 ` Vlastimil Babka
2023-10-13 17:27 ` Kirill A. Shutemov
2023-10-13 21:54 ` Kirill A. Shutemov
2023-10-13 17:45 ` Tom Lendacky
2023-10-13 19:53 ` Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 6/9] efi/unaccepted: Avoid load_unaligned_zeropad() stepping into unaccepted memory Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 7/9] x86/tdx: Make _tdx_hypercall() and __tdx_module_call() available in boot stub Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 8/9] x86/tdx: Refactor try_accept_one() Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:26 ` [PATCHv14 9/9] x86/tdx: Add unaccepted memory support Kirill A. Shutemov
2023-06-06 19:42 ` [tip: x86/cc] " tip-bot2 for Kirill A. Shutemov
2023-06-06 14:51 ` [PATCH v9 0/6] Provide SEV-SNP support for unaccepted memory Tom Lendacky
2023-06-06 14:51 ` [PATCH v9 1/6] x86/sev: Fix calculation of end address based on number of pages Tom Lendacky
2023-06-06 14:51 ` [PATCH v9 2/6] x86/sev: Put PSC struct on the stack in prep for unaccepted memory support Tom Lendacky
2023-06-06 14:51 ` Tom Lendacky [this message]
2023-06-06 14:51 ` [PATCH v9 4/6] x86/sev: Use large PSC requests if applicable Tom Lendacky
2023-06-06 14:51 ` [PATCH v9 5/6] x86/sev: Add SNP-specific unaccepted memory support Tom Lendacky
2023-09-06 14:04 ` Christopher Schramm
2023-09-07 16:50 ` Tom Lendacky
2023-09-12 12:17 ` Kirill A. Shutemov
2023-09-12 14:49 ` Tom Lendacky
2023-06-06 14:51 ` [PATCH v9 6/6] x86/efi: Safely enable unaccepted memory in UEFI Tom Lendacky
2023-06-06 15:39 ` Ard Biesheuvel
2023-06-06 16:16 ` [PATCHv14 0/9] mm, x86/cc, efi: Implement support for unaccepted memory Borislav Petkov
2023-06-06 16:25 ` Borislav Petkov
2023-06-06 18:14 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6cbb21f87f81eb8282dd3bf6c34d9698c8a4bbc.1686063086.git.thomas.lendacky@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®