From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751307AbeFDQVT (ORCPT ); Mon, 4 Jun 2018 12:21:19 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:33796 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbeFDQVS (ORCPT ); Mon, 4 Jun 2018 12:21:18 -0400 X-Google-Smtp-Source: ADUXVKKPQc2C+/9OzAyevoLcTmZSd52c3yDZGNDWOz/v7gZQMfNevZ4cxuB//QEPL5vHmdFE/EFouw== Subject: Re: [PATCH] blk-mq: return when BLK_MQ_S_STOPPED in blk_mq_run_work_fn To: Jianchao Wang , ming.lei@redhat.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <1528103035-8009-1-git-send-email-jianchao.w.wang@oracle.com> From: Jens Axboe Message-ID: Date: Mon, 4 Jun 2018 10:21:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1528103035-8009-1-git-send-email-jianchao.w.wang@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/18 3:03 AM, Jianchao Wang wrote: > if hctx is stopped, don't run the queue in blk_mq_run_work_fn. I was puzzled, so had to look up those changes. That's definitely a regression caused by 15fe8a9, as you highlighted. Looks good to me, I'll apply it. BTW, this should have been explained in the commit message. I'll change it a bit. -- Jens Axboe