From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbbIXIkg (ORCPT ); Thu, 24 Sep 2015 04:40:36 -0400 Received: from mail-bn1bbn0108.outbound.protection.outlook.com ([157.56.111.108]:4965 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751492AbbIXIk2 (ORCPT ); Thu, 24 Sep 2015 04:40:28 -0400 X-Greylist: delayed 67845 seconds by postgrey-1.27 at vger.kernel.org; Thu, 24 Sep 2015 04:40:27 EDT Authentication-Results: spf=pass (sender IP is 206.191.229.116) smtp.mailfrom=microsoft.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=microsoft.com; From: Dexuan Cui To: "dedekind1@gmail.com" , Tejun Heo CC: "Theodore Ts'o" , "axboe@kernel.dk" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "lizefan@huawei.com" , "cgroups@vger.kernel.org" , "hannes@cmpxchg.org" , "kernel-team@fb.com" , "adilger.kernel@dilger.ca" , "linux-ext4@vger.kernel.org" Subject: RE: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Thread-Topic: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Thread-Index: AQHQ9qBmnbilcXm9dEiG5ttU/PCisZ5LW24A Date: Thu, 24 Sep 2015 08:40:18 +0000 Message-ID: References: <1434495193-31182-1-git-send-email-tj@kernel.org> <1434495193-31182-3-git-send-email-tj@kernel.org> <20150722035620.GD2944@thunk.org> <1443012552.19983.209.camel@gmail.com> <20150923180934.GE26647@mtj.duckdns.org> <20150923185137.GJ26647@mtj.duckdns.org> <20150923210729.GA23180@mtj.duckdns.org> <1443082186.19983.234.camel@gmail.com> In-Reply-To: <1443082186.19983.234.camel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [141.251.58.69] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD010;1:jWC3KTFJslAyWaVWOZK4Cm06cN2D+CHZ3XwMWunnDMaOZRH3I99kGonKdu7G0bUZHcRUd4CrqpSZ2+c45k2BWVSD0Ud28MB75ppVvVzRSMJu4rc5w+D5YCZgLpZHWQcEFFq34Yxx6zHzpCNNP0RRQO/saSlKulbNBKasu4D6DQ/ZABdL3bQgOj2wQUeQfr1+pSnkFrIWCdm6UMfHsMR2MskMCUoRy3gkONis4fWcKIBW6EVMb6BoXdTcgt5jd7F6pzjicK4cJo5MbFmFz450JeXaA4JdtCVVFexzyfmmBoVT0DfSrB59OOOBe6P+ObD2VDiOsPniz7vBhAOEambfdt2kePZ27uRT+sZ3ACNBLDA= X-Forefront-Antispam-Report: CIP:206.191.229.116;CTRY:US;IPV:CAL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(438002)(24454002)(199003)(377424004)(189002)(62966003)(77156002)(68736005)(86362001)(16796002)(106116001)(106466001)(86612001)(10400500002)(5005710100001)(10290500002)(11100500001)(24736003)(5004730100002)(76176999)(2501003)(54356999)(102836002)(50986999)(19580405001)(23676002)(19580395003)(69596002)(33646002)(26826002)(86146001)(50466002)(64706001)(47776003)(10090500001)(66066001)(97736004)(5001830100001)(5001770100001)(5001860100001)(4001540100001)(81156007)(108616004)(5007970100001)(6806005)(5003600100002)(92566002)(2950100001)(2900100001)(5001960100002)(5001920100001)(189998001)(46102003)(93886004)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB357;H:064-smtp-out.microsoft.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB357;2:y+XYjn2RLVSzeVRXR0I7CAsQGKRGd/IhenUspJQDhZnk87RddXFycfav59RJOGG7Y4IdpHs4TK2nHQYOSVRFVX1Va1gnkaKZ6+NbcVuLl2mYx1LmWk7UaKTsS8oVarmeqf9HVdGhtYlApj+2v6lMoy0eAqO6ZrfajUIEkBffY+c=;3:uOHVNx6KzgwED5x8Xz5ASZP6FNTdR3lQ+cBhlCzzZoeBkUw2Ppg2DVvtvpNtpR/s4JF013UnyFjrWM+OEmxIgkoEO+/4O9Qcn8dJ3NP6xgEL3n3v2L51pJzvPe2zAeicKvoZoA4I7Alw47x7Bxb088JEWuu4ky7feW1iOwK0JQMKIc/Ljz8gf0DnubsrNiC0YcwztZwrMnnkFyfhjSzZIHLUe/IXYhM4E0ieVxjDZFrBM3wlN1XBKjTLurHH0TWcqlaZztLtGxgw16//42sWOA==;25:yadNrFhOR2s5gjOhHBKBfIsuw7aiaIQfcJSMmQkhl43c5VqYRp/ahhMl0cI/HW//8Xo7xrv/n4QJvhc5Ur741YppDtGqswxhT6IFaVsNZRPkwpetueFYQq2otKXqFs1q13n/Iz6Aje2t/x9yOie74UIClaf5N2/OrA0KR3G3h+jMZvxZxir57yud1vOwXkCVp3p7mbvVOBMCClB/il2byGmj7CNIxaDldvv2qXji1NesQL7UAXl2ieeV2A3l9bkMzVtKqzo+nGKvb7hu24izkA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BLUPR03MB357; X-O365EOP-Header: O365_EOP: AllowList from IP - set SCL to -1 X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB357;20:BwZaV3oKB9tqTX+VSkFc/J72gv7yHnq0k4ZUDJq5+wHDp9tzKYBUAMZztUTE4DkDAes8lozab/3vQ9dvh3YTdZuYJexPjfFrSjsVZ5LBfD4fEt7inGAYULKLENDXCkZtNiQO0FxktnAIEtBQfxEaW8Mba5u2NbmqA6TFHbOz779PpW1IgIVnhzIH1e94nKBgoDNrRyRc3oOr1QkoulzqQJmquX52aZFNLZAgxh33p3p68usshzcKUfe9OXR7RMJ8rgUvB9B1uCgYwZ+GWBfYnhaysK2Q5B3qvDs0P+R+wF2PnH5tNRqqqiUC1cHzc0JocO7u7zmHXFaMTKiyIPM4l/GZgGSTwCf6+jcqlMki4B/khck5jRKwfOvczeDYCpqb51q0LidwgnfCnTzk9uYAIIyLUBt/9jVHNVz1xoTbsHTOni4F5Kf7zCrIReivQLYeT38qb74CYxAeHYHFHgzlyNqUo/y8woZlBF3b1WgXkF7LSvTVhJ5u7N+SwY1pBypunHL0wYW4pnA6IM8bvgF+c8APuoByTLc8qLwF9SfmSUwzSnfpVokSrDuatZci1EtkO0JeOdMtdRm9ro0jtWSqO536MrgFAp5QbXwpZE4JJOQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(108003899814671); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(61425024)(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(61426024)(61427024);SRVR:BLUPR03MB357;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB357; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB357;4:mDQH/+1w+iCGIj53eVNfBRViTLufiDgeUdwPsyTl1/hju9u9XtYsvZYDfF0MgBAgk/LHy0BYiWJfGRXZJgEWoIdZC9jHIEhYxZq/k5DhQ3uJx/gsUYkh92ZsT1VPhIDcPu/5JsXDIpfPSiSOb2yDThl9B5IAfzHDQApsWxyS7I6P7G+Ik1VBflnfXd7qMV6F/ETbAcKp7s6FnvKqWX+mT2xJCHCXttTnqF9OcovjaFr0jNLbjZY9IYfVUhEgsmexV2z0tUivYpWyVdCQ4pjB1vy9rHASPYtQ1Zcfs5uU4twYNOKv5c1LIOa6cb5BOXYRAw74uEo8x4gtm3Mxf+ganjgIlIdyLMiMYdxlgyJkX/ddTTik1RMj3iaopjdI9FSuk8OWSXlb13pPTeu3jGhd7d4okEk1oRy8gIQnXuCioq0= X-Forefront-PRVS: 070912876F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIzNTc7MjM6T3lVZjlXSVByNk5iR0FNbXBqRE40QllSV3hJ?= =?utf-8?B?dnVKOTk2M1NVOEp1ZXk2MHY2VmZxMy8vUDc2NXllekVzdzJSOE5uNkVzeXlh?= =?utf-8?B?Sk9jVExRRmg2LzB1ZGw4Y2hjSERPaWFRMUdzQkZVY3VldEtvQXNoMnZUcXVw?= =?utf-8?B?a0QwZ3hsMHkrbm10V1poamVsemI2M1lZQlZBb1dIVVgxY09kMkFTdkJKaWdS?= =?utf-8?B?QjBPSTE2ZTdyK3RTc1BBWjBZZ2VsUTZ5RGlrTFFyUWp0bWtXTGVKQXRrZ20w?= =?utf-8?B?eGdjSFkvVUFwbXd2d2ZnbWVDNmNxQTdKSFNyMzBSNS9SdURDcHVKRHQ0K0sw?= =?utf-8?B?eGY2K0J6SjVJU1N2Ylh1bXdUbnd1aHBDZkRMVnBuZFhNOU9Mem8rYjhUbnV5?= =?utf-8?B?U3kwelBHT1UrZXZNdDV1djFBbFNuMmJDdXd4dDJqYnNsMncwL2EvQ0tLTURH?= =?utf-8?B?NWVWeGVQeEd1L2JybTBROXFJK0RQbVBQWlBqZ2ZBVTROM0tobHJja29BVi9t?= =?utf-8?B?Rzg3enR3QmdFRFBRdmtlSWJNaTFvUk9qZFRTQWdwajdFYmxJamtTdW1BZnIw?= =?utf-8?B?ZkFmYWJiWkw5eDdGeTRSUC9uNzhOWGlHU0M3cHlVbVkzSmdHMTNCVkZTVnd2?= =?utf-8?B?djNvMjZGalNDM00xR2JobkxHVVBlYjVFZ1E2aVFVcXJzUVM5cHZVcFF4Vmh3?= =?utf-8?B?aVFxM0VYMzhzVGdBR3JDV3FkQlhROVFraFVJOEM0OWZlaVYrNVVxZUk2cjhD?= =?utf-8?B?VThTZExEM2pLaFFPb1lDK3c0NHVaZE9lcEl1YkoyV3M3VTVpSnRKd0JxRW8w?= =?utf-8?B?angzODhQb1c5TU1CUE1kNFZ0Yk1RQ1lBVXNYUjZWTnhWdkdHTEQrTCs2ZkFQ?= =?utf-8?B?TU4wakd5Y0hrNFp0bjVtOTJJdk11UFVoTXJyUStQNE9ZVmlwazM5cGJ4SzdX?= =?utf-8?B?dXRaNVJRRG92d3R3dHRnckFONVFmUjdWYlU2eStuV2E1Sko1aGRBeWxqNGVM?= =?utf-8?B?UmQyUHh0ZzFsK2lkRnU2V2h6SGtoR2wvbVZuMTZyV2ljQXRxWmdJVnhjaStM?= =?utf-8?B?UXkxa0lPbXBCMzlFb3NBeDluMTRCeEJQTjUraFVOTkcyRFYzUnZnUjhrTmZP?= =?utf-8?B?Sm16TnRaUGlHcUVrazJ3SDZQbEtyUU1LRUdzbEJuRUQ1bHNrTzl2VkFhN0RP?= =?utf-8?B?aHZpK1AyK3dpWmVNOUh1U2RXeUxoVDJKSG9pVExKM0pFaEY0S3hoUjBUNGlw?= =?utf-8?B?bjBRdXRqbU5JYTNCN2VVQnVML25OMHQ5TGVwYWlzekdvU2lLUk95L0tsak1v?= =?utf-8?B?RURjQ0F3SHBFYzBvK2dxcFJ2SHBpeHRzdHZoNFpGKy96aVM3T0NjMk1FRktM?= =?utf-8?B?VThLbEFveE5JVU53NnpnR0FhYUVLc0hzcjBTbGtWV1NGWFRDaDVaUVB3ZnBm?= =?utf-8?B?cElnOHZQU216d1pWS1REdFBOVmVLM2Y2Snoxa21Ucm5LbFluT05WY3FJWTlQ?= =?utf-8?B?ck5lMzU3dVJqdnBFOWhibmYzZ3EyZHNZQk5KdHBHYUhTa2Y2c3RtSDVmbnN3?= =?utf-8?B?dldzd2dOMnNRQWJCY1cyU3NSOGRNNkc3RTBSeXZ0T0FLemhyQ0VQTTRCU1Zn?= =?utf-8?B?Y1RTMFIvdmk1M0d6b2NNWG05L245SjJiYzFTWVd5UVo2SnhLTU5ZUzNQaUxx?= =?utf-8?B?ZGwxcEkvR2JDQm5COVRMOFkvMjl6ZVNxN2hVeTFWakM0OTcvdm5JckxuaWlr?= =?utf-8?B?ZG5mbHdsZDZ6VG0yTFFkRU5vMllYeFJpaE1rQzFmVm1lT2lleFZZS3NaYjJS?= =?utf-8?B?aUxEaXB6ZVQ4cE9YQVZOVkZrY0FUUWxSV1dxNEZVd2lxUGRGWTFEZ2lLZXll?= =?utf-8?B?UlBGdm1xWnVRNWZiOEtMU1hOaWFRV05JbDNjb0RNNkVjMlowdC9JODBTZVVG?= =?utf-8?B?czJlUHY0Tjh5cVlTN3dYYUN2SWV4cUJ3THhqcEQ5THhZOUErUzJYRXhBa3cy?= =?utf-8?B?N2pEbUppYnhrazljVXhydDdheGN1M0FENENvVlV1ZytWYmdQRGxJVUNTREhy?= =?utf-8?Q?Wb5aZzBoWmpiyV7suwqvcn0X?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB357;5:5ydZ0yzny74efF3FkpspH//FT/OLAzgAGj0awKQsAW0WbdmM9qPbVZMqbSpGfyZNM5Yi76LGTpEe3/9WBUyWlx39KcpgKxQI05ABzosMRYJYnLNtayzRGLBqXYwSc+riD3OTLxszu5QdKJWpxbDW+A==;24:0t4/UYVQ2j638BrhzeOlpOGCKFSETc59MY7fm3a5P7PnPiYPueMwOducn/PDwqDqAlaijloyj7fXT0I9cX4ijzLVm+6jSD4clKKKwnii+Ns=;20:nBo8YyyO/ieU5seo8gPESNCDHaZYPSDLS9RJiER/ZgC3OtWngamEJSazKg6dbR4f9/YvBOWrr9iSYSbwTOOspw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 08:40:23.9567 (UTC) X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[206.191.229.116];Helo=[064-smtp-out.microsoft.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB357 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8O8ehD1021693 > On Wed, 2015-09-23 at 17:07 -0400, Tejun Heo wrote: > > Hello, > > > > So, this should make the regression go away. It doesn't fix the > > underlying bugs but they shouldn't get triggered by people not > > experimenting with cgroup. > > Tejun, > > this hits the nail on the head and makes the problem go away. > > I've tested the tip of Linuses tree (v4.3-rc2+) plus this patch - no > data corruption after reboots. > > I've tested just the tip of Linuses tree (v4.3-rc2+) without this > patch, and I do see the data corruption after reboots. > > Tested-by: Artem Bityutskiy > > Artem. I can confirm the patch fixes my "slow write" issue too. Tested-by: Dexuan Cui -- Dexuan {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I