mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "chengjian (D)" <cj.chengjian@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <huawei.libin@huawei.com>, <mingo@redhat.com>,
	<peterz@infradead.org>, <dvhart@infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: a competition when some threads acquire futex
Date: Wed, 6 Sep 2017 17:09:16 +0800	[thread overview]
Message-ID: <d6d32dcf-49fe-b209-d7ed-64624821b320@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1709061033280.1843@nanos>

On 2017/9/6 16:36, Thomas Gleixner write:
> Ok. Still that patch has issues.
>
> 1) It's white space damaged. Please use TAB not spaces for
>     indentation. checkpatch.pl would have told you.
>
> 2) Why are you using _cond_resched() instead of plain cond_resched().
>
>     cond_resched() is what you want to use.


Hi Thomas.

I am very sorry about the issues of my patch.
I am a kernel newbie and i set expandtab in my .vimrc file
which means tab characters are converted to spaces.
I have fixed it and will check my patch first next time.


Thanks.
    Cheng Jian

      parent reply	other threads:[~2017-09-06  9:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05  1:50 chengjian (D)
2017-09-05 19:37 ` Thomas Gleixner
2017-09-06  0:27   ` chengjian (D)
2017-09-06  8:36     ` Thomas Gleixner
2017-09-06  8:56       ` Peter Zijlstra
2017-09-06  9:06         ` Peter Zijlstra
2017-09-06  9:09       ` chengjian (D) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6d32dcf-49fe-b209-d7ed-64624821b320@huawei.com \
    --to=cj.chengjian@huawei.com \
    --cc=dvhart@infradead.org \
    --cc=huawei.libin@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®