From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC73BC61DF7 for ; Thu, 23 Nov 2023 15:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345991AbjKWPHd (ORCPT ); Thu, 23 Nov 2023 10:07:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345990AbjKWPH1 (ORCPT ); Thu, 23 Nov 2023 10:07:27 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7FD4D53; Thu, 23 Nov 2023 07:07:33 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D34533200A4E; Thu, 23 Nov 2023 10:07:31 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute3.internal (MEProxy); Thu, 23 Nov 2023 10:07:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1700752051; x=1700838451; bh=X/lvfODLkYobGVtfoM+oBWnEQdkIpHU91tC LuqhExcI=; b=t0o7gR2dKbPVO1diBMkzttpAPS2FZmFRwLCUtWNHFWhCGG50LoP idbbRaBFlg5lRkgh9fyF4CCRpaJCzM8z6jl/YwczPmg6KF0Hfr9NHEdAjIumnMpU /7hxUbvB3km+Ow1/O0YvkLCffbZS4mZtPQfW1Afj4hCVr5jbSahNzlV0Rm8i20ty Q6DEz3TVHRNhCdJVBajXpNVzjK0jyhQ31pWToLmHD+HlP87+WOBo1lZ4FTRTWcR5 m38pOhBYBbVSPX3TUUpyZ4GQuOLRuQcjVvRHO8EVtA3qQ+WxPZsoP6BpVuAS56hD ni0iH017biH8q9dMuR4TxlbuPaKNyvTLJCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700752051; x=1700838451; bh=X/lvfODLkYobGVtfoM+oBWnEQdkIpHU91tC LuqhExcI=; b=Mg9KPeaG4Nx/8L0mF8C6G4ngmewDvngpBHcBH+sxMi/4qGulgyM +JgAF+7nzekrOixh8g4WQIaNAh4HnDuheQY8zDd3lCsFDpgY0OhL0Vn1HfsFffVR dF7aPWinRyb/2bJAthouaGekpPbOq0c6QiqjPb6kLPhd6/PUleaVM6biwIFR4pWb H4puBJ4aJDMEq1/0W8fs8yWReibJZ2cn3u6MEBHtcK047Czbv5wcfGXXhdtaYLMZ X2nmenpuK7Q392ddctKK5IiGyZiEvNUpLygnM/huhnkl+LcBOZzqPTksYJVQEROk 6xjDhYcTRrT2UgRSoGvrek4fB8QRLXULjbQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdfl ihgrgihunhcujggrnhhgfdcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtoh hmqeenucggtffrrghtthgvrhhnpedufeegfeetudeghefftdehfefgveffleefgfehhfej ueegveethfduuddvieehgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhm X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7F5F236A0075; Thu, 23 Nov 2023 10:07:28 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1234-gac66594aae-fm-20231122.001-gac66594a MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-2-fancer.lancer@gmail.com> <8ca730b9-fa8c-46ea-bdc5-158da0f29c3a@app.fastmail.com> Date: Thu, 23 Nov 2023 15:07:09 +0000 From: "Jiaxun Yang" To: "Thomas Bogendoerfer" Cc: "Serge Semin" , "Arnd Bergmann" , "Andrew Morton" , "Mike Rapoport" , "Matthew Wilcox" , "Tiezhu Yang" , "Huacai Chen" , "Yinglu Yang" , "Alexey Malahov" , "Aleksandar Rikalo" , "Aleksandar Rikalo" , "Dragan Mladjenovic" , "Chao-ying Fu" , "Marc Zyngier" , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E5=9C=A82023=E5=B9=B411=E6=9C=8823=E6=97=A5=E5=8D=81=E4=B8=80=E6=9C=88 = =E4=B8=8B=E5=8D=8812:29=EF=BC=8CThomas Bogendoerfer=E5=86=99=E9=81=93=EF= =BC=9A > On Thu, Nov 23, 2023 at 12:13:11PM +0000, Jiaxun Yang wrote: >> > Ok. Thanks for the heads up. I'll fix the patch to be using ioremap= () >> > in v2. ioremap_uc() is just an macro-alias of ioremap() on MIPS. >>=20 >> Perhaps we need to fix ioremap_cache so it can give a KSEG1 address? > > KSEG0 ? Ah yes it's KSEG0. > >> AFAIK for Loongson DMI is located at cached memory so using ioremap_uc >> blindly will cause inconsistency. > > why ? Firmware sometimes does not flush those tables from cache back to memory. For Loongson systems (as well as most MTI systems) cache is enabled by firmware. Thanks. > > Thomas. > > --=20 > Crap can work. Given enough thrust pigs will fly, but it's not necessa= rily a > good idea. [ RFC1925, 2= .3 ] --=20 - Jiaxun