From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3FA83BB110 for ; Tue, 16 Jun 2026 11:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609292; cv=none; b=o8n3toapXeIcgpupDCahhVBHqPsvC5YqF62ET91ezcNEyAzfYAQR5rxuo7W6uI4j/lffqm6mo9j0yZRtm+58UbBTzVc5KfPN/kdY6ggawhU09ex6xO42wHbWCGmYZB7lf4P+fWxViv0frLBKPcKwlxvN58xXDWap++s1C1Xd7Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609292; c=relaxed/simple; bh=S5DGeSiWBHQERMNc2Ho8UJIoJGYQx8ljeq0erLmXIjM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MoKSFrgBVC2TRAyB04j99ZcvDEDyf6XelTM51pQOcoScaiB+NJcQgbzZCCvT/Ysqvw7SuhlGTXQu9ySqPvpAhmHR65613hBo/qIsydU+7sJ4s995NAQg7poIl4LPN0KGCmZ/XyWK2Ilj/L3kAezrxhCnXyy2Vm9OE5d/TxgmGUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oHqSze1r; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bVr0kYni; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oHqSze1r"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bVr0kYni" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GABnJr3384145 for ; Tue, 16 Jun 2026 11:28:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hoJLZQD2EEa0tSnrFDi3f0vHL8Y+Bwo3kq935KpPr90=; b=oHqSze1rIzdt21dn YARjGJ7Ge6GN7U6HVfjZy2vHVJeAxyKgq3FYXWZBAZg/2vNZIniBBBljt8IoXEBE ZIUYgwH5fMXt2gqHrdAlAtV8afEj7XF8Ekmio31bTf9M9zAmF41SdpLkoD9lRBm6 REvG/EFqZNWB3J72tMFwA0x093gJwCkvU5klHskta7YYFkGLgHVhLMBblx5OIKWt 1V/lismEgC9AhJSWka+SFoj7mRgfyHmez/LGYVT2d06wvNTHogwRDch+WRtXNlQI 8jG/EHEqwtYVSpKk057nY9ArVkjeP+LcpvY7y9mD62knoPDdejRg4YbNDxlnqDqm ZBOM/w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu1ep959d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 11:28:08 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-91571f0d3e3so17108685a.0 for ; Tue, 16 Jun 2026 04:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781609288; x=1782214088; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hoJLZQD2EEa0tSnrFDi3f0vHL8Y+Bwo3kq935KpPr90=; b=bVr0kYnittuQ2iNWC3TUXbdE2VXGENT/yBCPZNaZUh+Pue16InM9xKEJlIrRgQcKIo fwVXFd0lRvn8Vg6KPpaYe6xnbMRdp7CqxN+pTkF/6yRh2cRwi0LvtxPlNt+pzVcceumC p2bJ5sryVjN4OqhTRgyGS/pIJijav6UMpRppyq0CuVZOoGTqdQRrFNcQHPDK3MF5Rmaq Sxpsm+IA7ewL4Kx0ZpHh4jSLljHrS3oOwRkXcxmOuRQkdAiIZQqGIDsKt9oye15xre2m U0IDPQVgEKBFV4Clrx6hTwxwELEiZ2+mjP5A+6B/qSmGFZBBNvYRbsWq61hys14GX3vM m7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781609288; x=1782214088; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hoJLZQD2EEa0tSnrFDi3f0vHL8Y+Bwo3kq935KpPr90=; b=PuZjKrFoCwsccqlr0z6J/6sc7DRxm+m244FoDcYJyqgEVlgR5bsKIUIXHNL29buiaB s1vOy8VFWk+7jhRp8UBDmwa9QO66W9OIxuTvnQ1sLhvHI9Ko2PGKt36oMI6oOQWJN9SO uDBFyduXHjll+A6tXgQKlJ6Ee0g9K6Xa8TItz8fxxx6AJGLjZ3xGBW+e/0RqRZRhMxW0 k/FCQBzCcgoJxD5CZ+QspGGe4KAZsUh8feQsPRtC6MUbNc9o3EgAAAv1ZeXTtU0RNNez cPuMzlBZFwuR/Zk/DE+soFkzWrVzwr6Frz80M83L4bmXRSDoD+Y49jNsocoS5JwuCjrk KFRQ== X-Forwarded-Encrypted: i=1; AFNElJ8EyL0TIB8saC6Q4UWlZKRUuDzX1tah/KWxWMSmvAho2GlpIfGkhGpkAXa0HcNmBNnXovKYHT5LLHJCxjA=@vger.kernel.org X-Gm-Message-State: AOJu0YzTyTqCP4w85ZBLZRH8S/x8Sm58Ai8npK06DM8iQj9+tDN7GztW uQKjuvnBX2uhUxVzSAAq1oGJeGGl5cKSczy8pvLpJ99PebskO2r9cY7qj47S8rr4DkFYloMLOuB t4iQRQQ9j6lWwCAxmQFSWPHXba74iYliVrsqaS7DsasnO9EWHdNrF0j0/HV3TPzfYzkQ= X-Gm-Gg: Acq92OGIpCeX7GlxtY2lXCOwOWKvaQcoUMyrWQaFX7WnW7pyYVHvADIOJXJhpo7ssC8 kSJAFE/W/cS9xJ7ZbzPJqZGVkWgob6zenn9ScN9vz+l7o39EoNOgvRoCF5dglY9rE75ihbm3JmL lfMH/TdOXq7/kafBwF4gD/dD2/odtQxMWq8/BHLUAg1D+l5LWdSMMjKGLxrqUcs1DyVg3K+O3Ya ID0csZ36hNiOlablQ88MqS/fvllZK+ADL4JnR6maRKY2WG4/Z685zSt09f2+y9bC0ECv8TRT3rE ATI+9q0hWudekl4ip7BSLApzR6g+HAoz/KqI6STkCJd7UOYo0ulViyNvo7LvWgUX5ml3CZcBJF0 EPFIAWY1QV85i95LJMsIkBawMuo20tWfTwrjJ0dj2yE92Gg== X-Received: by 2002:a05:620a:40d1:b0:8cf:d289:d0f3 with SMTP id af79cd13be357-9161bca6345mr1744420385a.4.1781609288146; Tue, 16 Jun 2026 04:28:08 -0700 (PDT) X-Received: by 2002:a05:620a:40d1:b0:8cf:d289:d0f3 with SMTP id af79cd13be357-9161bca6345mr1744416685a.4.1781609287724; Tue, 16 Jun 2026 04:28:07 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb522167dsm628573766b.25.2026.06.16.04.28.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 04:28:06 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 13:28:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] dt-bindings: arm: qcom: Add Lenovo Yoga Slim 7x Gen11 To: Rob Herring , Krzysztof Kozlowski Cc: Abel Vesa , rob.clark@oss.qualcomm.com, Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260604-topic-yoga_submission-v1-0-57c70c23d0d6@oss.qualcomm.com> <20260604-topic-yoga_submission-v1-2-57c70c23d0d6@oss.qualcomm.com> <7a330941-8715-4523-9f39-10b57586c69d@kernel.org> <799fea04-e7d0-4184-b9ae-4cebfdac38d5@kernel.org> <841a54ff-6287-48d2-a513-a7442d624ab6@oss.qualcomm.com> <20260612160519.GA1118842-robh@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260612160519.GA1118842-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I/ZVgtgg c=1 sm=1 tr=0 ts=6a313348 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=Kc-3O7wfv0iHM2_tCFYA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDExNyBTYWx0ZWRfXyX9jZO1dGf7Q kuqnJtnSanqhNjgZb8ji41Y+yHfT1vmLQXH93j4mFLif5CBNR4B63K5ki2VJreXn/hjmnLlm019 gDp6db+2p8YgBIwmJr/F2QSPxZIOCSg= X-Proofpoint-ORIG-GUID: qE_JDRIbVB9dDtzVWNsofZJPbphmYAlt X-Proofpoint-GUID: qE_JDRIbVB9dDtzVWNsofZJPbphmYAlt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDExNyBTYWx0ZWRfX6B7j1jN18h7C CIQzi1bQ/tqTNcW17C9RK0iBfX2aOqMxLVU5CKfbL7utLqYE2XB1zzB/6yg+Hgxob4QjJG/41H2 vONbo0YXCTMHOs3MmvsCzvfzE9JTk27TfVTG9WFYrRyAD/d0gK+LB+qqRBlvpjgXdff0UIx2DC+ bYTgIFMN55Rapr0RQYj/WmyivPy3vjWM7o8Y67tmWw040xP2E+by3IXafzrKtkBsypJ+4QxDXA7 gK4eK6VHkvC7A0zI9ag5Exn44Pa2OVqTvJAM8L5uWrIwNXdUU0jk8ig+GPDe5oygFpevBaUHu8k z4z+nMmb49YiiZ5PRSsKFjS9xXBtX1L09cXF4a0zmPXNTVpHXVygRrpDpM3HNNdkVRcEjUp0eHv 2YJgzFwU8paQXhrhWsTxoenlJ6gr7NaRcifL7N87ZT5MlgfzYUAenX9cYtpZTG3lNYy/ErY2awH dgPeuBRK8pz7QkdpowQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160117 On 6/12/26 6:05 PM, Rob Herring wrote: > On Thu, Jun 11, 2026 at 03:48:15PM +0200, Krzysztof Kozlowski wrote: >> On 10/06/2026 15:31, Abel Vesa wrote: >>>>>>>> @@ -68,6 +68,7 @@ properties: >>>>>>>> >>>>>>>> - items: >>>>>>>> - enum: >>>>>>>> + - lenovo,yoga-slim7x-gen11 >>>>>>> >>>>>>> I imagine you might want different panel variants, just like T14s has >>>>>>> LCD and OLED? >>>>>> >>>>>> I expect this will be the case. >>>>> >>>>> Then better to prepare for this now, otherwise later you need to change >>>>> bindings. If unsure what other variants are, then at least make this >>>>> compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar. >>>> >>>> I took another look at psref [1] and there's only OLED SKUs (today?). >>>> There are however, two different resolutions available and both can be >>>> touch/notouch. >>> >>> If the other SKU doesn't have touch, then you might as well mark now this >>> one with touch suffix or something like that. >> >> >> If you decide not to have any changes (new compatibles), then at least >> please document the above reasoning in commit msg. > > If the difference is just the panel or touch, then isn't that captured > by the panel and/or touch nodes? We already have a couple of DTs for laptops where the touchscreen may be there or not, with the additional hid-over-i2c node defined unconditionally and it works out fine For the panel, it depends.. If it's another "Samsung ATNA"-class panel (which I would guess is the case, but can't know for sure), and there's no other changes, then it would work too. I opened the build configurator on the Lenovo website and I can order both kinds of panels with both kinds of SoCs (X2 Plus / Elite) > OTOH, if it's different firmware builds and generally treated as 2 > different devices, then different top-level compatible is probably fine. I unfortunately don't know the answer to that question.. They all carry the same model number on the website, it seems Should we go forward with an optimistic, single compatible for the known variant ("lenovo,yoga-slim7x-gen11", "qcom,glymur") then? Konrad