From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazon11020134.outbound.protection.outlook.com [52.101.191.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD593FF1 for ; Mon, 16 Mar 2026 13:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.191.134 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773666407; cv=fail; b=BUwqzn/KaOc79XmLEMdX/t4LSKWeYRi+ie55y+iCgyhU+daZz+Quo13T1qP14KO78oJpa89gd1zrW+dELzV5Jb4wuAydeMe6lVzRCk1z9VKQWLOIecvSEF/nfLBiZNIB9kzvDsh4H/AfIdf03w1Xnv7iHgJoAWYmOHMlOySQFgE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773666407; c=relaxed/simple; bh=KcBpliIlEC+INZfGdabp67J0+qRVhbPaEziLaESr0V8=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=H8fWA210fqlVqXn6Yadcglio65QRcNqeTrU8gFpEkwoyTGa/mHOvnafKom8VBii6nqUBIMv9S8SnMJAHrP31zMK3LgQSp7x+XyUj9NQlXVSivYRerIr/iPz9W0zqaCZcaSJfEmwLya2eklOW/qJgGJHdvHzQ1TUVD/YRjJCcja0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=oghYgaHm; arc=fail smtp.client-ip=52.101.191.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="oghYgaHm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FqKnYQLloMWXczFvTfnx+C3S3HarYbWsmJA/iyVi0hoY8F2vPz8Bc0v+6sGJfxkyrusyMM9mkF9QeiWEf9v8sc1lOZIhW9GI48fdIlyVtRwNZheLOVPrWWLmE0mnoVLJh7Me8Zz5dIqRym3WCvZQv1KkkXnBbZdDnCMI/BWZkIJSvxBsnZj5D/C3GugrTGcZFVwYNgkuHt9hxoDkzSQKR/peg77IpOBeWRhOZImlci5Tcl0cgk6dkh5SMlj3bHCODecbVu+Kg+fq6yZDeLnPNeqKNilAd1OFx3XYvq2urtdeJwiKRBQ3gxDrN6+hHpGJOgvUU56eFxcAVaRv+iEtdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4dtshmrgq7Xdt4qC7onin1/GzvseNp0329sXNyzdIfc=; b=p2JvHxDVnwThmE90GSbuUag64+C4iwMKKamSgzNgpnxQbIhNMytiWOJhD8ZWVnv2WGjUDAVAg2h7jINe+hgocDIdZb/1je6DuoiTK2EtleT4k8zmUSQRS6SWjb/BYyoPOF7k1ifq0WVGUOa4oDBfjd0S/7c9gpHmoSFqfKNjYlPq3ycAh/bFB/2r/1AFg1z9yFEx4w1Qpo83C6rPvafFEHdrTPFoJ61S6gFe1ufMc627BZivuOB0m2TSf1pD3wp8FnA6o0QlWE3Z2d+Uy2ko3WB8p3tFKIux6Vhm3GMXm/q92fc/f8N1Y7/qv+1tEl/7vKCNL5hkm+ym1IZTELRSrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4dtshmrgq7Xdt4qC7onin1/GzvseNp0329sXNyzdIfc=; b=oghYgaHm0PdBB+8zjAyuhKte4PamWsQLaRtl/aNIEK5cy0lcnOU+MziEFny6ONPpd3A/WFQ+xZCzLDzvKZh8YOVQsAtAo+atMseGe4WUN9yx+osrAigI1Dv7lJQ3jqUzIAh6nVnJEtyJI5M+ZmVpB8JiBSbjNgDjJ5xx1IiWD87K2Muo5zU98eFv5C4FXlp5zPwLwCB/gzoNEMrBjicH39CVRYJrub99PYm+vvsoETyaaWlsujHuCQ/6ujC5YQmyqqet33e1Kr2twEh3DUFJoormeCFhBGXVc6rHYEm5meXIeCzOm8oK8iEcRpKTbzIKByaeA5uMi81qqlyW3yySRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YQBPR01MB10838.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:90::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.25; Mon, 16 Mar 2026 13:06:17 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1%3]) with mapi id 15.20.9700.024; Mon, 16 Mar 2026 13:06:38 +0000 Message-ID: Date: Mon, 16 Mar 2026 09:06:36 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib: fix compare_delta parameter order in percpu_counter_tree To: David CARLIER Cc: Andrew Morton , Josh Law , Dennis Zhou , linux-kernel@vger.kernel.org References: <20260313175424.132735-1-devnexen@gmail.com> <20260314144508.ba3504b4338eb1ae84017028@linux-foundation.org> <65bc70e0-c9a8-44b7-aa8e-3ffa31b0ed75@efficios.com> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4PR01CA0232.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:eb::7) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YQBPR01MB10838:EE_ X-MS-Office365-Filtering-Correlation-Id: 82c3c566-1bbb-4f7d-032e-08de835cdc0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: oFwE0h8xKU89C/DfO74Df1Q5LTzuEhT0VQ75vlqb2oKHyWHypFuxVbvTwkZik48n/dqLNttaLHwtS8+4gtGzkA3mLxM2TtLXv4dVOhpfagJ7j4xOxQDm2DmJukAY34cHpPYEoLsv78gFl9jcxrIgZpnG7dO9tsLaOOrrv+Mbr3WeogYwtMW4iqYiW5TXl3sAD5p1JZuogYSEIdLq0OmqBK4n6zbV2WucVziO3tdpKTkGm5DIz1MMf4ssnWL449sFn7Ija+ZscPcLyW7t9ThEIknPqQ4+Z4WxFyAvi9iTQujNOuHSnEGu5ZsjNPImNqz/op9kHtIK/X60l1ZKYlMQs0Pl0q666yKQP1UMnGr7HcIIafS9gf4CQ1gUhVlFnX7UKlp88Lseat868WtD0/VwF7Xo/DnmxDN+yzEr4hn7G+277nexRN5ofZwxTJX3aCOLQuSrzA8DQrx04RMAdrDd8O3WE8iJYCSUK9Xdx3gVG58FUUfQp0fABZR/aMmoSDyGDIR+pRD/KoARhI28n2L5RNQhGUbvU3PaVqfGsrCgPqEn9d1C+uO0/SD1566gMuDjKWL8aYpstbdThGTY6V566Nlw+oIelVPDWYF8KFDcDhdK0Oj2NgspJD5GwjGlayN3A40iQ9SB2Wp7QsePxBonhdz0C3yaon7ijR5EkOlM35aUm100cQ2SQnA+NRPONKl5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUZod2JuelNPa21hOGlHdW9MK1ZneHF3R3F3YmxtaTZyd0NpMkNQS1ZkdCtT?= =?utf-8?B?RWZmS3pwZWxLNW4zSWtYTmk2c1MzM280cm1NWDdjeHZHTC9tMmRZdnU1d3JQ?= =?utf-8?B?c3N5cGdJM1hLaVNES0x4SUMyWVNORzh6bjBYS2l0Ums1VDhERUtCdmJCLzkx?= =?utf-8?B?UWFpMjVNM2dBaG44d0djenhMUzdSUXlVM2JDS0JmOWxHVUJiK3pVZ0dlRG00?= =?utf-8?B?ZHFQSjZxRHRlVzExdTJMbnNUY2FqazVycENLb2JIZFQrN1poMlRxS2Qzc1Mx?= =?utf-8?B?TldkNHlEUEZZZDl2L3g2OWlLWHVRVWg0em90Wmp2eDJ4TWlVa3hxZFdNUStV?= =?utf-8?B?OWEycjNUQURLajJxcDNObEJzYUhLTEdRSElldnVRcHg5MjN5NTB0TVNJN0Vm?= =?utf-8?B?cGNzT1FoRmJQVWNUNjRwK0pXb3JTMnpSazRCdWxzTlE4cmZSYWYzL2JxbHVt?= =?utf-8?B?bDdHVTNzaXBTdDczK1lwMG1iaEN6ckowMThNZTRIRnlZSW1PVlgwK3AxN2VN?= =?utf-8?B?bnpCRTh0UGVQcVI2NzVEcUVLb2xhMkpDd1VqVjgxMWZhKzF0a3RvclEwUE5Q?= =?utf-8?B?SzVlRjQwNDBkVmNDL3F2NktkM2YwNUVBNERxd0lENnNpSHYrTk5yaDlhdmw3?= =?utf-8?B?Ni81K3VGemZjb29ZWTU1SDJIRmw0c0VteWJneng4QkxpdldmQWo5V29lWmcv?= =?utf-8?B?c1RQd0t2bWZOR1BwRGhReGpJVU02eHBKaFJzYjRKRTRId2ptY3NxdFBDdzNU?= =?utf-8?B?REk2N1lXTytCOHc5VTV1U01QQS9FcklJY2ZLS1V6YXhXODQySVJIR0JnZUVv?= =?utf-8?B?ZFBCTUNVRWVWR1R3OVRTTGgvMmFrYncwVktGTnl0cXhHWVBvV2hxQjBiS2I4?= =?utf-8?B?SUhNUVhyR1VXSk1wZ2wzdkNJUGViMDZUSGZSOGsvd1hCeTJma1UyVHJ4Ym82?= =?utf-8?B?RldzWFJMLzZLQWR6eVlnTHVFMWsyVmVuYmY3eDNrdW5ZRHptQXRtYTFTNVJk?= =?utf-8?B?L0JhUmE0cmN4Z09MaGNZNTNLVWI2MnB3MzhIalF5L1NVK0lnamRUb2ZJYXk5?= =?utf-8?B?TEFIQWJnajZ1ZWxhS2dITXlkRzN0K2hrWS9NaDNzRWJlTjdybW1JZUhjVjZP?= =?utf-8?B?V2d6MDczSklQZmJ6YnNpUWx2cGRTa1hZQ3J1eE5ReUZqdStLRExldTBvWmNs?= =?utf-8?B?VWpBVEVKb0NZOFhlVjBkWGVXRXc1ZXRzTDg3dWEzWkp1Z3prMklxL0dYVnpE?= =?utf-8?B?dGdaY0tObmZLTUo1SkVjTkRsYzF1bHAraTRIbkxGbVZQeVVMNXdjQnNhRisz?= =?utf-8?B?Q3VvejFhMDFoSEtPUUVObmFROHgxU0FXdDJsQ05Ka3oxeWl4anltSVorZ3kr?= =?utf-8?B?andvRFdHOEtNSC9EOG9RUk83QnY1aDFNQjJsTlZrL2J3WUEvSXlBeEJzSXFX?= =?utf-8?B?RHVBMmRvcmRQRE96UFFIK3hHMlRraDNwSmtZazBtVEJpMFRIQ0JEN1JqQS9B?= =?utf-8?B?bExITmVLWGlzQ1diZndkQ2tHcC9iSXR6d1hXci9TekpzZlhGQm9mbmUxZmk2?= =?utf-8?B?TWxiKzhYSk41QmJxK0hZRXRwV1cydDZnRER6b2lWTXhEaDV2ODFjMTUvUHls?= =?utf-8?B?cW52OWVaalJqRmxxSG9QL2pRZVJ3TzNhcC9sODVUblNBdGFXTmdjVktSd3Bu?= =?utf-8?B?Zno0ZUtUUXY2dVFhbVN6djBFbnkrcERYbjFuRUFzYllkd2dmZUNlZ0ovZVpJ?= =?utf-8?B?NE9TU3NCMndVUkhDN2NmSlM0WWtyVHEzRzZRbkxCczZRSlhjZURTUFQ2UFdU?= =?utf-8?B?OE12aUhYY1VPUk9RYWJmY2Rna21nTzFjMnM4YjMrQ2tYZkt5eU1jVm1Jb2l4?= =?utf-8?B?elR2bVpEQXNTa3BFeW94bGI1a1JzZ1lsdWxOMXZ6NldkVHRlVTZBeEs5ZktG?= =?utf-8?B?OXl3Ty9IemxabEtQYXNPSitxNEVjRkdqYVB1Mm44c3JLUFQ3ZmU1TXRmMi84?= =?utf-8?B?dmhUbTdOM2cyVkpkY0gvLzhaamJEUVpWY0RNU1V3SDBCUlVLM2V1bmxSRHAx?= =?utf-8?B?R3h1OG9OUnpOejZ6OHNobGgzU1dBaHZtTWNOeFdyWGJGTHlkR05BdjVOZFVi?= =?utf-8?B?WEcxM25ZTVdKS3FjWXpGQnM3Y0FhQXJZejVLTVJBTk1lczNoa0ZHeHIxbU94?= =?utf-8?B?NWdXRjlEQWtyS1ozVGpScGxDSFpHVHE3aDhybWhteUtRWWlCa1h5ckZFcUU4?= =?utf-8?B?SXB6RjNrQ2pTaXgwT3RLcW1XYWYrNkhNaXZKaDYyb0tlaDl0ZHMwdThlbDQ3?= =?utf-8?B?NHRtYU5JUzlMUEtjMVdGNnBLcHpGRUpuMmRUSVFvREhqL1NhRHhuSlFtWlg1?= =?utf-8?Q?gpfRkBTnvA8OaHkEP0YyvyR75dJrfsprybPKj?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82c3c566-1bbb-4f7d-032e-08de835cdc0a X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2026 13:06:38.6503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BM/hMEYit7sg4X7JTR5R+97ow5mIfihCRvK9rvmy+1AlyxVOH1M7ZXdsW2ApOUw6ZnfzF27STa+idg43ShNIo89Owgt05GU1POhC1qoVCuo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR01MB10838 On 2026-03-16 00:28, David CARLIER wrote: > You're right. Here's the simplified version: > Much better. So this covers percpu_counter_tree_approximate_compare_value. Can we also add coverage for the following affected APIs ? - percpu_counter_tree_precise_compare_value - percpu_counter_tree_precise_compare - percpu_counter_tree_approximate_compare When comparing between two sets of counters, we end up summing the the accuracy ranges of the two counters. So in case we ever have an issue there, it would be good to add coverage of the range limit cases in the same way. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com