mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: surong pang <surong.pang@gmail.com>
Cc: mathias.nyman@intel.com, Greg KH <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Orson.Zhai@unisoc.com, yunguo.wu@unisoc.com
Subject: Re: [PATCH V1 1/1] usb/host: Let usb phy shutdown later
Date: Fri, 22 Apr 2022 10:53:17 +0300	[thread overview]
Message-ID: <d6df23a0-6539-f955-5241-5cdfcaa4eca4@linux.intel.com> (raw)
In-Reply-To: <CAEDbmAT=fZ-kpn13sW4KjB9RuFb_6T4j_eripR54NZ3UciZfqA@mail.gmail.com>

On 22.4.2022 5.10, surong pang wrote:
> shared_hcd might be freed already here, but hcd should not be freed
> here, because "usb_put_hcd(hcd)" is called later.

To me it still looks like this patch calls usb_phy_shutdown(hcd->usb_phy) _after_
usb_put_hcd(hcd):

>>> @@ -398,6 +397,7 @@ static int xhci_plat_remove(struct platform_device *dev)
>>>       clk_disable_unprepare(clk);
>>>       clk_disable_unprepare(reg_clk);
>>>       usb_put_hcd(hcd);
>>> +     usb_phy_shutdown(hcd->usb_phy);


shared hcd was freed even earlier, before disabling the clocks.

Thanks
Mathias

  reply	other threads:[~2022-04-22  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 12:25 Surong Pang
2022-04-19 14:45 ` Mathias Nyman
2022-04-22  2:10   ` surong pang
2022-04-22  7:53     ` Mathias Nyman [this message]
2022-04-22 10:43       ` surong pang
2022-04-22 11:59         ` Mathias Nyman
2022-04-24  1:57           ` [PATCH V2] " Surong Pang
2022-04-26 11:53             ` Greg KH
     [not found]               ` <CAEDbmAQmYQdMNY8sANnSuauBcsemrV1MFR3bB83JJ7cHNdWGmA@mail.gmail.com>
2022-04-28  6:31                 ` Greg KH
2022-04-29  1:54                 ` [PATCH V2] xhci-plat: " surong pang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6df23a0-6539-f955-5241-5cdfcaa4eca4@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=Orson.Zhai@unisoc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=surong.pang@gmail.com \
    --cc=yunguo.wu@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome