mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: Wei Chen <harperchen1110@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] media: hi846: Fix memleak in hi846_init_controls()
Date: Mon, 27 Mar 2023 12:20:13 +0000	[thread overview]
Message-ID: <d6e483b15911a9be1e6c1d38200e50b5789738b2.camel@posteo.de> (raw)
In-Reply-To: <20230327115809.297633-1-harperchen1110@gmail.com>

Am Montag, dem 27.03.2023 um 11:58 +0000 schrieb Wei Chen:
> hi846_init_controls doesn't clean the allocated ctrl_hdlr
> in case there is a failure, which causes memleak. Add
> v4l2_ctrl_handler_free to free the resource properly.
> 
> Fixes: e8c0882685f9 ("media: i2c: add driver for the SK Hynix Hi-846
> 8M pixel camera")
> Signed-off-by: Wei Chen <harperchen1110@gmail.com>

just for the future: you don't need to send a new revision for tags-
addition only. That's usually something that maintainers can do when
applying, also (semi-)automated.

But *if* you send a new revision (due to other changes), you *should*
add all appropriate tags. So for this new revision you forgot this:

Reviewed-by: Martin Kepplinger <martin.kepplinger@puri.sm>

but, as you now know, you should not create a new revision for this
alone.

thanks,

                            martin



      reply	other threads:[~2023-03-27 12:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 11:58 Wei Chen
2023-03-27 12:20 ` Martin Kepplinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6e483b15911a9be1e6c1d38200e50b5789738b2.camel@posteo.de \
    --to=martink@posteo.de \
    --cc=harperchen1110@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®