From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172AbcHII0Y (ORCPT ); Tue, 9 Aug 2016 04:26:24 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:55736 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbcHII0V (ORCPT ); Tue, 9 Aug 2016 04:26:21 -0400 Subject: Re: [PATCH] net: ethernet: ti: cpdma: remove used_desc counter To: Grygorii Strashko , "David S. Miller" , References: <20160804152051.30565-1-grygorii.strashko@ti.com> CC: Sekhar Nori , , From: Mugunthan V N Message-ID: Date: Tue, 9 Aug 2016 13:56:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160804152051.30565-1-grygorii.strashko@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 04 August 2016 08:50 PM, Grygorii Strashko wrote: > The struct cpdma_desc_pool->used_desc field can be safely removed from > CPDMA driver (and hot patch) because used_descs counter is used just > for pool consistency check at CPDMA deinitialization and now this > check can be re-implemnted using gen_pool_size(pool->gen_pool) != > gen_pool_avail(pool->gen_pool). > More over, this will allow to get rid of warnings in > cpdma_desc_pool_destro()-> WARN_ON(pool->used_desc) which may happen > because the used_descs is used unprotected, since CPDMA has been > switched to use genalloc, and may get wrong values on SMP. > > Hence, remove used_desc from struct cpdma_desc_pool. > > Signed-off-by: Grygorii Strashko Reviewed-by: Mugunthan V N Regards Mugunthan V N