From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49EFD13E02E for ; Sun, 5 Jan 2025 18:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736101774; cv=none; b=hvhpPyLhcBIiVpOEVyMHTik/ZHoQbEafi/tkZCS4iKWSztMt6bGmpM5CKpL6XGlvgdM1q6jvpBRhMSbtLjRfiEodWP0X1MToh7Kb3Jh55FP5ypUNTmrWXixaWKCh+L+68WOH0JzUQjJo5OH4OSMGm989fZqLAMFFoffj8LyKwkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736101774; c=relaxed/simple; bh=xY9igkIwnYFprv605QeHtSq8u05NQ0Fl/B/5y0vlkXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YpC/K3lF3D2aTjiSgTSg2jK2Wwxx8maag6cAwpXwIFQWmByNimXkb8vH7dbeCveG9r6OyWPfq8SD5uzI0t7F3EpjSY2xw22iV0aRQqlDQzELsUH1FyVwBRJ+8XX6mfdEtAtMQUlRUX4mGz29fbok5oHyeZlJx77qTR6qWu/jMcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=J3t3A8Nr; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="J3t3A8Nr" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 505GJfUt009485; Sun, 5 Jan 2025 18:28:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=rYo3QNnffJJYWk1AzpJdwz2QztmKs7pdTTpJQBORLD4=; b=J3t3A8Nr/KF6 /7jiJC0/gp21U+gOpJopVJVQKBSnBNA8kMcbZjnVaLcpQqvfe/RYdOBVTewFeqc4 MJuqCqz0c3+78PltUDoszvweC5Q4bDQO4C2JOaFjZD2QNTVRtzjo/lzOichkJexP AjoQN7m4xyDU1C/mEAIFPp86wNUrCvjZKewXmYOny2g02xKEgrTeA2Tc7oGLlDHv x71mm3bteqMxCyAP/7ZFXLqtNUBfmFW+Yu/ijnO9v+2YFz9LJpFhS8U7E1TGDnIJ P+abbkCI5PHFaDX956s54srw0gdGcE5fVN3G3sAzhaxIS/SbnfWCIg+iEGNjysKU 9cMPy5Jm5Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43yetaaem0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Jan 2025 18:28:16 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 505ISFmO011392; Sun, 5 Jan 2025 18:28:15 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43yetaaekw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Jan 2025 18:28:15 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 505HHD00003571; Sun, 5 Jan 2025 18:28:15 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yfasttb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Jan 2025 18:28:15 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 505ISEbg17760898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 5 Jan 2025 18:28:14 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F063258058; Sun, 5 Jan 2025 18:28:13 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 337D158057; Sun, 5 Jan 2025 18:28:09 +0000 (GMT) Received: from [9.43.108.122] (unknown [9.43.108.122]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Sun, 5 Jan 2025 18:28:08 +0000 (GMT) Message-ID: Date: Sun, 5 Jan 2025 23:58:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] sched/fair: Remove unused task_numa_migrate return value To: Chuyi Zhou Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, riel@surriel.com, chengming.zhou@linux.dev, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org, Madadi Vineeth Reddy References: <20250103065930.413464-1-zhouchuyi@bytedance.com> <20250103065930.413464-2-zhouchuyi@bytedance.com> Content-Language: en-US From: Madadi Vineeth Reddy Reply-To: 20250103065930.413464-2-zhouchuyi@bytedance.com In-Reply-To: <20250103065930.413464-2-zhouchuyi@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GI-fHvRfO0ByN75Ahq3CbtSPtIQerVRo X-Proofpoint-ORIG-GUID: NFF3wWUoBljfL34eOAFv61eeQMkYU3Wf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501050167 Hi Chuyi Zhou, On 03/01/25 12:29, Chuyi Zhou wrote: > Initial NUMA Balancing implementation used the return value of > task_numa_migrate() to retry NUMA Balancing in commit 6b9a7460b6ba > ("sched/numa: Retry migration of tasks to CPU on a preferred node") however > in the same series[1], Mel also included an optimization from Rik which > retried NUMA Balancing periodically irrespective the return value from > task_numa_migrate() in commit 2739d3eef3a9 ("sched/numa: Retry > task_numa_migrate() periodically"). Maybe you can also add: Fixes: 2739d3eef3a9 ("sched/numa: Retry task_numa_migrate() periodically") While it's not strictly required, it might be useful to include for context. > > The return value of task_numa_migrate now is unused, remove it. Yes, it's unused now. Reviewed-by: Madadi Vineeth Reddy Thanks, Madadi Vineeth Reddy > > [1] https://lore.kernel.org/all/1381141781-10992-34-git-send-email-mgorman@suse.de/ > > Reviewed-by: K Prateek Nayak > Signed-off-by: Chuyi Zhou > --- > kernel/sched/fair.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d5127d9beaea..f544012b9320 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2486,7 +2486,7 @@ static void task_numa_find_cpu(struct task_numa_env *env, > } > } > > -static int task_numa_migrate(struct task_struct *p) > +static void task_numa_migrate(struct task_struct *p) > { > struct task_numa_env env = { > .p = p, > @@ -2531,7 +2531,7 @@ static int task_numa_migrate(struct task_struct *p) > */ > if (unlikely(!sd)) { > sched_setnuma(p, task_node(p)); > - return -EINVAL; > + return; > } > > env.dst_nid = p->numa_preferred_nid; > @@ -2600,7 +2600,7 @@ static int task_numa_migrate(struct task_struct *p) > /* No better CPU than the current one was found. */ > if (env.best_cpu == -1) { > trace_sched_stick_numa(p, env.src_cpu, NULL, -1); > - return -EAGAIN; > + return; > } > > best_rq = cpu_rq(env.best_cpu); > @@ -2609,7 +2609,7 @@ static int task_numa_migrate(struct task_struct *p) > WRITE_ONCE(best_rq->numa_migrate_on, 0); > if (ret != 0) > trace_sched_stick_numa(p, env.src_cpu, NULL, env.best_cpu); > - return ret; > + return; > } > > ret = migrate_swap(p, env.best_task, env.best_cpu, env.src_cpu); > @@ -2618,7 +2618,6 @@ static int task_numa_migrate(struct task_struct *p) > if (ret != 0) > trace_sched_stick_numa(p, env.src_cpu, env.best_task, env.best_cpu); > put_task_struct(env.best_task); > - return ret; > } > > /* Attempt to migrate a task to a CPU on the preferred node. */