From: Randy Dunlap <rdunlap@infradead.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>
Cc: suleiman@google.com, briannorris@google.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3] PM: sleep: Expose last succeeded resumed timestamp in sysfs
Date: Sat, 28 Oct 2023 09:48:36 -0700 [thread overview]
Message-ID: <d6f016fe-963b-40ba-9146-de69e4fe0052@infradead.org> (raw)
In-Reply-To: <169849758243.1357961.4105003693126485611.stgit@mhiramat.roam.corp.google.com>
Hi,
On 10/28/23 05:53, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu <mhiramat@kernel.org>
>
> Expose last succeeded resumed timestamp as last_success_resume_time
> attribute of suspend_stats in sysfs. This timestamp is recorded in
> CLOCK_MONOTONIC. So user can find the actual resumed time and
> measure the elapsed time from the time when the kernel finished
> the resume to the user-space action (e.g. display the UI).
Can you go into the use-case a bit more, please?
You have said "what", but not "why".
What do you (or google) plan to do with this?
>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> Changes in v3:
> - Add (unsigned long long) casting for %llu.
> - Add a line after last_success_resume_time_show().
> Changes in v2:
> - Use %llu instead of %lu for printing u64 value.
> - Remove unneeded indent spaces from the last_success_resume_time
> line in the debugfs suspend_stat file.
> ---
> Documentation/ABI/testing/sysfs-power | 10 ++++++++++
> include/linux/suspend.h | 2 ++
> kernel/power/main.c | 15 +++++++++++++++
> kernel/power/suspend.c | 1 +
> 4 files changed, 28 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-power b/Documentation/ABI/testing/sysfs-power
> index a3942b1036e2..63659765dee1 100644
> --- a/Documentation/ABI/testing/sysfs-power
> +++ b/Documentation/ABI/testing/sysfs-power
> @@ -442,6 +442,16 @@ Description:
> 'total_hw_sleep' and 'last_hw_sleep' may not be accurate.
> This number is measured in microseconds.
>
> +What: /sys/power/suspend_stats/last_success_resume_time
> +Date: Oct 2023
> +Contact: Masami Hiramatsu <mhiramat@kernel.org>
> +Description:
> + The /sys/power/suspend_stats/last_success_resume_time file
> + contains the timestamp of when the kernel successfully
> + resumed from suspend/hibernate.
> + This floating number is measured in seconds by monotonic
What does "floating" mean here? Not floating point...
> + clock.
> +
> What: /sys/power/sync_on_suspend
> Date: October 2019
> Contact: Jonas Meurer <jonas@freesources.org>
[snip]
Thanks.
--
~Randy
next prev parent reply other threads:[~2023-10-28 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 12:53 Masami Hiramatsu (Google)
2023-10-28 16:48 ` Randy Dunlap [this message]
2023-10-29 2:54 ` Masami Hiramatsu
2023-10-29 12:16 ` Randy Dunlap
2023-10-29 13:28 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f016fe-963b-40ba-9146-de69e4fe0052@infradead.org \
--to=rdunlap@infradead.org \
--cc=briannorris@google.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®