From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6842154BE0 for ; Tue, 11 Feb 2025 04:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739246888; cv=none; b=thWMPYNPPOVlVkWgIfiIkDS/lkHLRh11DHj2Czgm0dtGtLAslnE4YNtkd/ovfW/yWEg5ARHqjulOCdbIVTbvoSnWPa4+ytmlayk5kHQGXRu+j5QbXR04XxIhvJ3SFI9RR7rDeGrtwlprGOTVpC4Ns3WZTqkBihw8R3QmkmoNYwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739246888; c=relaxed/simple; bh=b6XY/v5c1IShWi7Mnzp3g3rBRfTPLqoqs/fcWxDfeEk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TqlIZrUo/NUik7QPiv4GUZUm0hqe7g7tiBCgDRoKSwPsR4Y6qmFTSaWJZtm7FfAmphUY8DwALJdL0nP3vBmUE+73YFynET5tL3u3+LvtQbu8vAMtFB5z0qYW1VRahHZ9puV3sPTGVcb8lUSdV80JLKqKnU6zFe6UdD5/r6csygM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=b2Pwc+jJ; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="b2Pwc+jJ" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-726e5aba2d8so463940a34.3 for ; Mon, 10 Feb 2025 20:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1739246886; x=1739851686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=t8eYWsGO5bR6d/A4TPLNpDeU5HcoQR1tHKfNDbSFT88=; b=b2Pwc+jJ4jVFOaDwaDWWBD4g1f3mOtu5WE0oXVLvwulvsu6BXTJz7LRn88fibO6Y0C KN3MT79GAbDfPYUZvDzwgZ4o6/Kk2+h8eyut371dXb3KZ6BUjFxTbKNFW1PjmiDPE6OJ AHRhN5hTLmCbFU1TBDemGknqhnsfF4VliHBto= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739246886; x=1739851686; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t8eYWsGO5bR6d/A4TPLNpDeU5HcoQR1tHKfNDbSFT88=; b=Vwz/JCRsY9zYEwm75AXd9q/nd/fFgTodCWGUhGa0n4DOslRILORG4Ct9+xwhNftjja UPNZhSTW905Qyc0+9pqW16tVqmRMJ/XzyQtbhkZ/6hkbb96/eeRtMzDZkdTnEtEV5d5u 2OniOtCD4kcZMeO5pzWDJOrxXs2UCsxkW1Prh+lPslXxj4soSD0Qq7nxHp8MdFy2/1Hk OFi3rjwthzfqaoP6N26Bc6yjQU+9mIUHmGe4F/gON1PTANYKiIcC6QbIVruzlpXrFxsO FuegX+YV4h/vwxK2WDi8FRmXblEZI4zomaV3RNK+adstAi1KRo4OEXHyDuL47Vml6aqi nEmw== X-Forwarded-Encrypted: i=1; AJvYcCWFUanOKsBsT472Sz3nMbyAOwa4sMr3NHmj13zfLWyCO+tfDDJAE3ozzWYSig0fy+T8qMQbK5PR8FYjGX0=@vger.kernel.org X-Gm-Message-State: AOJu0YwmWMaafEnqRC3Irc068ZKnM6P6SOpM1q82BtZyPMrWNvaIKQx/ oWb1m4FxbrhV6bOCTmnDQfqjQiUiq7ih0uZZrVPgvAb82DPCtil1uBoG9PDaow== X-Gm-Gg: ASbGncvgJZUOfQBbLOrO90TSYDshqYV/9FhWzoVsR0BI2KEwwqzxO7Tg0Ur514cEgci 04VvBM5nK+ujfdSwyt7FyPXGrbhvjQGxnUEoHwX671NH5CMkVCJqQfuKtYwrStxzZrv2h9Anzx8 DxtScjcJ1bjsrbRwJAM1hyKiwVmtEcFitP9WZ3cRUX8SIqqy+PtYsINu84AMMbNebhIBFOEQ+sQ PdY5HC4IL+s9dpXnHbNBXEb/wLMcL9yxqdePo8IjbGgskAmba8KiPQKKNu4rKms4KHfOGkWdSTM D0T/vBnDQb1kUJR/TrZCxHDBkkMJOs0ybwgqnjHaOBdkQKprhjctX7EBxYGNmijTEA== X-Google-Smtp-Source: AGHT+IFapi4wMv31NrAKWbcvGGOIg6pfCWW86OI3QXYEtKOl36IiOEMw2fKlDSL1dacmx7ZY5EhBlg== X-Received: by 2002:a05:6830:6d11:b0:726:ea48:5993 with SMTP id 46e09a7af769-726ea485bb5mr589459a34.2.1739246885929; Mon, 10 Feb 2025 20:08:05 -0800 (PST) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726e93d873csm380757a34.47.2025.02.10.20.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 20:08:04 -0800 (PST) Message-ID: Date: Mon, 10 Feb 2025 20:08:01 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: bcm: rpi: Fix potential NULL pointer dereference To: Chenyuan Yang , mturquette@baylibre.com, sboyd@kernel.org Cc: bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com, dave.stevenson@raspberrypi.com, popcornmix@gmail.com, mripard@kernel.org, u.kleine-koenig@baylibre.com, nathan@kernel.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, zzjas98@gmail.com References: <20250211000917.1739835-1-chenyuan0y@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250211000917.1739835-1-chenyuan0y@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/10/2025 4:09 PM, Chenyuan Yang wrote: > The `init.name` could be NULL. Add missing check in the > raspberrypi_clk_register(). > This is similar to commit 3027e7b15b02 > ("ice: Fix some null pointer dereference issues in ice_ptp.c"). > Besides, bcm2835_register_pll_divider() under the same directory also > has a very similar check. > > Signed-off-by: Chenyuan Yang Reviewed-by: Florian Fainelli -- Florian