From: Peter Rosin <peda@axentia.se>
To: "Eugen.Hristev@microchip.com" <Eugen.Hristev@microchip.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"Ludovic.Desroches@microchip.com"
<Ludovic.Desroches@microchip.com>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] dt-bindings: i2c: at91: add binding for enable-dig-filtr
Date: Tue, 25 Jun 2019 08:57:14 +0000 [thread overview]
Message-ID: <d6f9cae4-0281-e1da-3c7d-69600f7562cd@axentia.se> (raw)
In-Reply-To: <1561449642-26956-4-git-send-email-eugen.hristev@microchip.com>
On 2019-06-25 10:04, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Add binding specificatoin for digital filter inside the i2c controller
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
> index 2210f43..8268595 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
> @@ -20,6 +20,9 @@ Optional properties:
> capable I2C controllers.
> - i2c-sda-hold-time-ns: TWD hold time, only available for "atmel,sama5d4-i2c"
> and "atmel,sama5d2-i2c".
> +- enable-dig-filt: Enable the built-in digital filter on the i2c lines,
> + specifically required depending on the hardware PCB/board and if the
> + version of the controller includes it.
> - Child nodes conforming to i2c bus binding
>
> Examples :
> @@ -56,6 +59,7 @@ i2c0: i2c@f8034600 {
> clocks = <&flx0>;
> atmel,fifo-size = <16>;
> i2c-sda-hold-time-ns = <336>;
> + enable-dig-filt;
This spelling does not match the spelling in the subject. But please see
my comment on patch 6/9...
Cheers,
Peter
>
> wm8731: wm8731@1a {
> compatible = "wm8731";
>
next prev parent reply other threads:[~2019-06-25 8:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 8:04 [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 2/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 3/9] dt-bindings: i2c: at91: add binding for enable-dig-filtr Eugen.Hristev
2019-06-25 8:57 ` Peter Rosin [this message]
2019-06-25 8:04 ` [PATCH v2 4/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 5/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt Eugen.Hristev
2019-06-25 8:55 ` Peter Rosin
2019-06-25 9:14 ` Eugen.Hristev
2019-06-25 9:31 ` Alexandre Belloni
2019-06-25 9:55 ` I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt) Wolfram Sang
2019-06-27 13:22 ` Alexandre Belloni
2019-06-27 13:31 ` Eugen.Hristev
2019-06-27 13:34 ` Wolfram Sang
2019-06-27 13:39 ` Alexandre Belloni
2019-06-25 8:05 ` [PATCH v2 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 8/9] ARM: dts: at91: sama5d2_xplained: add analogic and digital filter for i2c Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 9/9] ARM: dts: at91: sama5d4_xplained: add analogic " Eugen.Hristev
2019-06-25 8:51 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f9cae4-0281-e1da-3c7d-69600f7562cd@axentia.se \
--to=peda@axentia.se \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®